[PR #21] [MERGED] Fix playWhenReady #1371

New Issue

2026-04-24T23:58:00+02:00

adam commented

2026-04-24 23:58:00 +02:00

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf-app/pull/21
Author: @svdztn
Created: 10/29/2021
Status: ✅ Merged
Merged: 10/30/2021
Merged by: @advplyr

Base: master ← Head: fix_playWhenReady

📝 Commits (2)

37fea5c fix playWhenReady, prevent open stream with closed id
5757d90 fix media notification operation without seekback

📊 Changes

3 files changed (+24 additions, -13 deletions)

View changed files

📝 android/app/src/main/java/com/audiobookshelf/app/PlayerNotificationService.kt (+17 -7)
📝 components/AudioPlayerMini.vue (+6 -6)
📝 components/app/StreamContainer.vue (+1 -0)

📄 Description

playWhenReady is ok now.
Found another problem: no “seekback” when operating with media notification.
So move the “seekback” to onEvents() -> Player.EVENT_IS_PLAYING_CHANGED.
Although there may be some subtle lag, but it works.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf-app/pull/21 **Author:** [@svdztn](https://github.com/svdztn) **Created:** 10/29/2021 **Status:** ✅ Merged **Merged:** 10/30/2021 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `fix_playWhenReady` --- ### 📝 Commits (2) - [`37fea5c`](https://github.com/advplyr/audiobookshelf-app/commit/37fea5c772e3228db43b2ab014503042ae8c8cf6) fix playWhenReady, prevent open stream with closed id - [`5757d90`](https://github.com/advplyr/audiobookshelf-app/commit/5757d90b05119e734e5c34f6bacbed21546b12af) fix media notification operation without seekback ### 📊 Changes **3 files changed** (+24 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `android/app/src/main/java/com/audiobookshelf/app/PlayerNotificationService.kt` (+17 -7) 📝 `components/AudioPlayerMini.vue` (+6 -6) 📝 `components/app/StreamContainer.vue` (+1 -0) </details> ### 📄 Description 1. `playWhenReady` is ok now. 2. Found another problem: no “seekback” when operating with media notification. So move the “seekback” to `onEvents() -> Player.EVENT_IS_PLAYING_CHANGED`. Although there may be some subtle lag, but it works. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2026-04-24 23:58:00 +02:00

adam closed this issue

2026-04-24 23:58:01 +02:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/audiobookshelf-app#1371