Small improvements

ios/App/Shared/util/ApiClient.swift

@@ -9,6 +9,14 @@ import Foundation
 import Alamofire
 
 class ApiClient {
+    public static func getData(from url: URL, completion: @escaping (UIImage?) -> Void) {
+        URLSession.shared.dataTask(with: url, completionHandler: {(data, response, error) in
+            if let data = data {
+                completion(UIImage(data:data))
+            }
+        }).resume()
+    }
+    
     public static func postResource<T: Decodable>(endpoint: String, parameters: [String: String], decodable: T.Type = T.self, callback: ((_ param: T) -> Void)?) {
         if (Store.serverConfig == nil) {
             NSLog("Server config not set")
@@ -54,7 +62,6 @@ class ApiClient {
     }
     
     public static func startPlaybackSession(libraryItemId: String, episodeId: String?, callback: @escaping (_ param: PlaybackSession) -> Void) {
-        
         var endpoint = "api/items/\(libraryItemId)/play"
         if episodeId != nil {
             endpoint += "/\(episodeId!)"

ios/App/Shared/util/Database.swift

@@ -10,16 +10,25 @@ import RealmSwift
 
 class Database {
     // All DB releated actions must be executed on "realm-queue"
-    public static let realmQueue = DispatchQueue(label: "realm-queue")
-    private static var instance: Realm = try! Realm(queue: realmQueue)
+    public static let realmQueue: DispatchQueue = DispatchQueue(label: "realm-queue")
+    public static var shared = {
+        realmQueue.sync {
+            return Database()
+        }
+    }()
+
+    private var instance: Realm
+    private init() {
+        self.instance = try! Realm(queue: Database.realmQueue)
+    }
     
-    public static func setServerConnectionConfig(config: ServerConnectionConfig) {
+    public func setServerConnectionConfig(config: ServerConnectionConfig) {
         var refrence: ThreadSafeReference<ServerConnectionConfig>?
         if config.realm != nil {
             refrence = ThreadSafeReference(to: config)
         }
         
-        realmQueue.sync {
+        Database.realmQueue.sync {
             let existing: ServerConnectionConfig? = instance.object(ofType: ServerConnectionConfig.self, forPrimaryKey: config.id)
             
             if config.index == 0 {
@@ -55,8 +64,8 @@ class Database {
             setLastActiveConfigIndex(index: config.index)
         }
     }
-    public static func deleteServerConnectionConfig(id: String) {
-        realmQueue.sync {
+    public func deleteServerConnectionConfig(id: String) {
+        Database.realmQueue.sync {
             let config = instance.object(ofType: ServerConnectionConfig.self, forPrimaryKey: id)
             
             do {
@@ -71,10 +80,10 @@ class Database {
             }
         }
     }
-    public static func getServerConnectionConfigs() -> [ServerConnectionConfig] {
+    public func getServerConnectionConfigs() -> [ServerConnectionConfig] {
         var refrences: [ThreadSafeReference<ServerConnectionConfig>] = []
         
-        realmQueue.sync {
+        Database.realmQueue.sync {
             let configs = instance.objects(ServerConnectionConfig.self)
             refrences = configs.map { config in
                 return ThreadSafeReference(to: config)
@@ -94,12 +103,12 @@ class Database {
         }
     }
     
-    public static func setLastActiveConfigIndexToNil() {
-        realmQueue.sync {
+    public func setLastActiveConfigIndexToNil() {
+        Database.realmQueue.sync {
             setLastActiveConfigIndex(index: nil)
         }
     }
-    public static func setLastActiveConfigIndex(index: Int?) {
+    public func setLastActiveConfigIndex(index: Int?) {
         let existing = instance.objects(ServerConnectionConfigActiveIndex.self)
         let obj = ServerConnectionConfigActiveIndex()
         obj.index = index
@@ -114,8 +123,8 @@ class Database {
             debugPrint(exception)
         }
     }
-    public static func getLastActiveConfigIndex() -> Int? {
-        return realmQueue.sync {
+    public func getLastActiveConfigIndex() -> Int? {
+        return Database.realmQueue.sync {
             return instance.objects(ServerConnectionConfigActiveIndex.self).first?.index ?? nil
         }
     }

ios/App/Shared/util/Extensions.swift

@@ -18,3 +18,14 @@ extension Encodable {
     return dictionary
   }
 }
+extension DispatchQueue {
+    static func runOnMainQueue(callback: @escaping (() -> Void)) {
+        if Thread.isMainThread {
+            callback()
+        } else {
+            DispatchQueue.main.sync {
+                callback()
+            }
+        }
+    }
+}

ios/App/Shared/util/NowPlayingInfo.swift

@@ -8,14 +8,6 @@
 import Foundation
 import MediaPlayer
 
-func getData(from url: URL, completion: @escaping (UIImage?) -> Void) {
-    URLSession.shared.dataTask(with: url, completionHandler: {(data, response, error) in
-        if let data = data {
-            completion(UIImage(data:data))
-        }
-    }).resume()
-}
-
 struct NowPlayingMetadata {
     var id: String
     var itemId: String
@@ -26,22 +18,22 @@ struct NowPlayingMetadata {
 }
 
 class NowPlayingInfo {
-    private static var nowPlayingInfo: [String: Any] = [:]
+    static var shared = {
+        return NowPlayingInfo()
+    }()
     
-    public static func setSessionMetadata(metadata: NowPlayingMetadata) {
+    private var nowPlayingInfo: [String: Any]
+    private init() {
+        self.nowPlayingInfo = [:]
+    }
+    
+    public func setSessionMetadata(metadata: NowPlayingMetadata) {
         setMetadata(artwork: nil, metadata: metadata)
         
-        /*
-        if !shouldFetchCover(id: metadata.id) || metadata.artworkUrl == nil {
-            return
-        }
-         */
-        
         guard let url = URL(string: "\(Store.serverConfig!.address)/api/items/\(metadata.itemId)/cover?token=\(Store.serverConfig!.token)") else {
             return
         }
-        
-        getData(from: url) { [self] image in
+        ApiClient.getData(from: url) { [self] image in
             guard let downloadedImage = image else {
                 return
             }
@@ -52,7 +44,7 @@ class NowPlayingInfo {
             self.setMetadata(artwork: artwork, metadata: metadata)
         }
     }
-    public static func update(duration: Double, currentTime: Double, rate: Float) {
+    public func update(duration: Double, currentTime: Double, rate: Float) {
         nowPlayingInfo[MPMediaItemPropertyPlaybackDuration] = duration
         nowPlayingInfo[MPNowPlayingInfoPropertyElapsedPlaybackTime] = currentTime
         nowPlayingInfo[MPNowPlayingInfoPropertyPlaybackRate] = rate
@@ -60,12 +52,12 @@ class NowPlayingInfo {
             
         MPNowPlayingInfoCenter.default().nowPlayingInfo = nowPlayingInfo
     }
-    public static func reset() {
+    public func reset() {
         nowPlayingInfo = [:]
         MPNowPlayingInfoCenter.default().nowPlayingInfo = nil
     }
     
-    private static func setMetadata(artwork: MPMediaItemArtwork?, metadata: NowPlayingMetadata?) {
+    private func setMetadata(artwork: MPMediaItemArtwork?, metadata: NowPlayingMetadata?) {
         if metadata == nil {
             return
         }
@@ -84,7 +76,7 @@ class NowPlayingInfo {
         nowPlayingInfo[MPMediaItemPropertyArtist] = metadata!.author ?? "unknown"
         nowPlayingInfo[MPMediaItemPropertyAlbumTitle] = metadata!.series
     }
-    private static func shouldFetchCover(id: String) -> Bool {
+    private func shouldFetchCover(id: String) -> Bool {
         nowPlayingInfo[MPNowPlayingInfoPropertyExternalContentIdentifier] as? String != id || nowPlayingInfo[MPMediaItemPropertyArtwork] == nil
     }
 }

ios/App/Shared/util/Store.swift

@@ -16,9 +16,9 @@ class Store {
         }
         set(updated) {
             if updated != nil {
-                Database.setServerConnectionConfig(config: updated!)
+                Database.shared.setServerConnectionConfig(config: updated!)
             } else {
-                Database.setLastActiveConfigIndexToNil()
+                Database.shared.setLastActiveConfigIndexToNil()
             }
             
             Database.realmQueue.sync {