mirror of
https://github.com/davidkaya/aryx.git
synced 2026-08-06 19:58:43 +02:00
Compare commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
9a261780c6 | ||
|
|
9b7e4dd6e9 | ||
|
|
4bc2c327f7 |
+1
-1
@@ -1,6 +1,6 @@
|
|||||||
{
|
{
|
||||||
"name": "aryx",
|
"name": "aryx",
|
||||||
"version": "0.0.18",
|
"version": "0.0.19",
|
||||||
"description": "Orchestrator for Copilot-powered agent workflows across multiple projects.",
|
"description": "Orchestrator for Copilot-powered agent workflows across multiple projects.",
|
||||||
"private": true,
|
"private": true,
|
||||||
"main": "dist-electron/main/index.js",
|
"main": "dist-electron/main/index.js",
|
||||||
|
|||||||
@@ -98,7 +98,7 @@ internal sealed class CopilotApprovalCoordinator
|
|||||||
{
|
{
|
||||||
string? toolName = ResolveApprovalToolName(request, toolNamesByCallId);
|
string? toolName = ResolveApprovalToolName(request, toolNamesByCallId);
|
||||||
string? autoApprovedToolName = ResolveAutoApprovedToolName(request);
|
string? autoApprovedToolName = ResolveAutoApprovedToolName(request);
|
||||||
string? mcpServerApprovalKey = ResolveMcpServerApprovalKey(request);
|
string? mcpServerApprovalKey = ResolveMcpServerApprovalKey(request, command.Tooling?.McpServers);
|
||||||
string? approvalCacheKey = ResolveApprovalCacheKey(toolName, autoApprovedToolName);
|
string? approvalCacheKey = ResolveApprovalCacheKey(toolName, autoApprovedToolName);
|
||||||
|
|
||||||
AgentActivityEventDto? fileChangeActivity = BuildToolCallFileChangeActivity(command, agent, request, toolName);
|
AgentActivityEventDto? fileChangeActivity = BuildToolCallFileChangeActivity(command, agent, request, toolName);
|
||||||
@@ -155,18 +155,7 @@ internal sealed class CopilotApprovalCoordinator
|
|||||||
string approvalId,
|
string approvalId,
|
||||||
string? toolName)
|
string? toolName)
|
||||||
{
|
{
|
||||||
string permissionKind = string.IsNullOrWhiteSpace(request.Kind)
|
string permissionKind = ResolvePermissionKind(request, command.Tooling?.McpServers);
|
||||||
? "tool access"
|
|
||||||
: request.Kind.Trim();
|
|
||||||
|
|
||||||
if (request is PermissionRequestHook hook)
|
|
||||||
{
|
|
||||||
string? resolvedCategory = ResolveHookToolCategory(hook.ToolName);
|
|
||||||
if (resolvedCategory is not null)
|
|
||||||
{
|
|
||||||
permissionKind = resolvedCategory;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
string agentName = string.IsNullOrWhiteSpace(agent.Name) ? agent.Id : agent.Name;
|
string agentName = string.IsNullOrWhiteSpace(agent.Name) ? agent.Id : agent.Name;
|
||||||
string? sessionId = NormalizeOptionalString(invocation.SessionId);
|
string? sessionId = NormalizeOptionalString(invocation.SessionId);
|
||||||
@@ -208,7 +197,7 @@ internal sealed class CopilotApprovalCoordinator
|
|||||||
PermissionKind = permissionKind,
|
PermissionKind = permissionKind,
|
||||||
Title = title,
|
Title = title,
|
||||||
Detail = detail,
|
Detail = detail,
|
||||||
PermissionDetail = BuildPermissionDetail(request),
|
PermissionDetail = BuildPermissionDetail(request, command.Tooling?.McpServers),
|
||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -252,7 +241,9 @@ internal sealed class CopilotApprovalCoordinator
|
|||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
internal static PermissionDetailDto BuildPermissionDetail(PermissionRequest request)
|
internal static PermissionDetailDto BuildPermissionDetail(
|
||||||
|
PermissionRequest request,
|
||||||
|
IReadOnlyList<RunTurnMcpServerConfigDto>? configuredMcpServers = null)
|
||||||
{
|
{
|
||||||
ArgumentNullException.ThrowIfNull(request);
|
ArgumentNullException.ThrowIfNull(request);
|
||||||
|
|
||||||
@@ -309,12 +300,7 @@ internal sealed class CopilotApprovalCoordinator
|
|||||||
ToolDescription = NormalizeOptionalString(customTool.ToolDescription),
|
ToolDescription = NormalizeOptionalString(customTool.ToolDescription),
|
||||||
Args = customTool.Args,
|
Args = customTool.Args,
|
||||||
},
|
},
|
||||||
PermissionRequestHook hook => new PermissionDetailDto
|
PermissionRequestHook hook => BuildHookPermissionDetail(hook, configuredMcpServers),
|
||||||
{
|
|
||||||
Kind = HookPermissionKind,
|
|
||||||
Args = hook.ToolArgs,
|
|
||||||
HookMessage = NormalizeOptionalString(hook.HookMessage),
|
|
||||||
},
|
|
||||||
_ => new PermissionDetailDto
|
_ => new PermissionDetailDto
|
||||||
{
|
{
|
||||||
Kind = NormalizeOptionalString(request.Kind) ?? "unknown",
|
Kind = NormalizeOptionalString(request.Kind) ?? "unknown",
|
||||||
@@ -430,15 +416,45 @@ internal sealed class CopilotApprovalCoordinator
|
|||||||
|
|
||||||
private const string McpServerApprovalPrefix = "mcp_server:";
|
private const string McpServerApprovalPrefix = "mcp_server:";
|
||||||
|
|
||||||
private static string? ResolveMcpServerApprovalKey(PermissionRequest request)
|
private static string? ResolveMcpServerApprovalKey(
|
||||||
|
PermissionRequest request,
|
||||||
|
IReadOnlyList<RunTurnMcpServerConfigDto>? configuredMcpServers)
|
||||||
{
|
{
|
||||||
if (request is not PermissionRequestMcp mcp)
|
return request switch
|
||||||
|
{
|
||||||
|
PermissionRequestMcp mcp => BuildMcpServerApprovalKey(mcp.ServerName),
|
||||||
|
PermissionRequestHook hook => ResolveHookMcpServerApprovalKey(hook.ToolName, configuredMcpServers),
|
||||||
|
_ => null,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
internal static string? BuildMcpServerApprovalKey(string? serverName)
|
||||||
|
{
|
||||||
|
string? normalizedServerName = NormalizeOptionalString(serverName);
|
||||||
|
return normalizedServerName is not null ? $"{McpServerApprovalPrefix}{normalizedServerName}" : null;
|
||||||
|
}
|
||||||
|
|
||||||
|
internal static string? ResolveHookMcpServerApprovalKey(
|
||||||
|
string? toolName,
|
||||||
|
IReadOnlyList<RunTurnMcpServerConfigDto>? configuredMcpServers)
|
||||||
|
=> BuildMcpServerApprovalKey(ResolveHookMcpServerName(toolName, configuredMcpServers));
|
||||||
|
|
||||||
|
internal static string? ResolveHookMcpServerName(
|
||||||
|
string? toolName,
|
||||||
|
IReadOnlyList<RunTurnMcpServerConfigDto>? configuredMcpServers)
|
||||||
|
{
|
||||||
|
string? normalizedToolName = NormalizeOptionalString(toolName);
|
||||||
|
if (normalizedToolName is null || configuredMcpServers is null || configuredMcpServers.Count == 0)
|
||||||
{
|
{
|
||||||
return null;
|
return null;
|
||||||
}
|
}
|
||||||
|
|
||||||
string? serverName = NormalizeOptionalString(mcp.ServerName);
|
return configuredMcpServers
|
||||||
return serverName is not null ? $"{McpServerApprovalPrefix}{serverName}" : null;
|
.Select(ResolveConfiguredMcpServerName)
|
||||||
|
.OfType<string>()
|
||||||
|
.Distinct(StringComparer.OrdinalIgnoreCase)
|
||||||
|
.OrderByDescending(static serverName => serverName.Length)
|
||||||
|
.FirstOrDefault(serverName => MatchesHookMcpServerToolName(normalizedToolName, serverName));
|
||||||
}
|
}
|
||||||
|
|
||||||
private static string? ResolveApprovalCacheKey(
|
private static string? ResolveApprovalCacheKey(
|
||||||
@@ -520,6 +536,87 @@ internal sealed class CopilotApprovalCoordinator
|
|||||||
return HookToolCategories.TryGetValue(normalized, out string? category) ? category : null;
|
return HookToolCategories.TryGetValue(normalized, out string? category) ? category : null;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
private static string ResolvePermissionKind(
|
||||||
|
PermissionRequest request,
|
||||||
|
IReadOnlyList<RunTurnMcpServerConfigDto>? configuredMcpServers)
|
||||||
|
{
|
||||||
|
string permissionKind = string.IsNullOrWhiteSpace(request.Kind)
|
||||||
|
? "tool access"
|
||||||
|
: request.Kind.Trim();
|
||||||
|
|
||||||
|
if (request is not PermissionRequestHook hook)
|
||||||
|
{
|
||||||
|
return permissionKind;
|
||||||
|
}
|
||||||
|
|
||||||
|
string? resolvedCategory = ResolveHookToolCategory(hook.ToolName);
|
||||||
|
if (resolvedCategory is not null)
|
||||||
|
{
|
||||||
|
return resolvedCategory;
|
||||||
|
}
|
||||||
|
|
||||||
|
return ResolveHookMcpServerName(hook.ToolName, configuredMcpServers) is not null
|
||||||
|
? McpPermissionKind
|
||||||
|
: permissionKind;
|
||||||
|
}
|
||||||
|
|
||||||
|
private static PermissionDetailDto BuildHookPermissionDetail(
|
||||||
|
PermissionRequestHook hook,
|
||||||
|
IReadOnlyList<RunTurnMcpServerConfigDto>? configuredMcpServers)
|
||||||
|
{
|
||||||
|
string? serverName = ResolveHookMcpServerName(hook.ToolName, configuredMcpServers);
|
||||||
|
if (serverName is null)
|
||||||
|
{
|
||||||
|
return new PermissionDetailDto
|
||||||
|
{
|
||||||
|
Kind = HookPermissionKind,
|
||||||
|
Args = hook.ToolArgs,
|
||||||
|
HookMessage = NormalizeOptionalString(hook.HookMessage),
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
return new PermissionDetailDto
|
||||||
|
{
|
||||||
|
Kind = McpPermissionKind,
|
||||||
|
ServerName = serverName,
|
||||||
|
ToolTitle = ResolveHookMcpToolTitle(hook.ToolName, serverName),
|
||||||
|
Args = hook.ToolArgs,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
private static string? ResolveConfiguredMcpServerName(RunTurnMcpServerConfigDto configuredServer)
|
||||||
|
=> NormalizeOptionalString(configuredServer.Name) ?? NormalizeOptionalString(configuredServer.Id);
|
||||||
|
|
||||||
|
private static bool MatchesHookMcpServerToolName(string toolName, string serverName)
|
||||||
|
{
|
||||||
|
if (string.Equals(toolName, serverName, StringComparison.OrdinalIgnoreCase))
|
||||||
|
{
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
|
||||||
|
return toolName.StartsWith($"{serverName}-", StringComparison.OrdinalIgnoreCase);
|
||||||
|
}
|
||||||
|
|
||||||
|
private static string? ResolveHookMcpToolTitle(string? toolName, string serverName)
|
||||||
|
{
|
||||||
|
string? normalizedToolName = NormalizeOptionalString(toolName);
|
||||||
|
if (normalizedToolName is null)
|
||||||
|
{
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
|
||||||
|
string prefix = $"{serverName}-";
|
||||||
|
if (!normalizedToolName.StartsWith(prefix, StringComparison.OrdinalIgnoreCase))
|
||||||
|
{
|
||||||
|
return normalizedToolName;
|
||||||
|
}
|
||||||
|
|
||||||
|
string strippedToolName = normalizedToolName[prefix.Length..];
|
||||||
|
return string.IsNullOrWhiteSpace(strippedToolName)
|
||||||
|
? normalizedToolName
|
||||||
|
: strippedToolName;
|
||||||
|
}
|
||||||
|
|
||||||
private static bool MatchesAutoApprovedTool(
|
private static bool MatchesAutoApprovedTool(
|
||||||
IReadOnlyList<string> autoApprovedToolNames,
|
IReadOnlyList<string> autoApprovedToolNames,
|
||||||
string? toolName,
|
string? toolName,
|
||||||
|
|||||||
@@ -249,12 +249,16 @@ internal static class CopilotSessionHooks
|
|||||||
}
|
}
|
||||||
|
|
||||||
string? autoApprovedToolName = CopilotApprovalCoordinator.ResolveHookToolCategory(toolName) ?? toolName;
|
string? autoApprovedToolName = CopilotApprovalCoordinator.ResolveHookToolCategory(toolName) ?? toolName;
|
||||||
|
string? mcpServerApprovalKey = CopilotApprovalCoordinator.ResolveHookMcpServerApprovalKey(
|
||||||
|
toolName,
|
||||||
|
command.Tooling?.McpServers);
|
||||||
|
|
||||||
bool requiresApproval = CopilotApprovalCoordinator.RequiresToolCallApproval(
|
bool requiresApproval = CopilotApprovalCoordinator.RequiresToolCallApproval(
|
||||||
command.Pattern.ApprovalPolicy,
|
command.Pattern.ApprovalPolicy,
|
||||||
agentDefinition.Id,
|
agentDefinition.Id,
|
||||||
toolName,
|
toolName,
|
||||||
autoApprovedToolName);
|
autoApprovedToolName,
|
||||||
|
mcpServerApprovalKey);
|
||||||
|
|
||||||
return new PreToolUseHookOutput
|
return new PreToolUseHookOutput
|
||||||
{
|
{
|
||||||
|
|||||||
@@ -171,6 +171,40 @@ public sealed class CopilotSessionHooksTests
|
|||||||
Assert.Equal("allow", decision?.PermissionDecision);
|
Assert.Equal("allow", decision?.PermissionDecision);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task Create_PreToolUseAutoAllowsWhenMcpServerIsApproved()
|
||||||
|
{
|
||||||
|
RunTurnCommandDto command = CreateCommandWithConfiguredMcpServers(
|
||||||
|
["icm-mcp"],
|
||||||
|
["mcp_server:icm-mcp"]);
|
||||||
|
SessionHooks hooks = CopilotSessionHooks.Create(command, command.Pattern.Agents[0], ResolvedHookSet.Empty, new RecordingHookCommandRunner());
|
||||||
|
|
||||||
|
PreToolUseHookOutput? decision = await hooks.OnPreToolUse!(
|
||||||
|
new PreToolUseHookInput
|
||||||
|
{
|
||||||
|
ToolName = "icm-mcp-get_incident_details_by_id",
|
||||||
|
},
|
||||||
|
null!);
|
||||||
|
|
||||||
|
Assert.Equal("allow", decision?.PermissionDecision);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task Create_PreToolUseRequiresApprovalWhenMcpServerIsNotApproved()
|
||||||
|
{
|
||||||
|
RunTurnCommandDto command = CreateCommandWithConfiguredMcpServers(["icm-mcp"]);
|
||||||
|
SessionHooks hooks = CopilotSessionHooks.Create(command, command.Pattern.Agents[0], ResolvedHookSet.Empty, new RecordingHookCommandRunner());
|
||||||
|
|
||||||
|
PreToolUseHookOutput? decision = await hooks.OnPreToolUse!(
|
||||||
|
new PreToolUseHookInput
|
||||||
|
{
|
||||||
|
ToolName = "icm-mcp-get_incident_details_by_id",
|
||||||
|
},
|
||||||
|
null!);
|
||||||
|
|
||||||
|
Assert.Equal("ask", decision?.PermissionDecision);
|
||||||
|
}
|
||||||
|
|
||||||
[Fact]
|
[Fact]
|
||||||
public async Task Create_RunsConfiguredNonPreToolHooks()
|
public async Task Create_RunsConfiguredNonPreToolHooks()
|
||||||
{
|
{
|
||||||
@@ -368,6 +402,43 @@ public sealed class CopilotSessionHooksTests
|
|||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
|
private static RunTurnCommandDto CreateCommandWithConfiguredMcpServers(
|
||||||
|
IReadOnlyList<string> serverNames,
|
||||||
|
IReadOnlyList<string>? autoApprovedToolNames = null)
|
||||||
|
{
|
||||||
|
RunTurnCommandDto command = CreateCommandWithToolApproval();
|
||||||
|
return new RunTurnCommandDto
|
||||||
|
{
|
||||||
|
RequestId = command.RequestId,
|
||||||
|
SessionId = command.SessionId,
|
||||||
|
ProjectPath = command.ProjectPath,
|
||||||
|
Tooling = new RunTurnToolingConfigDto
|
||||||
|
{
|
||||||
|
McpServers = [.. serverNames.Select(CreateMcpServerConfig)],
|
||||||
|
},
|
||||||
|
Pattern = new PatternDefinitionDto
|
||||||
|
{
|
||||||
|
Id = command.Pattern.Id,
|
||||||
|
Name = command.Pattern.Name,
|
||||||
|
Mode = command.Pattern.Mode,
|
||||||
|
Availability = command.Pattern.Availability,
|
||||||
|
ApprovalPolicy = new ApprovalPolicyDto
|
||||||
|
{
|
||||||
|
Rules = command.Pattern.ApprovalPolicy?.Rules ?? [],
|
||||||
|
AutoApprovedToolNames = autoApprovedToolNames ?? [],
|
||||||
|
},
|
||||||
|
Agents = command.Pattern.Agents,
|
||||||
|
},
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
private static RunTurnMcpServerConfigDto CreateMcpServerConfig(string serverName)
|
||||||
|
=> new()
|
||||||
|
{
|
||||||
|
Id = serverName,
|
||||||
|
Name = serverName,
|
||||||
|
};
|
||||||
|
|
||||||
private static HookCommandDefinition CreateHookCommand(string name)
|
private static HookCommandDefinition CreateHookCommand(string name)
|
||||||
=> new()
|
=> new()
|
||||||
{
|
{
|
||||||
|
|||||||
@@ -1325,6 +1325,29 @@ public sealed class CopilotWorkflowRunnerTests
|
|||||||
Assert.Equal("https://example.com", args["url"]);
|
Assert.Equal("https://example.com", args["url"]);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void BuildPermissionDetail_MapsConfiguredMcpHookToMcpDetail()
|
||||||
|
{
|
||||||
|
PermissionDetailDto detail = CopilotApprovalCoordinator.BuildPermissionDetail(
|
||||||
|
new PermissionRequestHook
|
||||||
|
{
|
||||||
|
Kind = "hook",
|
||||||
|
ToolName = "icm-mcp-get_incident_details_by_id",
|
||||||
|
ToolArgs = new Dictionary<string, object?>
|
||||||
|
{
|
||||||
|
["incidentId"] = 769904783,
|
||||||
|
},
|
||||||
|
},
|
||||||
|
[CreateMcpServerConfig("icm-mcp")]);
|
||||||
|
|
||||||
|
Assert.Equal("mcp", detail.Kind);
|
||||||
|
Assert.Equal("icm-mcp", detail.ServerName);
|
||||||
|
Assert.Equal("get_incident_details_by_id", detail.ToolTitle);
|
||||||
|
|
||||||
|
Dictionary<string, object?> args = Assert.IsType<Dictionary<string, object?>>(detail.Args);
|
||||||
|
Assert.Equal(769904783, args["incidentId"]);
|
||||||
|
}
|
||||||
|
|
||||||
[Theory]
|
[Theory]
|
||||||
[InlineData("view", "read")]
|
[InlineData("view", "read")]
|
||||||
[InlineData("glob", "read")]
|
[InlineData("glob", "read")]
|
||||||
@@ -1362,6 +1385,16 @@ public sealed class CopilotWorkflowRunnerTests
|
|||||||
Assert.Null(CopilotApprovalCoordinator.ResolveHookToolCategory(" "));
|
Assert.Null(CopilotApprovalCoordinator.ResolveHookToolCategory(" "));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void ResolveHookMcpServerApprovalKey_PrefersLongestConfiguredServerName()
|
||||||
|
{
|
||||||
|
string? approvalKey = CopilotApprovalCoordinator.ResolveHookMcpServerApprovalKey(
|
||||||
|
"icm-mcp-get_on_call_schedule",
|
||||||
|
[CreateMcpServerConfig("icm"), CreateMcpServerConfig("icm-mcp")]);
|
||||||
|
|
||||||
|
Assert.Equal("mcp_server:icm-mcp", approvalKey);
|
||||||
|
}
|
||||||
|
|
||||||
[Fact]
|
[Fact]
|
||||||
public void TryGetApprovalToolName_ResolvesHookToolToCategory()
|
public void TryGetApprovalToolName_ResolvesHookToolToCategory()
|
||||||
{
|
{
|
||||||
@@ -1448,6 +1481,41 @@ public sealed class CopilotWorkflowRunnerTests
|
|||||||
Assert.Contains("read permission", approvalEvent.Detail);
|
Assert.Contains("read permission", approvalEvent.Detail);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void BuildPermissionApprovalEvent_UsesMcpKindForConfiguredMcpHookTools()
|
||||||
|
{
|
||||||
|
ApprovalRequestedEventDto approvalEvent = CopilotApprovalCoordinator.BuildPermissionApprovalEvent(
|
||||||
|
new RunTurnCommandDto
|
||||||
|
{
|
||||||
|
RequestId = "turn-1",
|
||||||
|
SessionId = "session-1",
|
||||||
|
Tooling = new RunTurnToolingConfigDto
|
||||||
|
{
|
||||||
|
McpServers = [CreateMcpServerConfig("icm-mcp")],
|
||||||
|
},
|
||||||
|
},
|
||||||
|
CreateAgent("agent-1", "Primary"),
|
||||||
|
new PermissionRequestHook
|
||||||
|
{
|
||||||
|
Kind = "hook",
|
||||||
|
ToolName = "icm-mcp-get_schedule",
|
||||||
|
ToolArgs = """{"teamIds":[91982]}""",
|
||||||
|
},
|
||||||
|
new PermissionInvocation
|
||||||
|
{
|
||||||
|
SessionId = "copilot-session-1",
|
||||||
|
},
|
||||||
|
"approval-1",
|
||||||
|
"icm-mcp-get_schedule");
|
||||||
|
|
||||||
|
Assert.Equal("mcp", approvalEvent.PermissionKind);
|
||||||
|
Assert.Contains("mcp permission", approvalEvent.Detail);
|
||||||
|
Assert.NotNull(approvalEvent.PermissionDetail);
|
||||||
|
Assert.Equal("mcp", approvalEvent.PermissionDetail!.Kind);
|
||||||
|
Assert.Equal("icm-mcp", approvalEvent.PermissionDetail.ServerName);
|
||||||
|
Assert.Equal("get_schedule", approvalEvent.PermissionDetail.ToolTitle);
|
||||||
|
}
|
||||||
|
|
||||||
[Fact]
|
[Fact]
|
||||||
public void BuildPermissionApprovalEvent_KeepsHookKindForUnknownHookTools()
|
public void BuildPermissionApprovalEvent_KeepsHookKindForUnknownHookTools()
|
||||||
{
|
{
|
||||||
@@ -1613,6 +1681,43 @@ public sealed class CopilotWorkflowRunnerTests
|
|||||||
Assert.Equal(PermissionRequestResultKind.Approved, result.Kind);
|
Assert.Equal(PermissionRequestResultKind.Approved, result.Kind);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task RequestApprovalAsync_AutoApprovesHookRequestsForApprovedMcpServer()
|
||||||
|
{
|
||||||
|
CopilotApprovalCoordinator coordinator = new();
|
||||||
|
bool sawApproval = false;
|
||||||
|
RunTurnCommandDto command = CreateApprovalCommand(
|
||||||
|
autoApprovedToolNames: ["mcp_server:icm-mcp"],
|
||||||
|
mcpServers: [CreateMcpServerConfig("icm-mcp")]);
|
||||||
|
|
||||||
|
PermissionRequestResult result = await coordinator.RequestApprovalAsync(
|
||||||
|
command,
|
||||||
|
command.Pattern.Agents[0],
|
||||||
|
new PermissionRequestHook
|
||||||
|
{
|
||||||
|
Kind = "hook",
|
||||||
|
ToolName = "icm-mcp-get_incident_details_by_id",
|
||||||
|
ToolArgs = new Dictionary<string, object?>
|
||||||
|
{
|
||||||
|
["incidentId"] = 769904783,
|
||||||
|
},
|
||||||
|
},
|
||||||
|
new PermissionInvocation
|
||||||
|
{
|
||||||
|
SessionId = "copilot-session-1",
|
||||||
|
},
|
||||||
|
new Dictionary<string, string>(StringComparer.Ordinal),
|
||||||
|
approval =>
|
||||||
|
{
|
||||||
|
sawApproval = true;
|
||||||
|
return Task.CompletedTask;
|
||||||
|
},
|
||||||
|
CancellationToken.None);
|
||||||
|
|
||||||
|
Assert.False(sawApproval);
|
||||||
|
Assert.Equal(PermissionRequestResultKind.Approved, result.Kind);
|
||||||
|
}
|
||||||
|
|
||||||
[Fact]
|
[Fact]
|
||||||
public async Task RequestApprovalAsync_AlwaysApproveCachesRuntimeApprovalForCurrentTurn()
|
public async Task RequestApprovalAsync_AlwaysApproveCachesRuntimeApprovalForCurrentTurn()
|
||||||
{
|
{
|
||||||
@@ -1853,12 +1958,21 @@ public sealed class CopilotWorkflowRunnerTests
|
|||||||
null!);
|
null!);
|
||||||
}
|
}
|
||||||
|
|
||||||
private static RunTurnCommandDto CreateApprovalCommand(string requestId = "turn-1")
|
private static RunTurnCommandDto CreateApprovalCommand(
|
||||||
|
string requestId = "turn-1",
|
||||||
|
IReadOnlyList<string>? autoApprovedToolNames = null,
|
||||||
|
IReadOnlyList<RunTurnMcpServerConfigDto>? mcpServers = null)
|
||||||
{
|
{
|
||||||
return new RunTurnCommandDto
|
return new RunTurnCommandDto
|
||||||
{
|
{
|
||||||
RequestId = requestId,
|
RequestId = requestId,
|
||||||
SessionId = "session-1",
|
SessionId = "session-1",
|
||||||
|
Tooling = mcpServers is null
|
||||||
|
? null
|
||||||
|
: new RunTurnToolingConfigDto
|
||||||
|
{
|
||||||
|
McpServers = [.. mcpServers],
|
||||||
|
},
|
||||||
Pattern = new PatternDefinitionDto
|
Pattern = new PatternDefinitionDto
|
||||||
{
|
{
|
||||||
Id = "pattern-1",
|
Id = "pattern-1",
|
||||||
@@ -1875,7 +1989,9 @@ public sealed class CopilotWorkflowRunnerTests
|
|||||||
AgentIds = ["agent-1"],
|
AgentIds = ["agent-1"],
|
||||||
},
|
},
|
||||||
],
|
],
|
||||||
AutoApprovedToolNames = ["web_fetch"],
|
AutoApprovedToolNames = autoApprovedToolNames is null
|
||||||
|
? ["web_fetch"]
|
||||||
|
: [.. autoApprovedToolNames],
|
||||||
},
|
},
|
||||||
Agents =
|
Agents =
|
||||||
[
|
[
|
||||||
@@ -1885,6 +2001,13 @@ public sealed class CopilotWorkflowRunnerTests
|
|||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
|
private static RunTurnMcpServerConfigDto CreateMcpServerConfig(string serverName)
|
||||||
|
=> new()
|
||||||
|
{
|
||||||
|
Id = serverName,
|
||||||
|
Name = serverName,
|
||||||
|
};
|
||||||
|
|
||||||
private sealed class StubChatClient : IChatClient
|
private sealed class StubChatClient : IChatClient
|
||||||
{
|
{
|
||||||
public Task<ChatResponse> GetResponseAsync(
|
public Task<ChatResponse> GetResponseAsync(
|
||||||
|
|||||||
@@ -8,7 +8,6 @@ import {
|
|||||||
FileText,
|
FileText,
|
||||||
Globe,
|
Globe,
|
||||||
Server,
|
Server,
|
||||||
Terminal,
|
|
||||||
} from 'lucide-react';
|
} from 'lucide-react';
|
||||||
|
|
||||||
import type { PermissionDetail } from '@shared/contracts/sidecar';
|
import type { PermissionDetail } from '@shared/contracts/sidecar';
|
||||||
@@ -61,6 +60,37 @@ export function permissionDetailSummary(detail: PermissionDetail): string | unde
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/* ── Display helpers ─────────────────────────────────────────── */
|
||||||
|
|
||||||
|
/** Recursively parse string values that contain JSON objects or arrays (display-time only). */
|
||||||
|
function deepParseJsonStrings(value: unknown): unknown {
|
||||||
|
if (typeof value === 'string') {
|
||||||
|
const trimmed = value.trim();
|
||||||
|
if (
|
||||||
|
(trimmed.startsWith('{') && trimmed.endsWith('}')) ||
|
||||||
|
(trimmed.startsWith('[') && trimmed.endsWith(']'))
|
||||||
|
) {
|
||||||
|
try {
|
||||||
|
return deepParseJsonStrings(JSON.parse(trimmed));
|
||||||
|
} catch {
|
||||||
|
return value;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return value;
|
||||||
|
}
|
||||||
|
if (Array.isArray(value)) {
|
||||||
|
return value.map(deepParseJsonStrings);
|
||||||
|
}
|
||||||
|
if (value !== null && typeof value === 'object') {
|
||||||
|
const result: Record<string, unknown> = {};
|
||||||
|
for (const [k, v] of Object.entries(value as Record<string, unknown>)) {
|
||||||
|
result[k] = deepParseJsonStrings(v);
|
||||||
|
}
|
||||||
|
return result;
|
||||||
|
}
|
||||||
|
return value;
|
||||||
|
}
|
||||||
|
|
||||||
/* ── Kind-specific renderers ────────────────────────────────── */
|
/* ── Kind-specific renderers ────────────────────────────────── */
|
||||||
|
|
||||||
function ShellDetail({ detail }: { detail: PermissionDetail }) {
|
function ShellDetail({ detail }: { detail: PermissionDetail }) {
|
||||||
@@ -134,7 +164,7 @@ function McpDetail({ detail }: { detail: PermissionDetail }) {
|
|||||||
)}
|
)}
|
||||||
</div>
|
</div>
|
||||||
{detail.args && Object.keys(detail.args).length > 0 && (
|
{detail.args && Object.keys(detail.args).length > 0 && (
|
||||||
<CollapsibleCode label="Arguments" text={JSON.stringify(detail.args, null, 2)} />
|
<CollapsibleCode label="Arguments" text={JSON.stringify(deepParseJsonStrings(detail.args), null, 2)} />
|
||||||
)}
|
)}
|
||||||
</div>
|
</div>
|
||||||
);
|
);
|
||||||
@@ -185,7 +215,7 @@ function CustomToolDetail({ detail }: { detail: PermissionDetail }) {
|
|||||||
<p className="text-[11px] text-[var(--color-text-secondary)]">{detail.toolDescription}</p>
|
<p className="text-[11px] text-[var(--color-text-secondary)]">{detail.toolDescription}</p>
|
||||||
)}
|
)}
|
||||||
{detail.args && Object.keys(detail.args).length > 0 && (
|
{detail.args && Object.keys(detail.args).length > 0 && (
|
||||||
<CollapsibleCode label="Arguments" text={JSON.stringify(detail.args, null, 2)} />
|
<CollapsibleCode label="Arguments" text={JSON.stringify(deepParseJsonStrings(detail.args), null, 2)} />
|
||||||
)}
|
)}
|
||||||
</div>
|
</div>
|
||||||
);
|
);
|
||||||
@@ -201,13 +231,13 @@ function HookDetail({ detail }: { detail: PermissionDetail }) {
|
|||||||
</div>
|
</div>
|
||||||
)}
|
)}
|
||||||
{detail.args && Object.keys(detail.args).length > 0 && (
|
{detail.args && Object.keys(detail.args).length > 0 && (
|
||||||
<CollapsibleCode label="Arguments" text={JSON.stringify(detail.args, null, 2)} />
|
<CollapsibleCode label="Arguments" text={JSON.stringify(deepParseJsonStrings(detail.args), null, 2)} />
|
||||||
)}
|
)}
|
||||||
</div>
|
</div>
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
/* ── Shared primitives ──────────────────────────────────────── */
|
/* ── Shared primitives──────────────────────────────────────── */
|
||||||
|
|
||||||
function IntentionLine({ text }: { text: string }) {
|
function IntentionLine({ text }: { text: string }) {
|
||||||
return <p className="text-[11px] italic text-[var(--color-text-secondary)]">{text}</p>;
|
return <p className="text-[11px] italic text-[var(--color-text-secondary)]">{text}</p>;
|
||||||
@@ -242,6 +272,47 @@ function DiffBlock({ text }: { text: string }) {
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/* ── JSON syntax highlighting ───────────────────────────────── */
|
||||||
|
|
||||||
|
const jsonTokenPattern =
|
||||||
|
/("(?:[^"\\]|\\.)*")(\s*:)?|\b(true|false|null)\b|(-?\d+(?:\.\d+)?(?:[eE][+-]?\d+)?)|([{}\[\],])/g;
|
||||||
|
|
||||||
|
function JsonHighlighted({ json }: { json: string }) {
|
||||||
|
const elements: React.ReactNode[] = [];
|
||||||
|
let lastIndex = 0;
|
||||||
|
let key = 0;
|
||||||
|
|
||||||
|
for (const match of json.matchAll(jsonTokenPattern)) {
|
||||||
|
const idx = match.index ?? 0;
|
||||||
|
if (idx > lastIndex) elements.push(json.slice(lastIndex, idx));
|
||||||
|
|
||||||
|
if (match[1] && match[2]) {
|
||||||
|
// Object key + colon
|
||||||
|
elements.push(
|
||||||
|
<span key={key++} className="text-[var(--color-text-accent)]">{match[1]}</span>,
|
||||||
|
<span key={key++} className="text-[var(--color-text-muted)]">{match[2]}</span>,
|
||||||
|
);
|
||||||
|
} else if (match[1]) {
|
||||||
|
// String value
|
||||||
|
elements.push(<span key={key++} className="text-[var(--color-status-success)]">{match[1]}</span>);
|
||||||
|
} else if (match[3]) {
|
||||||
|
// true / false / null
|
||||||
|
elements.push(<span key={key++} className="text-[var(--color-accent-sky)]">{match[3]}</span>);
|
||||||
|
} else if (match[4]) {
|
||||||
|
// Number
|
||||||
|
elements.push(<span key={key++} className="text-[var(--color-accent-sky)]">{match[4]}</span>);
|
||||||
|
} else if (match[5]) {
|
||||||
|
// Structural punctuation
|
||||||
|
elements.push(<span key={key++} className="text-[var(--color-text-muted)]">{match[5]}</span>);
|
||||||
|
}
|
||||||
|
|
||||||
|
lastIndex = idx + match[0].length;
|
||||||
|
}
|
||||||
|
|
||||||
|
if (lastIndex < json.length) elements.push(json.slice(lastIndex));
|
||||||
|
return <>{elements}</>;
|
||||||
|
}
|
||||||
|
|
||||||
function CollapsibleCode({
|
function CollapsibleCode({
|
||||||
label,
|
label,
|
||||||
text,
|
text,
|
||||||
@@ -254,6 +325,7 @@ function CollapsibleCode({
|
|||||||
defaultExpanded?: boolean;
|
defaultExpanded?: boolean;
|
||||||
}) {
|
}) {
|
||||||
const [expanded, setExpanded] = useState(defaultExpanded);
|
const [expanded, setExpanded] = useState(defaultExpanded);
|
||||||
|
const isJson = text.trimStart().startsWith('{') || text.trimStart().startsWith('[');
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<div className="rounded-md border border-[var(--color-border-subtle)] bg-[var(--color-surface-1)]">
|
<div className="rounded-md border border-[var(--color-border-subtle)] bg-[var(--color-surface-1)]">
|
||||||
@@ -272,7 +344,7 @@ function CollapsibleCode({
|
|||||||
<div className="border-t border-[var(--color-border-subtle)] px-2.5 py-1.5">
|
<div className="border-t border-[var(--color-border-subtle)] px-2.5 py-1.5">
|
||||||
{children ?? (
|
{children ?? (
|
||||||
<pre className="max-h-48 overflow-auto font-mono text-[10px] leading-relaxed text-[var(--color-text-primary)]">
|
<pre className="max-h-48 overflow-auto font-mono text-[10px] leading-relaxed text-[var(--color-text-primary)]">
|
||||||
{text}
|
{isJson ? <JsonHighlighted json={text} /> : text}
|
||||||
</pre>
|
</pre>
|
||||||
)}
|
)}
|
||||||
</div>
|
</div>
|
||||||
|
|||||||
Reference in New Issue
Block a user