feat: add graph-backed orchestration topology

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This commit is contained in:
David Kaya
2026-03-24 22:44:17 +01:00
co-authored by Copilot
parent 5ab0b22d15
commit 2e2caf78f9
13 changed files with 1871 additions and 39 deletions
+5 -3
View File
@@ -20,6 +20,7 @@ import {
} from '@shared/domain/models';
import {
isReasoningEffort,
syncPatternGraph,
type PatternDefinition,
type ReasoningEffort,
validatePatternDefinition,
@@ -212,8 +213,9 @@ export class EryxAppService extends EventEmitter<AppServiceEvents> {
async savePattern(pattern: PatternDefinition): Promise<WorkspaceState> {
const workspace = await this.loadWorkspace();
const knownApprovalToolNames = await this.listKnownApprovalToolNames(workspace);
const synchronizedPattern = syncPatternGraph(pattern);
const issues = validatePatternDefinition(
pattern,
synchronizedPattern,
knownApprovalToolNames,
).filter((issue) => issue.level === 'error');
if (issues.length > 0) {
@@ -222,8 +224,8 @@ export class EryxAppService extends EventEmitter<AppServiceEvents> {
const existingIndex = workspace.patterns.findIndex((current) => current.id === pattern.id);
const candidate: PatternDefinition = {
...pattern,
approvalPolicy: normalizeApprovalPolicy(pattern.approvalPolicy),
...synchronizedPattern,
approvalPolicy: normalizeApprovalPolicy(synchronizedPattern.approvalPolicy),
isFavorite: pattern.isFavorite ?? workspace.patterns[existingIndex]?.isFavorite,
createdAt: existingIndex >= 0 ? workspace.patterns[existingIndex].createdAt : nowIso(),
updatedAt: nowIso(),
+2 -1
View File
@@ -1,6 +1,6 @@
import { mkdir } from 'node:fs/promises';
import { createBuiltinPatterns } from '@shared/domain/pattern';
import { createBuiltinPatterns, resolvePatternGraph } from '@shared/domain/pattern';
import type { PatternDefinition } from '@shared/domain/pattern';
import { mergeScratchpadProject } from '@shared/domain/project';
import { normalizeSessionRunRecords } from '@shared/domain/runTimeline';
@@ -71,6 +71,7 @@ export class WorkspaceRepository {
patterns: mergePatterns(stored.patterns ?? []).map((pattern) => ({
...pattern,
approvalPolicy: normalizeApprovalPolicy(pattern.approvalPolicy),
graph: resolvePatternGraph(pattern),
})),
projects,
sessions: (stored.sessions ?? []).map((session) => ({
+3 -3
View File
@@ -21,7 +21,7 @@ import {
normalizePatternModels,
resolveReasoningEffort,
} from '@shared/domain/models';
import type { PatternDefinition } from '@shared/domain/pattern';
import { syncPatternGraph, type PatternDefinition } from '@shared/domain/pattern';
import { isScratchpadProject, SCRATCHPAD_PROJECT_ID } from '@shared/domain/project';
import { applyScratchpadSessionConfig } from '@shared/domain/session';
import type { AppearanceTheme, LspProfileDefinition, McpServerDefinition } from '@shared/domain/tooling';
@@ -30,7 +30,7 @@ import { createId, nowIso } from '@shared/utils/ids';
function createDraftPattern(defaultModelId: string, defaultReasoningEffort: PatternDefinition['agents'][0]['reasoningEffort']): PatternDefinition {
const timestamp = nowIso();
return {
return syncPatternGraph({
id: createId('custom-pattern'),
name: 'New Pattern',
description: '',
@@ -49,7 +49,7 @@ function createDraftPattern(defaultModelId: string, defaultReasoningEffort: Patt
],
createdAt: timestamp,
updatedAt: timestamp,
};
});
}
function createDraftMcpServer(): McpServerDefinition {
+12 -7
View File
@@ -24,6 +24,7 @@ import {
type ModelDefinition,
} from '@shared/domain/models';
import {
syncPatternGraph,
validatePatternDefinition,
type OrchestrationMode,
type PatternDefinition,
@@ -220,8 +221,12 @@ export function PatternEditor({
}: PatternEditorProps) {
const issues = validatePatternDefinition(pattern);
function emitChange(nextPattern: PatternDefinition) {
onChange(syncPatternGraph(nextPattern));
}
function updateAgent(agentId: string, patch: Partial<PatternAgentDefinition>) {
onChange({
emitChange({
...pattern,
agents: pattern.agents.map((a) => (a.id === agentId ? { ...a, ...patch } : a)),
});
@@ -236,7 +241,7 @@ export function PatternEditor({
}
function updateApprovalPolicy(updater: (current: ApprovalPolicy | undefined) => ApprovalPolicy | undefined) {
onChange({ ...pattern, approvalPolicy: updater(pattern.approvalPolicy) });
emitChange({ ...pattern, approvalPolicy: updater(pattern.approvalPolicy) });
}
function isCheckpointEnabled(kind: ApprovalCheckpointKind): boolean {
@@ -358,14 +363,14 @@ export function PatternEditor({
</h4>
<InputField
label="Name"
onChange={(v) => onChange({ ...pattern, name: v })}
onChange={(v) => emitChange({ ...pattern, name: v })}
placeholder="Pattern name"
value={pattern.name}
/>
<InputField
label="Description"
multiline
onChange={(v) => onChange({ ...pattern, description: v })}
onChange={(v) => emitChange({ ...pattern, description: v })}
placeholder="What this pattern does..."
value={pattern.description}
/>
@@ -394,7 +399,7 @@ export function PatternEditor({
}`}
disabled={disabled}
key={mode}
onClick={() => onChange({ ...pattern, mode })}
onClick={() => emitChange({ ...pattern, mode })}
type="button"
>
<div className="flex items-center gap-2">
@@ -430,7 +435,7 @@ export function PatternEditor({
<button
className="flex items-center gap-1.5 rounded-lg px-2.5 py-1 text-[12px] font-medium text-zinc-400 transition hover:bg-zinc-800 hover:text-zinc-200"
onClick={() =>
onChange({
emitChange({
...pattern,
agents: [
...pattern.agents,
@@ -471,7 +476,7 @@ export function PatternEditor({
<button
className="flex items-center gap-1 text-[12px] text-zinc-600 transition hover:text-red-400"
onClick={() =>
onChange({
emitChange({
...pattern,
agents: pattern.agents.filter((a) => a.id !== agent.id),
})
+647 -1
View File
@@ -15,6 +15,13 @@ export type OrchestrationMode =
export type PatternAvailability = 'available' | 'preview' | 'unavailable';
export type ReasoningEffort = 'low' | 'medium' | 'high' | 'xhigh';
export type PatternGraphNodeKind =
| 'user-input'
| 'user-output'
| 'agent'
| 'distributor'
| 'collector'
| 'orchestrator';
export const reasoningEffortOptions: ReadonlyArray<{ value: ReasoningEffort; label: string }> = [
{ value: 'low', label: 'Low' },
@@ -32,6 +39,30 @@ export interface PatternAgentDefinition {
reasoningEffort?: ReasoningEffort;
}
export interface PatternGraphPosition {
x: number;
y: number;
}
export interface PatternGraphNode {
id: string;
kind: PatternGraphNodeKind;
position: PatternGraphPosition;
agentId?: string;
order?: number;
}
export interface PatternGraphEdge {
id: string;
source: string;
target: string;
}
export interface PatternGraph {
nodes: PatternGraphNode[];
edges: PatternGraphEdge[];
}
export interface PatternDefinition {
id: string;
name: string;
@@ -43,6 +74,7 @@ export interface PatternDefinition {
maxIterations: number;
approvalPolicy?: ApprovalPolicy;
agents: PatternAgentDefinition[];
graph?: PatternGraph;
createdAt: string;
updatedAt: string;
}
@@ -61,12 +93,222 @@ const defaultModels = {
const reasoningEffortSet = new Set<ReasoningEffort>(reasoningEffortOptions.map((option) => option.value));
const SYSTEM_NODE_IDS = {
userInput: 'system-user-input',
userOutput: 'system-user-output',
distributor: 'system-distributor',
collector: 'system-collector',
orchestrator: 'system-orchestrator',
} as const;
export function isReasoningEffort(value: string | undefined): value is ReasoningEffort {
return value !== undefined && reasoningEffortSet.has(value as ReasoningEffort);
}
function agentNodeId(agentId: string): string {
return `agent-node-${agentId}`;
}
function edgeId(source: string, target: string): string {
return `edge-${source}-to-${target}`;
}
function createEdge(source: string, target: string): PatternGraphEdge {
return {
id: edgeId(source, target),
source,
target,
};
}
function createAgentNode(
agent: PatternAgentDefinition,
order: number,
position: PatternGraphPosition,
): PatternGraphNode {
return {
id: agentNodeId(agent.id),
kind: 'agent',
agentId: agent.id,
order,
position,
};
}
function spreadY(index: number, count: number, gap = 170): number {
return (index - (count - 1) / 2) * gap;
}
function createLinearGraph(agents: PatternAgentDefinition[]): PatternGraph {
const inputNode: PatternGraphNode = {
id: SYSTEM_NODE_IDS.userInput,
kind: 'user-input',
position: { x: 0, y: 0 },
};
const outputNode: PatternGraphNode = {
id: SYSTEM_NODE_IDS.userOutput,
kind: 'user-output',
position: { x: 220 * Math.max(agents.length + 1, 2), y: 0 },
};
const agentNodes = agents.map((agent, index) =>
createAgentNode(agent, index, { x: 220 * (index + 1), y: 0 }),
);
const edges: PatternGraphEdge[] = [];
const path = [inputNode.id, ...agentNodes.map((node) => node.id), outputNode.id];
for (let index = 0; index < path.length - 1; index += 1) {
edges.push(createEdge(path[index]!, path[index + 1]!));
}
return {
nodes: [inputNode, ...agentNodes, outputNode],
edges,
};
}
function createConcurrentGraph(agents: PatternAgentDefinition[]): PatternGraph {
const inputNode: PatternGraphNode = {
id: SYSTEM_NODE_IDS.userInput,
kind: 'user-input',
position: { x: 0, y: 0 },
};
const distributorNode: PatternGraphNode = {
id: SYSTEM_NODE_IDS.distributor,
kind: 'distributor',
position: { x: 190, y: 0 },
};
const collectorNode: PatternGraphNode = {
id: SYSTEM_NODE_IDS.collector,
kind: 'collector',
position: { x: 650, y: 0 },
};
const outputNode: PatternGraphNode = {
id: SYSTEM_NODE_IDS.userOutput,
kind: 'user-output',
position: { x: 860, y: 0 },
};
const agentNodes = agents.map((agent, index) =>
createAgentNode(agent, index, { x: 430, y: spreadY(index, Math.max(agents.length, 1), 170) }),
);
return {
nodes: [inputNode, distributorNode, ...agentNodes, collectorNode, outputNode],
edges: [
createEdge(inputNode.id, distributorNode.id),
...agentNodes.map((node) => createEdge(distributorNode.id, node.id)),
...agentNodes.map((node) => createEdge(node.id, collectorNode.id)),
createEdge(collectorNode.id, outputNode.id),
],
};
}
function createHandoffGraph(agents: PatternAgentDefinition[]): PatternGraph {
const inputNode: PatternGraphNode = {
id: SYSTEM_NODE_IDS.userInput,
kind: 'user-input',
position: { x: 0, y: 0 },
};
const outputNode: PatternGraphNode = {
id: SYSTEM_NODE_IDS.userOutput,
kind: 'user-output',
position: { x: 860, y: 0 },
};
const entryAgent = agents[0];
const entryNode = entryAgent
? createAgentNode(entryAgent, 0, { x: 220, y: 0 })
: undefined;
const specialistNodes = agents.slice(1).map((agent, index) =>
createAgentNode(agent, index + 1, { x: 540, y: spreadY(index, Math.max(agents.length - 1, 1), 220) }),
);
const nodes = [inputNode, ...(entryNode ? [entryNode] : []), ...specialistNodes, outputNode];
const edges: PatternGraphEdge[] = [];
if (entryNode) {
edges.push(createEdge(inputNode.id, entryNode.id));
edges.push(createEdge(entryNode.id, outputNode.id));
for (const specialistNode of specialistNodes) {
edges.push(createEdge(entryNode.id, specialistNode.id));
edges.push(createEdge(specialistNode.id, entryNode.id));
edges.push(createEdge(specialistNode.id, outputNode.id));
}
}
return { nodes, edges };
}
function createGroupChatGraph(agents: PatternAgentDefinition[]): PatternGraph {
const inputNode: PatternGraphNode = {
id: SYSTEM_NODE_IDS.userInput,
kind: 'user-input',
position: { x: 0, y: 0 },
};
const orchestratorNode: PatternGraphNode = {
id: SYSTEM_NODE_IDS.orchestrator,
kind: 'orchestrator',
position: { x: 250, y: 0 },
};
const outputNode: PatternGraphNode = {
id: SYSTEM_NODE_IDS.userOutput,
kind: 'user-output',
position: { x: 900, y: 0 },
};
const centerX = 560;
const centerY = 0;
const radiusX = 190;
const radiusY = 170;
const agentNodes = agents.map((agent, index) => {
const angle = agents.length <= 1 ? 0 : (Math.PI * 2 * index) / agents.length - Math.PI / 2;
return createAgentNode(agent, index, {
x: Math.round(centerX + Math.cos(angle) * radiusX),
y: Math.round(centerY + Math.sin(angle) * radiusY),
});
});
return {
nodes: [inputNode, orchestratorNode, ...agentNodes, outputNode],
edges: [
createEdge(inputNode.id, orchestratorNode.id),
...agentNodes.flatMap((node) => [
createEdge(orchestratorNode.id, node.id),
createEdge(node.id, orchestratorNode.id),
]),
createEdge(orchestratorNode.id, outputNode.id),
],
};
}
export function createDefaultPatternGraph(
pattern: Pick<PatternDefinition, 'mode' | 'agents'>,
): PatternGraph {
switch (pattern.mode) {
case 'single':
case 'sequential':
case 'magentic':
return createLinearGraph(pattern.agents);
case 'concurrent':
return createConcurrentGraph(pattern.agents);
case 'handoff':
return createHandoffGraph(pattern.agents);
case 'group-chat':
return createGroupChatGraph(pattern.agents);
default:
return createLinearGraph(pattern.agents);
}
}
export function resolvePatternGraph(pattern: PatternDefinition): PatternGraph {
return pattern.graph ?? createDefaultPatternGraph(pattern);
}
export function syncPatternGraph(pattern: PatternDefinition): PatternDefinition {
return {
...pattern,
graph: createDefaultPatternGraph(pattern),
};
}
export function createBuiltinPatterns(timestamp: string): PatternDefinition[] {
return [
const patterns: PatternDefinition[] = [
{
id: 'pattern-single-chat',
name: '1-on-1 Copilot Chat',
@@ -256,6 +498,408 @@ export function createBuiltinPatterns(timestamp: string): PatternDefinition[] {
updatedAt: timestamp,
},
];
return patterns.map((pattern) => syncPatternGraph(pattern));
}
function countByKind(graph: PatternGraph): Map<PatternGraphNodeKind, number> {
const counts = new Map<PatternGraphNodeKind, number>();
for (const node of graph.nodes) {
counts.set(node.kind, (counts.get(node.kind) ?? 0) + 1);
}
return counts;
}
function getNodeByKind(graph: PatternGraph, kind: PatternGraphNodeKind): PatternGraphNode | undefined {
return graph.nodes.find((node) => node.kind === kind);
}
function getAgentNodes(graph: PatternGraph): PatternGraphNode[] {
return graph.nodes.filter((node) => node.kind === 'agent');
}
function pushGraphIssue(issues: PatternValidationIssue[], message: string, field = 'graph'): void {
issues.push({ level: 'error', field, message });
}
function buildAdjacency(graph: PatternGraph): {
incoming: Map<string, PatternGraphEdge[]>;
outgoing: Map<string, PatternGraphEdge[]>;
} {
const incoming = new Map<string, PatternGraphEdge[]>();
const outgoing = new Map<string, PatternGraphEdge[]>();
for (const node of graph.nodes) {
incoming.set(node.id, []);
outgoing.set(node.id, []);
}
for (const edge of graph.edges) {
incoming.get(edge.target)?.push(edge);
outgoing.get(edge.source)?.push(edge);
}
return { incoming, outgoing };
}
function validateSystemNodeCounts(
graph: PatternGraph,
expectedKinds: readonly PatternGraphNodeKind[],
issues: PatternValidationIssue[],
): void {
const counts = countByKind(graph);
const expectedSet = new Set(expectedKinds);
for (const kind of expectedKinds) {
if ((counts.get(kind) ?? 0) !== 1) {
pushGraphIssue(issues, `Pattern graph must include exactly one "${kind}" node.`);
}
}
for (const [kind, count] of counts) {
if (kind === 'agent') {
continue;
}
if (!expectedSet.has(kind) && count > 0) {
pushGraphIssue(issues, `Pattern graph does not allow "${kind}" nodes in ${graphModeLabel(expectedKinds)} mode.`);
}
}
}
function graphModeLabel(expectedKinds: readonly PatternGraphNodeKind[]): string {
if (expectedKinds.includes('collector')) {
return 'concurrent';
}
if (expectedKinds.includes('orchestrator')) {
return 'group chat';
}
return 'this';
}
function validateLinearGraph(
pattern: PatternDefinition,
graph: PatternGraph,
issues: PatternValidationIssue[],
): void {
validateSystemNodeCounts(graph, ['user-input', 'user-output'], issues);
const inputNode = getNodeByKind(graph, 'user-input');
const outputNode = getNodeByKind(graph, 'user-output');
if (!inputNode || !outputNode) {
return;
}
const { incoming, outgoing } = buildAdjacency(graph);
const agentNodes = getAgentNodes(graph);
if (graph.edges.length !== pattern.agents.length + 1) {
pushGraphIssue(issues, 'Linear orchestration graphs must be a single path from user input through every agent to user output.');
}
if ((incoming.get(inputNode.id)?.length ?? 0) !== 0 || (outgoing.get(inputNode.id)?.length ?? 0) !== 1) {
pushGraphIssue(issues, 'User input must start exactly one path.');
}
if ((incoming.get(outputNode.id)?.length ?? 0) !== 1 || (outgoing.get(outputNode.id)?.length ?? 0) !== 0) {
pushGraphIssue(issues, 'User output must terminate exactly one path.');
}
for (const node of agentNodes) {
if ((incoming.get(node.id)?.length ?? 0) !== 1 || (outgoing.get(node.id)?.length ?? 0) !== 1) {
pushGraphIssue(issues, 'Each agent in a linear orchestration must have exactly one incoming and one outgoing edge.');
break;
}
}
const visited = new Set<string>();
let currentNodeId = inputNode.id;
while (!visited.has(currentNodeId)) {
visited.add(currentNodeId);
const nextEdge = outgoing.get(currentNodeId);
if (!nextEdge || nextEdge.length === 0) {
break;
}
if (nextEdge.length !== 1) {
pushGraphIssue(issues, 'Linear orchestration nodes may only branch to one next step.');
break;
}
currentNodeId = nextEdge[0]!.target;
if (currentNodeId === outputNode.id) {
visited.add(currentNodeId);
break;
}
}
const expectedVisited = new Set<string>([inputNode.id, outputNode.id, ...agentNodes.map((node) => node.id)]);
if (visited.size !== expectedVisited.size || [...expectedVisited].some((nodeId) => !visited.has(nodeId))) {
pushGraphIssue(issues, 'Linear orchestration graphs must visit every agent exactly once.');
}
}
function validateConcurrentGraph(
pattern: PatternDefinition,
graph: PatternGraph,
issues: PatternValidationIssue[],
): void {
validateSystemNodeCounts(graph, ['user-input', 'distributor', 'collector', 'user-output'], issues);
const inputNode = getNodeByKind(graph, 'user-input');
const distributorNode = getNodeByKind(graph, 'distributor');
const collectorNode = getNodeByKind(graph, 'collector');
const outputNode = getNodeByKind(graph, 'user-output');
if (!inputNode || !distributorNode || !collectorNode || !outputNode) {
return;
}
const { incoming, outgoing } = buildAdjacency(graph);
const agentNodes = getAgentNodes(graph);
if (graph.edges.length !== pattern.agents.length * 2 + 2) {
pushGraphIssue(issues, 'Concurrent orchestration graphs must fan out from the distributor and fan back into the collector.');
}
const distributorTargets = new Set((outgoing.get(distributorNode.id) ?? []).map((edge) => edge.target));
const collectorSources = new Set((incoming.get(collectorNode.id) ?? []).map((edge) => edge.source));
if ((incoming.get(inputNode.id)?.length ?? 0) !== 0 || (outgoing.get(inputNode.id)?.length ?? 0) !== 1) {
pushGraphIssue(issues, 'User input must connect only to the distributor.');
}
if ((incoming.get(distributorNode.id)?.length ?? 0) !== 1) {
pushGraphIssue(issues, 'Distributor must receive exactly one edge from user input.');
}
if ((outgoing.get(collectorNode.id)?.length ?? 0) !== 1 || (incoming.get(outputNode.id)?.length ?? 0) !== 1) {
pushGraphIssue(issues, 'Collector must forward exactly one edge to user output.');
}
for (const agentNode of agentNodes) {
if (!distributorTargets.has(agentNode.id)) {
pushGraphIssue(issues, `Distributor must connect to agent "${agentNode.agentId}".`);
}
if (!collectorSources.has(agentNode.id)) {
pushGraphIssue(issues, `Agent "${agentNode.agentId}" must connect to the collector.`);
}
}
}
function validateHandoffGraph(
graph: PatternGraph,
issues: PatternValidationIssue[],
): void {
validateSystemNodeCounts(graph, ['user-input', 'user-output'], issues);
const inputNode = getNodeByKind(graph, 'user-input');
const outputNode = getNodeByKind(graph, 'user-output');
if (!inputNode || !outputNode) {
return;
}
const { incoming, outgoing } = buildAdjacency(graph);
const agentNodes = getAgentNodes(graph);
const agentNodeIds = new Set(agentNodes.map((node) => node.id));
const entryEdges = outgoing.get(inputNode.id) ?? [];
const completionEdges = incoming.get(outputNode.id) ?? [];
if (entryEdges.length !== 1) {
pushGraphIssue(issues, 'Handoff graphs must connect user input to exactly one entry agent.');
return;
}
if (!agentNodeIds.has(entryEdges[0]!.target)) {
pushGraphIssue(issues, 'Handoff entry edges must target an agent node.');
}
if (completionEdges.length === 0) {
pushGraphIssue(issues, 'Handoff graphs must allow at least one agent to complete back to user output.');
}
let hasAgentToAgentRoute = false;
for (const edge of graph.edges) {
if (edge.source === inputNode.id) {
continue;
}
if (edge.target === outputNode.id) {
if (!agentNodeIds.has(edge.source)) {
pushGraphIssue(issues, 'Only agent nodes may complete to user output.');
}
continue;
}
if (!agentNodeIds.has(edge.source) || !agentNodeIds.has(edge.target)) {
pushGraphIssue(issues, 'Handoff routes may only connect agents to agents or agents to user output.');
continue;
}
if (edge.source === edge.target) {
pushGraphIssue(issues, 'Handoff routes cannot target the same agent node.');
}
hasAgentToAgentRoute = true;
}
if (!hasAgentToAgentRoute && agentNodes.length > 1) {
pushGraphIssue(issues, 'Handoff graphs must include at least one agent-to-agent handoff route.');
}
const reachable = new Set<string>();
const stack = [entryEdges[0]!.target];
while (stack.length > 0) {
const nodeId = stack.pop()!;
if (reachable.has(nodeId)) {
continue;
}
reachable.add(nodeId);
for (const edge of outgoing.get(nodeId) ?? []) {
if (agentNodeIds.has(edge.target) && !reachable.has(edge.target)) {
stack.push(edge.target);
}
}
}
for (const agentNode of agentNodes) {
if (!reachable.has(agentNode.id)) {
pushGraphIssue(issues, `Handoff entry agent must be able to reach "${agentNode.agentId}".`);
}
}
if ((incoming.get(inputNode.id)?.length ?? 0) !== 0 || (outgoing.get(outputNode.id)?.length ?? 0) !== 0) {
pushGraphIssue(issues, 'User input cannot have incoming edges and user output cannot have outgoing edges.');
}
}
function validateGroupChatGraph(
pattern: PatternDefinition,
graph: PatternGraph,
issues: PatternValidationIssue[],
): void {
validateSystemNodeCounts(graph, ['user-input', 'orchestrator', 'user-output'], issues);
const inputNode = getNodeByKind(graph, 'user-input');
const orchestratorNode = getNodeByKind(graph, 'orchestrator');
const outputNode = getNodeByKind(graph, 'user-output');
if (!inputNode || !orchestratorNode || !outputNode) {
return;
}
const { incoming, outgoing } = buildAdjacency(graph);
const agentNodes = getAgentNodes(graph);
const orchestratorTargets = new Set((outgoing.get(orchestratorNode.id) ?? []).map((edge) => edge.target));
const orchestratorSources = new Set((incoming.get(orchestratorNode.id) ?? []).map((edge) => edge.source));
if (graph.edges.length !== pattern.agents.length * 2 + 2) {
pushGraphIssue(issues, 'Group chat graphs must connect the orchestrator to every participant and then back to user output.');
}
if ((outgoing.get(inputNode.id) ?? []).some((edge) => edge.target !== orchestratorNode.id)) {
pushGraphIssue(issues, 'User input must only connect to the orchestrator.');
}
if (!(outgoing.get(orchestratorNode.id) ?? []).some((edge) => edge.target === outputNode.id)) {
pushGraphIssue(issues, 'Group chat orchestrator must connect to user output.');
}
for (const agentNode of agentNodes) {
if (!orchestratorTargets.has(agentNode.id)) {
pushGraphIssue(issues, `Orchestrator must connect to agent "${agentNode.agentId}".`);
}
if (!orchestratorSources.has(agentNode.id)) {
pushGraphIssue(issues, `Agent "${agentNode.agentId}" must connect back to the orchestrator.`);
}
}
}
function validatePatternGraph(
pattern: PatternDefinition,
graph: PatternGraph,
issues: PatternValidationIssue[],
): void {
if (graph.nodes.length === 0) {
pushGraphIssue(issues, 'Pattern graph must include nodes.');
return;
}
const nodeIds = new Set<string>();
const edgeIds = new Set<string>();
const agentIds = new Set(pattern.agents.map((agent) => agent.id));
const seenAgentIds = new Set<string>();
const seenAgentOrders = new Set<number>();
const nodesById = new Map<string, PatternGraphNode>();
for (const node of graph.nodes) {
if (nodeIds.has(node.id)) {
pushGraphIssue(issues, `Pattern graph contains duplicate node "${node.id}".`);
}
nodeIds.add(node.id);
nodesById.set(node.id, node);
if (node.kind === 'agent') {
if (!node.agentId || !agentIds.has(node.agentId)) {
pushGraphIssue(issues, `Agent node "${node.id}" must reference a known agent.`);
}
if (node.agentId) {
if (seenAgentIds.has(node.agentId)) {
pushGraphIssue(issues, `Pattern graph contains multiple nodes for agent "${node.agentId}".`);
}
seenAgentIds.add(node.agentId);
}
if (typeof node.order !== 'number' || !Number.isInteger(node.order)) {
pushGraphIssue(issues, `Agent node "${node.id}" must define an integer order.`);
} else if (seenAgentOrders.has(node.order)) {
pushGraphIssue(issues, `Pattern graph contains duplicate agent order "${node.order}".`);
} else {
seenAgentOrders.add(node.order);
}
} else if (node.agentId) {
pushGraphIssue(issues, `System node "${node.id}" cannot reference an agent.`);
}
}
for (const agent of pattern.agents) {
if (!seenAgentIds.has(agent.id)) {
pushGraphIssue(issues, `Pattern graph is missing node metadata for agent "${agent.id}".`);
}
}
for (const edge of graph.edges) {
if (edgeIds.has(edge.id)) {
pushGraphIssue(issues, `Pattern graph contains duplicate edge "${edge.id}".`);
}
edgeIds.add(edge.id);
if (!nodesById.has(edge.source) || !nodesById.has(edge.target)) {
pushGraphIssue(issues, `Pattern graph edge "${edge.id}" must connect known nodes.`);
}
}
switch (pattern.mode) {
case 'single':
case 'sequential':
case 'magentic':
validateLinearGraph(pattern, graph, issues);
break;
case 'concurrent':
validateConcurrentGraph(pattern, graph, issues);
break;
case 'handoff':
validateHandoffGraph(graph, issues);
break;
case 'group-chat':
validateGroupChatGraph(pattern, graph, issues);
break;
default:
break;
}
}
export function validatePatternDefinition(
@@ -324,6 +968,8 @@ export function validatePatternDefinition(
}
}
validatePatternGraph(pattern, resolvePatternGraph(pattern), issues);
for (const message of validateApprovalPolicy(
normalizeApprovalPolicy(pattern.approvalPolicy),
pattern.agents.map((agent) => agent.id),