fix: only show bubble to textContent

web/shared/editor/hooks/use-text-menu-states.ts

@@ -1,24 +1,16 @@
 import * as React from "react"
 import { Editor } from "@tiptap/react"
 import { ShouldShowProps } from "../types"
-import { isCustomNodeSelected, isTextSelected } from "../lib/utils"
+import { isTextSelected } from "../lib/utils"
 
 export const useTextmenuStates = (editor: Editor) => {
   const shouldShow = React.useCallback(
-    ({ view, from }: ShouldShowProps) => {
+    ({ view }: ShouldShowProps) => {
       if (!view) {
         return false
       }
 
-      const domAtPos = view.domAtPos(from || 0).node as HTMLElement
+      return isTextSelected(editor)
-      const nodeDOM = view.nodeDOM(from || 0) as HTMLElement
-      const node = nodeDOM || domAtPos
-
-      if (isCustomNodeSelected(editor, node)) {
-        return false
-      }
-
-      return isTextSelected({ editor })
     },
     [editor],
   )

web/shared/editor/lib/utils/isTextSelected.ts

@@ -1,26 +1,22 @@
-import { isTextSelection } from "@tiptap/core"
 import { Editor } from "@tiptap/react"
 
-export const isTextSelected = ({ editor }: { editor: Editor }) => {
+export const isTextSelected = (editor: Editor) => {
-  const {
+  if (!editor.isEditable) {
-    state: {
-      doc,
-      selection,
-      selection: { empty, from, to },
-    },
-  } = editor
-
-  // Sometime check for `empty` is not enough.
-  // Doubleclick an empty paragraph returns a node size of 2.
-  // So we check also for an empty text size.
-  const isEmptyTextBlock =
-    !doc.textBetween(from, to).length && isTextSelection(selection)
-
-  if (empty || isEmptyTextBlock || !editor.isEditable) {
     return false
   }
 
-  return true
+  const { selection } = editor.state
+  const { empty, from, to } = selection
+
+  // Don't check for selection type since we only care about text content
+  // Handle empty selections, including empty paragraphs
+  if (empty) {
+    return false
+  }
+
+  // Get text content and trim to handle whitespace-only selections
+  const text = editor.state.doc.textBetween(from, to, " ").trim()
+  return text.length > 0
 }
 
 export default isTextSelected