starred/WireMock.Net
1
0
Fork 0
mirror of https://github.com/wiremock/WireMock.Net.git synced 2026-05-31 04:00:42 +02:00
Code Issues 32 Packages Projects Releases 10 Wiki Activity

Improve matcher for BodyType.MultiPart #208

New Issue
Closed
opened 2025-12-29 08:23:57 +01:00 by adam · 1 comment
adam commented 2025-12-29 08:23:57 +01:00
Owner
Copy Link
Copy Source

Originally created by @davidshen84 on GitHub (Sep 6, 2019).

ref: https://github.com/WireMock-Net/WireMock.Net/blob/2f406029c983cfefab920a7f5b10f29b9ad337cc/src/WireMock.Net/Matchers/Request/RequestMessageBodyMatcher.cs#L130

Based on the above code, a body which is detected as BodyType.MultiPart will not be tested by an IStringMatcher.

Because all HTTP bodies are plain text, I think it is quite safe to use an IStringMatcher to test the content of a MultiPart body.

For example, a MultiPart body that looks like below after encoded.

--6e8b918a-4ec9-46f1-b908-8c967c342670\r\nContent-Type: application/octet-stream\r\nContent-Disposition: attachment; name=File\r\n\r\ntest file content\r\n--6e8b918a-4ec9-46f1-b908-8c967c342670\r\nContent-Type: application/x-www-form-urlencoded\r\nContent-Disposition: form-data; name=Parameters\r\n\r\nlibraryName=lib&divisionId=div&user=user&planNumber=plan&functionalRole=AdminDepartment&documentCategory=doc\r\n--6e8b918a-4ec9-46f1-b908-8c967c342670--\r\n

One can use a string matcher to test if a string "test file content" is presented.

Originally created by @davidshen84 on GitHub (Sep 6, 2019). ref: https://github.com/WireMock-Net/WireMock.Net/blob/2f406029c983cfefab920a7f5b10f29b9ad337cc/src/WireMock.Net/Matchers/Request/RequestMessageBodyMatcher.cs#L130 Based on the above code, a body which is detected as BodyType.MultiPart will not be tested by an `IStringMatcher`. Because all HTTP bodies are plain text, I think it is quite safe to use an `IStringMatcher` to test the content of a *MultiPart* body. For example, a *MultiPart* body that looks like below after encoded. ``` --6e8b918a-4ec9-46f1-b908-8c967c342670\r\nContent-Type: application/octet-stream\r\nContent-Disposition: attachment; name=File\r\n\r\ntest file content\r\n--6e8b918a-4ec9-46f1-b908-8c967c342670\r\nContent-Type: application/x-www-form-urlencoded\r\nContent-Disposition: form-data; name=Parameters\r\n\r\nlibraryName=lib&divisionId=div&user=user&planNumber=plan&functionalRole=AdminDepartment&documentCategory=doc\r\n--6e8b918a-4ec9-46f1-b908-8c967c342670--\r\n ``` One can use a string matcher to test if a string "test file content" is presented.
adam added the invalidquestion labels 2025-12-29 08:23:57 +01:00
adam closed this issue 2025-12-29 08:23:57 +01:00
adam commented 2025-12-29 08:23:58 +01:00
Author
Owner
Copy Link
Copy Source

@davidshen84 commented on GitHub (Sep 6, 2019):

Not working if there are binary data :(

@davidshen84 commented on GitHub (Sep 6, 2019): Not working if there are binary data :(
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
bug
doc
doc
duplicate
feature
feature
invalid
pull-request
Mirrored from GitHub Pull Request
 question
wontfix
No Label invalid question
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/WireMock.Net#208
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?