[PR #1370] [MERGED] Support Testcontainers 4.8.0 #1364

Closed
opened 2025-12-29 09:19:26 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/wiremock/WireMock.Net/pull/1370
Author: @MD-V
Created: 10/21/2025
Status: Merged
Merged: 10/22/2025
Merged by: @StefH

Base: masterHead: master


📝 Commits (1)

  • 4291e84 Support Testcontainers 4.8.0

📊 Changes

2 files changed (+5 additions, -3 deletions)

View changed files

📝 src/WireMock.Net.Testcontainers/WireMock.Net.Testcontainers.csproj (+1 -1)
📝 src/WireMock.Net.Testcontainers/WireMockContainer.cs (+4 -2)

📄 Description

Make WireMock.Net.Testcontainers compatible with Testcontainers 4.8.0.
Testcontainers 4.8.0 is not binary compatible with 4.7.0.
Ctor of WireMockConfiguration breaks with a MissingMethodException:

System.MissingMethodException : Method not found: 'Void DotNet.Testcontainers.Configurations.ContainerConfiguration..ctor(DotNet.Testcontainers.Images.IImage, System.Func`2<Docker.DotNet.Models.ImageInspectResponse,Boolean>, System.String, System.String, System.String, System.String, System.Collections.Generic.IEnumerable`1<System.String>, DotNet.Testcontainers.Configurations.ComposableEnumerable`1<System.String>, System.Collections.Generic.IReadOnlyDictionary`2<System.String,System.String>, System.Collections.Generic.IReadOnlyDictionary`2<System.String,System.String>, System.Collections.Generic.IReadOnlyDictionary`2<System.String,System.String>, System.Collections.Generic.IEnumerable`1<DotNet.Testcontainers.Configurations.IResourceMapping>, System.Collections.Generic.IEnumerable`1<DotNet.Testcontainers.Containers.IContainer>, System.Collections.Generic.IEnumerable`1<DotNet.Testcontainers.Configurations.IMount>, System.Collections.Generic.IEnumerable`1<DotNet.Testcontainers.Networks.INetwork>, System.Collections.Generic.IEnumerable`1<System.String>, System.Collections.Generic.IEnumerable`1<System.String>, DotNet.Testcontainers.Configurations.IOutputConsumer, System.Collections.Generic.IEnumerable`1<DotNet.Testcontainers.Configurations.WaitStrategy>, System.Func`3<DotNet.Testcontainers.Containers.IContainer,System.Threading.CancellationToken,System.Threading.Tasks.Task>, System.Nullable`1<Boolean>, System.Nullable`1<Boolean>)'.

References

https://github.com/testcontainers/testcontainers-dotnet/commit/3b4f41851222d5dabe1058bb997025026a94e6aa#diff-42f9d6914c9475812b1c918ce9604fc2db0344b779868718675ea7850510b578

https://github.com/testcontainers/testcontainers-dotnet/commit/c27a94ba320cad698f7bd05b2f93856c0aebb088#diff-cfb5e3427ad9917120dc63419d9b834390f507ddfeb00dceb2fc1bd6f8d503a5

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/wiremock/WireMock.Net/pull/1370 **Author:** [@MD-V](https://github.com/MD-V) **Created:** 10/21/2025 **Status:** ✅ Merged **Merged:** 10/22/2025 **Merged by:** [@StefH](https://github.com/StefH) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`4291e84`](https://github.com/wiremock/WireMock.Net/commit/4291e846e8ffd5a36fbbe30053b01c280a1ad027) Support Testcontainers 4.8.0 ### 📊 Changes **2 files changed** (+5 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/WireMock.Net.Testcontainers/WireMock.Net.Testcontainers.csproj` (+1 -1) 📝 `src/WireMock.Net.Testcontainers/WireMockContainer.cs` (+4 -2) </details> ### 📄 Description Make WireMock.Net.Testcontainers compatible with Testcontainers 4.8.0. Testcontainers 4.8.0 is not binary compatible with 4.7.0. Ctor of WireMockConfiguration breaks with a MissingMethodException: ``` System.MissingMethodException : Method not found: 'Void DotNet.Testcontainers.Configurations.ContainerConfiguration..ctor(DotNet.Testcontainers.Images.IImage, System.Func`2<Docker.DotNet.Models.ImageInspectResponse,Boolean>, System.String, System.String, System.String, System.String, System.Collections.Generic.IEnumerable`1<System.String>, DotNet.Testcontainers.Configurations.ComposableEnumerable`1<System.String>, System.Collections.Generic.IReadOnlyDictionary`2<System.String,System.String>, System.Collections.Generic.IReadOnlyDictionary`2<System.String,System.String>, System.Collections.Generic.IReadOnlyDictionary`2<System.String,System.String>, System.Collections.Generic.IEnumerable`1<DotNet.Testcontainers.Configurations.IResourceMapping>, System.Collections.Generic.IEnumerable`1<DotNet.Testcontainers.Containers.IContainer>, System.Collections.Generic.IEnumerable`1<DotNet.Testcontainers.Configurations.IMount>, System.Collections.Generic.IEnumerable`1<DotNet.Testcontainers.Networks.INetwork>, System.Collections.Generic.IEnumerable`1<System.String>, System.Collections.Generic.IEnumerable`1<System.String>, DotNet.Testcontainers.Configurations.IOutputConsumer, System.Collections.Generic.IEnumerable`1<DotNet.Testcontainers.Configurations.WaitStrategy>, System.Func`3<DotNet.Testcontainers.Containers.IContainer,System.Threading.CancellationToken,System.Threading.Tasks.Task>, System.Nullable`1<Boolean>, System.Nullable`1<Boolean>)'. ``` ## References [https://github.com/testcontainers/testcontainers-dotnet/commit/3b4f41851222d5dabe1058bb997025026a94e6aa#diff-42f9d6914c9475812b1c918ce9604fc2db0344b779868718675ea7850510b578](https://github.com/testcontainers/testcontainers-dotnet/commit/3b4f41851222d5dabe1058bb997025026a94e6aa#diff-42f9d6914c9475812b1c918ce9604fc2db0344b779868718675ea7850510b578) [https://github.com/testcontainers/testcontainers-dotnet/commit/c27a94ba320cad698f7bd05b2f93856c0aebb088#diff-cfb5e3427ad9917120dc63419d9b834390f507ddfeb00dceb2fc1bd6f8d503a5](https://github.com/testcontainers/testcontainers-dotnet/commit/c27a94ba320cad698f7bd05b2f93856c0aebb088#diff-cfb5e3427ad9917120dc63419d9b834390f507ddfeb00dceb2fc1bd6f8d503a5) ## Submitter checklist - [ ] Recommended: Join [WireMock Slack](https://slack.wiremock.org/) to get any help in `#help-contributing` or a project-specific channel like `#wiremock-java` - [x] The PR request is well described and justified, including the body and the references - [x] The PR title represents the desired changelog entry - [x] The repository's code style is followed (see the contributing guide) - [x] Test coverage that demonstrates that the change works as expected - [ ] For new features, there's necessary documentation in this pull request or in a subsequent PR to [wiremock.org](https://github.com/wiremock/wiremock.org) <!-- Put an `x` into the [ ] to show you have filled the information. The template comes from https://github.com/wiremock/.github/blob/main/.github/pull_request_template.md You can override it by creating .github/pull_request_template.md in your own repository --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 09:19:26 +01:00
adam closed this issue 2025-12-29 09:19:26 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/WireMock.Net#1364