starred/WireMock.Net
1
0
Fork 0
mirror of https://github.com/wiremock/WireMock.Net.git synced 2026-01-11 21:10:32 +01:00
Code Issues 32 Packages Projects Releases 10 Wiki Activity

[PR #1316] [MERGED] Use default resource cleaning behavior in test #1335

New Issue
Closed
opened 2025-12-29 09:19:20 +01:00 by adam · 0 comments
adam commented 2025-12-29 09:19:20 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/wiremock/WireMock.Net/pull/1316
Author: @scrocquesel
Created: 6/11/2025
Status: ✅ Merged
Merged: 6/12/2025
Merged by: @StefH

Base: master ← Head: test/cleanup

📝 Commits (1)

  • 8c20e55 Use default resource cleaning behavior in test

📊 Changes

3 files changed (+2 additions, -25 deletions)

View changed files

📝 examples/WireMock.Net.TestcontainersExample/Program.cs (+2 -8)
📝 test/WireMock.Net.Tests/Testcontainers/TestcontainersTests.Grpc.cs (+0 -8)
📝 test/WireMock.Net.Tests/Testcontainers/TestcontainersTests.cs (+0 -9)

📄 Description

Remove unecessary call to AutoRemove(), CleanUp() to not mislead users of WireMock.Net.

References

  • TODO

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/wiremock/WireMock.Net/pull/1316 **Author:** [@scrocquesel](https://github.com/scrocquesel) **Created:** 6/11/2025 **Status:** ✅ Merged **Merged:** 6/12/2025 **Merged by:** [@StefH](https://github.com/StefH) **Base:** `master` ← **Head:** `test/cleanup` --- ### 📝 Commits (1) - [`8c20e55`](https://github.com/wiremock/WireMock.Net/commit/8c20e55ed2524acf50c0ecbd35efa79086d5703b) Use default resource cleaning behavior in test ### 📊 Changes **3 files changed** (+2 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `examples/WireMock.Net.TestcontainersExample/Program.cs` (+2 -8) 📝 `test/WireMock.Net.Tests/Testcontainers/TestcontainersTests.Grpc.cs` (+0 -8) 📝 `test/WireMock.Net.Tests/Testcontainers/TestcontainersTests.cs` (+0 -9) </details> ### 📄 Description Remove unecessary call to `AutoRemove()`, `CleanUp()` to not mislead users of WireMock.Net. ## References - TODO <!-- References to relevant GitHub issues and pull requests, esp. upstream and downstream changes --> ## Submitter checklist - [ ] Recommended: Join [WireMock Slack](https://slack.wiremock.org/) to get any help in `#help-contributing` or a project-specific channel like `#wiremock-java` - [ ] The PR request is well described and justified, including the body and the references - [ ] The PR title represents the desired changelog entry - [ ] The repository's code style is followed (see the contributing guide) - [ ] Test coverage that demonstrates that the change works as expected - [ ] For new features, there's necessary documentation in this pull request or in a subsequent PR to [wiremock.org](https://github.com/wiremock/wiremock.org) <!-- Put an `x` into the [ ] to show you have filled the information. The template comes from https://github.com/wiremock/.github/blob/main/.github/pull_request_template.md You can override it by creating .github/pull_request_template.md in your own repository --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 09:19:20 +01:00
adam closed this issue 2025-12-29 09:19:20 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
bug
doc
doc
duplicate
feature
feature
invalid
pull-request
Mirrored from GitHub Pull Request
 question
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/WireMock.Net#1335
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?