[PR #1311] [MERGED] Bump Testcontainers version to 4.5.0 #1332

Closed
opened 2025-12-29 09:19:20 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/wiremock/WireMock.Net/pull/1311
Author: @scrocquesel
Created: 6/9/2025
Status: Merged
Merged: 6/10/2025
Merged by: @StefH

Base: masterHead: fix/testcontainers


📝 Commits (3)

  • 8251f48 Bump Testcontainers version to 4.5.0
  • 0fd1d9e Bump System.Net.Http.Json version to 8.0.1
  • 9ec12dc Do not dispose null container

📊 Changes

3 files changed (+8 additions, -4 deletions)

View changed files

📝 src/WireMock.Net.Testcontainers/WireMock.Net.Testcontainers.csproj (+2 -2)
📝 test/WireMock.Net.Tests/Testcontainers/TestcontainersTests.cs (+5 -1)
📝 test/WireMock.Net.Tests/WireMock.Net.Tests.csproj (+1 -1)

📄 Description

The Testcontainers dependency Docker.DotNet was bumped to 3.128.1 and is not binary compatible with previous version. When a user has a direct dependency on Testcontainers 4.5.0, WireMock.Net.Testcontainers fails with :

System.MissingMethodException : Method not found: 'Docker.DotNet.DockerClient Docker.DotNet.DockerClientConfiguration.CreateClient(System.Version)'

References

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/wiremock/WireMock.Net/pull/1311 **Author:** [@scrocquesel](https://github.com/scrocquesel) **Created:** 6/9/2025 **Status:** ✅ Merged **Merged:** 6/10/2025 **Merged by:** [@StefH](https://github.com/StefH) **Base:** `master` ← **Head:** `fix/testcontainers` --- ### 📝 Commits (3) - [`8251f48`](https://github.com/wiremock/WireMock.Net/commit/8251f48361676f86534e63d1257c341a35d1a35d) Bump Testcontainers version to 4.5.0 - [`0fd1d9e`](https://github.com/wiremock/WireMock.Net/commit/0fd1d9e45c6f94fe69a322e55712f31aaff939b4) Bump System.Net.Http.Json version to 8.0.1 - [`9ec12dc`](https://github.com/wiremock/WireMock.Net/commit/9ec12dc14ff6513e5321d63703d6397ba9d4331a) Do not dispose null container ### 📊 Changes **3 files changed** (+8 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/WireMock.Net.Testcontainers/WireMock.Net.Testcontainers.csproj` (+2 -2) 📝 `test/WireMock.Net.Tests/Testcontainers/TestcontainersTests.cs` (+5 -1) 📝 `test/WireMock.Net.Tests/WireMock.Net.Tests.csproj` (+1 -1) </details> ### 📄 Description The Testcontainers dependency Docker.DotNet was bumped to 3.128.1 and is not binary compatible with previous version. When a user has a direct dependency on Testcontainers 4.5.0, WireMock.Net.Testcontainers fails with : ```plain System.MissingMethodException : Method not found: 'Docker.DotNet.DockerClient Docker.DotNet.DockerClientConfiguration.CreateClient(System.Version)' ``` <!-- Please describe your pull request here. --> ## References - #1310 ## Submitter checklist - [ ] Recommended: Join [WireMock Slack](https://slack.wiremock.org/) to get any help in `#help-contributing` or a project-specific channel like `#wiremock-java` - [x] The PR request is well described and justified, including the body and the references - [x] The PR title represents the desired changelog entry - [ ] The repository's code style is followed (see the contributing guide) - [ ] Test coverage that demonstrates that the change works as expected - [ ] For new features, there's necessary documentation in this pull request or in a subsequent PR to [wiremock.org](https://github.com/wiremock/wiremock.org) <!-- Put an `x` into the [ ] to show you have filled the information. The template comes from https://github.com/wiremock/.github/blob/main/.github/pull_request_template.md You can override it by creating .github/pull_request_template.md in your own repository --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 09:19:20 +01:00
adam closed this issue 2025-12-29 09:19:20 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/WireMock.Net#1332