starred/WireMock.Net
1
0
Fork 0
mirror of https://github.com/wiremock/WireMock.Net.git synced 2026-01-11 21:10:32 +01:00
Code Issues 32 Packages Projects Releases 10 Wiki Activity

[PR #1301] [MERGED] Fix errors when converting response bodies with top-level JSON arrays to C# code #1326

New Issue
Closed
opened 2025-12-29 09:19:19 +01:00 by adam · 0 comments
adam commented 2025-12-29 09:19:19 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/wiremock/WireMock.Net/pull/1301
Author: @asaf92
Created: 5/21/2025
Status: ✅ Merged
Merged: 5/22/2025
Merged by: @StefH

Base: master ← Head: fix/json-array-parsing

📝 Commits (1)

  • ae6a76f fix errors when converting json arrays to C# code

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 src/WireMock.Net/Util/CSharpFormatter.cs (+2 -2)

📄 Description

When trying to convert static mapping to C# code, I ran into an exception when the body is a top-level array rather than a pure string or a (non-array) JSON object.

The problem is that this code doesn't distinguish between arrays and objects, and assumes that every non-null that isn't a string is an object:

case BodyType.Json:
    if (bodyData.BodyAsJson is string bodyStringValue)
    {
        sb.AppendLine($"        .WithBody({ToCSharpStringLiteral(bodyStringValue)})");
    }
    else if (bodyData.BodyAsJson is { } jsonBody)
    {
        var anonymousObjectDefinition = ConvertToAnonymousObjectDefinition(jsonBody);
        sb.AppendLine($"        .WithBodyAsJson({anonymousObjectDefinition})");
    }
                                                                                      
    break;

My solution is to load a JToken instead of a JObject in ConvertToAnonymousObjectDefinition, which seems like the original intention given that ConvertJsonToAnonymousObjectDefinition (which is defined in an internal class) expects a JToken and isn't called anywhere else in the code.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/wiremock/WireMock.Net/pull/1301 **Author:** [@asaf92](https://github.com/asaf92) **Created:** 5/21/2025 **Status:** ✅ Merged **Merged:** 5/22/2025 **Merged by:** [@StefH](https://github.com/StefH) **Base:** `master` ← **Head:** `fix/json-array-parsing` --- ### 📝 Commits (1) - [`ae6a76f`](https://github.com/wiremock/WireMock.Net/commit/ae6a76f4c2570fcc289599a7a3362e60eb9910cf) fix errors when converting json arrays to C# code ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/WireMock.Net/Util/CSharpFormatter.cs` (+2 -2) </details> ### 📄 Description When trying to convert static mapping to C# code, I ran into an exception when the body is a top-level array rather than a pure string or a (non-array) JSON object. The problem is that this code doesn't distinguish between arrays and objects, and assumes that every non-null that isn't a string is an object: ```cs case BodyType.Json: if (bodyData.BodyAsJson is string bodyStringValue) { sb.AppendLine($" .WithBody({ToCSharpStringLiteral(bodyStringValue)})"); } else if (bodyData.BodyAsJson is { } jsonBody) { var anonymousObjectDefinition = ConvertToAnonymousObjectDefinition(jsonBody); sb.AppendLine($" .WithBodyAsJson({anonymousObjectDefinition})"); } break; ``` My solution is to load a JToken instead of a JObject in ConvertToAnonymousObjectDefinition, which seems like the original intention given that ConvertJsonToAnonymousObjectDefinition (which is defined in an internal class) expects a JToken and isn't called anywhere else in the code. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 09:19:19 +01:00
adam closed this issue 2025-12-29 09:19:19 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
bug
doc
doc
duplicate
feature
feature
invalid
pull-request
Mirrored from GitHub Pull Request
 question
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/WireMock.Net#1326
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?