[PR #805] [CLOSED] Matt webhooks #1095

Closed
opened 2025-12-29 08:34:39 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/wiremock/WireMock.Net/pull/805
Author: @mattisking
Created: 9/7/2022
Status: Closed

Base: stef-webhooksHead: matt-webhooks


📝 Commits (2)

  • a3e235f Change nuget to package reference for WireMock.Net.Console.Net472.Classic, move the new FireAndForget into the main mapping, out of individual webhook mappings making it all or nothing, update tests, change Middleware to await or not the firing of all webhooks. Update models as needed.
  • 6edf201 little cleaner skipping the await, fix example

📊 Changes

19 files changed (+121 additions, -69 deletions)

View changed files

📝 examples/WireMock.Net.Console.Net452.Classic/MainApp.cs (+35 -0)
📝 examples/WireMock.Net.Console.Net472.Classic/WireMock.Net.Console.Net472.Classic.csproj (+10 -9)
📝 examples/WireMock.Net.Console.Net472.Classic/packages.config (+0 -3)
📝 src/WireMock.Net.Abstractions/Admin/Mappings/MappingModel.cs (+5 -0)
📝 src/WireMock.Net.Abstractions/Admin/Mappings/WebhookRequestModel.cs (+0 -5)
📝 src/WireMock.Net.Abstractions/Models/IWebhookRequest.cs (+0 -5)
📝 src/WireMock.Net/Http/WebhookSender.cs (+0 -25)
📝 src/WireMock.Net/IMapping.cs (+5 -0)
📝 src/WireMock.Net/Mapping.cs (+6 -0)
📝 src/WireMock.Net/Models/WebhookRequest.cs (+0 -3)
📝 src/WireMock.Net/Owin/WireMockMiddleware.cs (+28 -1)
📝 src/WireMock.Net/Proxy/ProxyHelper.cs (+1 -0)
📝 src/WireMock.Net/Serialization/MappingConverter.cs (+1 -0)
📝 src/WireMock.Net/Serialization/WebhookMapper.cs (+0 -2)
📝 src/WireMock.Net/Server/IRespondWithAProvider.cs (+7 -0)
📝 src/WireMock.Net/Server/RespondWithAProvider.cs (+10 -1)
📝 test/WireMock.Net.Tests/Owin/WireMockMiddlewareTests.cs (+2 -2)
📝 test/WireMock.Net.Tests/Serialization/MappingConverterTests.cs (+11 -9)
📝 test/WireMock.Net.Tests/Serialization/WebhookMapperTests.cs (+0 -4)

📄 Description

Little update to get rid of that warning and fix a bug in the example


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/wiremock/WireMock.Net/pull/805 **Author:** [@mattisking](https://github.com/mattisking) **Created:** 9/7/2022 **Status:** ❌ Closed **Base:** `stef-webhooks` ← **Head:** `matt-webhooks` --- ### 📝 Commits (2) - [`a3e235f`](https://github.com/wiremock/WireMock.Net/commit/a3e235fd02a896e7b196c419ea3841bbf3fb285b) Change nuget to package reference for WireMock.Net.Console.Net472.Classic, move the new FireAndForget into the main mapping, out of individual webhook mappings making it all or nothing, update tests, change Middleware to await or not the firing of all webhooks. Update models as needed. - [`6edf201`](https://github.com/wiremock/WireMock.Net/commit/6edf201d65269a85a058b58c395aece727cc1bda) little cleaner skipping the await, fix example ### 📊 Changes **19 files changed** (+121 additions, -69 deletions) <details> <summary>View changed files</summary> 📝 `examples/WireMock.Net.Console.Net452.Classic/MainApp.cs` (+35 -0) 📝 `examples/WireMock.Net.Console.Net472.Classic/WireMock.Net.Console.Net472.Classic.csproj` (+10 -9) 📝 `examples/WireMock.Net.Console.Net472.Classic/packages.config` (+0 -3) 📝 `src/WireMock.Net.Abstractions/Admin/Mappings/MappingModel.cs` (+5 -0) 📝 `src/WireMock.Net.Abstractions/Admin/Mappings/WebhookRequestModel.cs` (+0 -5) 📝 `src/WireMock.Net.Abstractions/Models/IWebhookRequest.cs` (+0 -5) 📝 `src/WireMock.Net/Http/WebhookSender.cs` (+0 -25) 📝 `src/WireMock.Net/IMapping.cs` (+5 -0) 📝 `src/WireMock.Net/Mapping.cs` (+6 -0) 📝 `src/WireMock.Net/Models/WebhookRequest.cs` (+0 -3) 📝 `src/WireMock.Net/Owin/WireMockMiddleware.cs` (+28 -1) 📝 `src/WireMock.Net/Proxy/ProxyHelper.cs` (+1 -0) 📝 `src/WireMock.Net/Serialization/MappingConverter.cs` (+1 -0) 📝 `src/WireMock.Net/Serialization/WebhookMapper.cs` (+0 -2) 📝 `src/WireMock.Net/Server/IRespondWithAProvider.cs` (+7 -0) 📝 `src/WireMock.Net/Server/RespondWithAProvider.cs` (+10 -1) 📝 `test/WireMock.Net.Tests/Owin/WireMockMiddlewareTests.cs` (+2 -2) 📝 `test/WireMock.Net.Tests/Serialization/MappingConverterTests.cs` (+11 -9) 📝 `test/WireMock.Net.Tests/Serialization/WebhookMapperTests.cs` (+0 -4) </details> ### 📄 Description Little update to get rid of that warning and fix a bug in the example --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 08:34:39 +01:00
adam closed this issue 2025-12-29 08:34:39 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/WireMock.Net#1095