Update comment in JsonPathMatcher.cs

This commit is contained in:
Stef Heyenrath
2023-08-17 17:22:05 +02:00
parent 8adf34fb56
commit f0139eb837
+2 -5
View File
@@ -123,11 +123,8 @@ public class JsonPathMatcher : IStringMatcher, IObjectMatcher
{ {
var array = ConvertJTokenToJArrayIfNeeded(jToken); var array = ConvertJTokenToJArrayIfNeeded(jToken);
// The SelectToken method can accept a string path to a child token ( i.e. "Manufacturers[0].Products[0].Price"). In that case it will return a JValue (some type) which does not implement the IEnumerable interface. // The SelectToken method can accept a string path to a child token ( i.e. "Manufacturers[0].Products[0].Price").
// Using ?.Any() == true relays that we use a JSONPath queries and the SelectToken will return a JObject ( implements the IEnumerable interface). // In that case it will return a JValue (some type) which does not implement the IEnumerable interface.
// So the current code works only when the JSONPath is expression and not when we pass a valid string path to child.
// My suggestion is to roll back to != null to cover the both cases.
return MatchScores.ToScore(_patterns.Select(pattern => array.SelectToken(pattern.GetPattern()) != null).ToArray(), MatchOperator); return MatchScores.ToScore(_patterns.Select(pattern => array.SelectToken(pattern.GetPattern()) != null).ToArray(), MatchOperator);
} }