From 8ba243ddcd94b81efb7cddb953a84cfef90eee06 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Crocquesel?=
<88554524+scrocquesel@users.noreply.github.com>
Date: Tue, 10 Jun 2025 22:23:56 +0200
Subject: [PATCH] Bump Testcontainers version to 4.5.0 (#1311)
* Bump Testcontainers version to 4.5.0
The Testcontainers dependency Docker.DotNet was bumped to 3.128.1 and is not binary compatible with previous version.
When a user has a direct dependency on Testcontainers 4.5.0, WireMock.Net.Testcontainers fails with :
System.MissingMethodException : Method not found: 'Docker.DotNet.DockerClient Docker.DotNet.DockerClientConfiguration.CreateClient(System.Version)'
* Bump System.Net.Http.Json version to 8.0.1
Minimum required version for Testcontainers 4.5.0
* Do not dispose null container
---
.../WireMock.Net.Testcontainers.csproj | 4 ++--
.../Testcontainers/TestcontainersTests.cs | 6 +++++-
test/WireMock.Net.Tests/WireMock.Net.Tests.csproj | 2 +-
3 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/src/WireMock.Net.Testcontainers/WireMock.Net.Testcontainers.csproj b/src/WireMock.Net.Testcontainers/WireMock.Net.Testcontainers.csproj
index 98e4d3d3..565bdbbc 100644
--- a/src/WireMock.Net.Testcontainers/WireMock.Net.Testcontainers.csproj
+++ b/src/WireMock.Net.Testcontainers/WireMock.Net.Testcontainers.csproj
@@ -39,11 +39,11 @@
runtime; build; native; contentfiles; analyzers; buildtransitive
-
+
-
+
\ No newline at end of file
diff --git a/test/WireMock.Net.Tests/Testcontainers/TestcontainersTests.cs b/test/WireMock.Net.Tests/Testcontainers/TestcontainersTests.cs
index 2a219dc9..9e9f7189 100644
--- a/test/WireMock.Net.Tests/Testcontainers/TestcontainersTests.cs
+++ b/test/WireMock.Net.Tests/Testcontainers/TestcontainersTests.cs
@@ -123,7 +123,11 @@ public partial class TestcontainersTests
}
finally
{
- await wireMockContainer.StopAsync();
+ // Stop the container
+ if(wireMockContainer is not null)
+ {
+ await wireMockContainer.StopAsync();
+ }
}
}
}
diff --git a/test/WireMock.Net.Tests/WireMock.Net.Tests.csproj b/test/WireMock.Net.Tests/WireMock.Net.Tests.csproj
index e097a4a9..3602674f 100644
--- a/test/WireMock.Net.Tests/WireMock.Net.Tests.csproj
+++ b/test/WireMock.Net.Tests/WireMock.Net.Tests.csproj
@@ -102,7 +102,7 @@
-
+