From 2a010dcd42a6e54ffba6021662a4934c76a8f3b1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Crocquesel?= <88554524+scrocquesel@users.noreply.github.com> Date: Thu, 12 Jun 2025 22:06:58 +0200 Subject: [PATCH] Use default resource cleaning behavior in test (#1316) --- examples/WireMock.Net.TestcontainersExample/Program.cs | 10 ++-------- .../Testcontainers/TestcontainersTests.Grpc.cs | 8 -------- .../Testcontainers/TestcontainersTests.cs | 9 --------- 3 files changed, 2 insertions(+), 25 deletions(-) diff --git a/examples/WireMock.Net.TestcontainersExample/Program.cs b/examples/WireMock.Net.TestcontainersExample/Program.cs index a634d93f..1b6e65e0 100644 --- a/examples/WireMock.Net.TestcontainersExample/Program.cs +++ b/examples/WireMock.Net.TestcontainersExample/Program.cs @@ -159,9 +159,7 @@ internal class Program private static async Task TestWindowsCopyAsync() { var builder = new WireMockContainerBuilder() - .WithWatchStaticMappings(true) - .WithAutoRemove(true) - .WithCleanUp(true); + .WithWatchStaticMappings(true); var container = builder.Build(); @@ -186,8 +184,6 @@ internal class Program var mappings = await adminClient.GetMappingsAsync(); Console.WriteLine("mappings = " + JsonConvert.SerializeObject(mappings, Formatting.Indented)); - await Task.Delay(1_000); - await container.StopAsync(); } @@ -205,9 +201,7 @@ internal class Program .WithNetwork(dummyNetwork) .WithAdminUserNameAndPassword("x", "y") .WithMappings(mappingsPath) - .WithWatchStaticMappings(true) - // .WithAutoRemove(true) - .WithCleanUp(true); + .WithWatchStaticMappings(true); if (image != null) { diff --git a/test/WireMock.Net.Tests/Testcontainers/TestcontainersTests.Grpc.cs b/test/WireMock.Net.Tests/Testcontainers/TestcontainersTests.Grpc.cs index 47461573..12b903b2 100644 --- a/test/WireMock.Net.Tests/Testcontainers/TestcontainersTests.Grpc.cs +++ b/test/WireMock.Net.Tests/Testcontainers/TestcontainersTests.Grpc.cs @@ -25,8 +25,6 @@ public partial class TestcontainersTests var adminUsername = $"username_{Guid.NewGuid()}"; var adminPassword = $"password_{Guid.NewGuid()}"; var wireMockContainer = new WireMockContainerBuilder() - .WithAutoRemove(true) - .WithCleanUp(true) .WithAdminUserNameAndPassword(adminUsername, adminPassword) .WithCommand("--UseHttp2") .WithCommand("--Urls", "http://*:80 grpc://*:9090") @@ -80,8 +78,6 @@ public partial class TestcontainersTests var adminUsername = $"username_{Guid.NewGuid()}"; var adminPassword = $"password_{Guid.NewGuid()}"; var wireMockContainer = new WireMockContainerBuilder() - .WithAutoRemove(true) - .WithCleanUp(true) .WithAdminUserNameAndPassword(adminUsername, adminPassword) .AddUrl("http://*:8080") .AddUrl("grpc://*:9090") @@ -156,8 +152,6 @@ public partial class TestcontainersTests private static async Task Given_WireMockContainerIsStartedForHttpAndGrpcAsync() { var wireMockContainer = new WireMockContainerBuilder() - .WithAutoRemove(true) - .WithCleanUp(true) .AddUrl("grpc://*:9090") .Build(); @@ -169,8 +163,6 @@ public partial class TestcontainersTests private static async Task Given_WireMockContainerWithProtoDefinitionAtServerLevelIsStartedForHttpAndGrpcAsync() { var wireMockContainer = new WireMockContainerBuilder() - .WithAutoRemove(true) - .WithCleanUp(true) .AddUrl("grpc://*:9090") .AddProtoDefinition("my-greeter", ReadFile("greet.proto")) .Build(); diff --git a/test/WireMock.Net.Tests/Testcontainers/TestcontainersTests.cs b/test/WireMock.Net.Tests/Testcontainers/TestcontainersTests.cs index 23d95a8b..ba5bb4bf 100644 --- a/test/WireMock.Net.Tests/Testcontainers/TestcontainersTests.cs +++ b/test/WireMock.Net.Tests/Testcontainers/TestcontainersTests.cs @@ -24,8 +24,6 @@ public partial class TestcontainersTests(ITestOutputHelper testOutputHelper) var adminUsername = $"username_{Guid.NewGuid()}"; var adminPassword = $"password_{Guid.NewGuid()}"; var wireMockContainer = new WireMockContainerBuilder() - .WithAutoRemove(true) - .WithCleanUp(true) .WithAdminUserNameAndPassword(adminUsername, adminPassword) .Build(); @@ -40,14 +38,11 @@ public partial class TestcontainersTests(ITestOutputHelper testOutputHelper) // Act var dummyNetwork = new NetworkBuilder() .WithName("Dummy Network for TestcontainersTests") - .WithCleanUp(true) .Build(); var wireMockContainer = new WireMockContainerBuilder() .WithNetwork(dummyNetwork) .WithWatchStaticMappings(true) - .WithAutoRemove(true) - .WithCleanUp(true) .Build(); await StartTestAsync(wireMockContainer); @@ -61,8 +56,6 @@ public partial class TestcontainersTests(ITestOutputHelper testOutputHelper) var adminUsername = $"username_{Guid.NewGuid()}"; var adminPassword = $"password_{Guid.NewGuid()}"; var wireMockContainerBuilder = new WireMockContainerBuilder() - .WithAutoRemove(true) - .WithCleanUp(true) .WithAdminUserNameAndPassword(adminUsername, adminPassword); var imageOS = await TestcontainersUtils.GetImageOSAsync.Value; @@ -88,8 +81,6 @@ public partial class TestcontainersTests(ITestOutputHelper testOutputHelper) var adminUsername = $"username_{Guid.NewGuid()}"; var adminPassword = $"password_{Guid.NewGuid()}"; var wireMockContainerBuilder = new WireMockContainerBuilder() - .WithAutoRemove(true) - .WithCleanUp(true) .WithAdminUserNameAndPassword(adminUsername, adminPassword); var imageOS = await TestcontainersUtils.GetImageOSAsync.Value;