From 29bf9b42f85564db18ee3cc44690dce65131b9e2 Mon Sep 17 00:00:00 2001 From: JvE-iO Date: Thu, 30 Jan 2025 10:59:22 +0100 Subject: [PATCH] Add exception message to logging when mapping fails due to an exception. (#1248) * Add exception message to logging when mapping fails due to an exception. * Revert "Add exception message to logging when mapping fails due to an exception." This reverts commit eb7cf46c95a5b7e6744c7c9f5642878c5e49e1f7. * Fix loggers with improved exception logging. --- .../WireMock.Net.WebApplication.NET6/WireMockService.cs | 4 ++-- src/WireMock.Net.TUnit/TUnitWireMockLogger.cs | 4 ++-- src/WireMock.Net.xUnit/TestOutputHelperWireMockLogger.cs | 6 +++--- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/examples/WireMock.Net.WebApplication.NET6/WireMockService.cs b/examples/WireMock.Net.WebApplication.NET6/WireMockService.cs index 58bbdc14..d35f9c97 100644 --- a/examples/WireMock.Net.WebApplication.NET6/WireMockService.cs +++ b/examples/WireMock.Net.WebApplication.NET6/WireMockService.cs @@ -52,9 +52,9 @@ public class WireMockService : IWireMockService _logger.LogDebug("Admin[{0}] {1}", isAdminrequest, message); } - public void Error(string formatString, Exception exception) + public void Error(string message, Exception exception) { - _logger.LogError(formatString, exception.Message); + _logger.LogError(exception, message); } } diff --git a/src/WireMock.Net.TUnit/TUnitWireMockLogger.cs b/src/WireMock.Net.TUnit/TUnitWireMockLogger.cs index a3892600..050c84ec 100644 --- a/src/WireMock.Net.TUnit/TUnitWireMockLogger.cs +++ b/src/WireMock.Net.TUnit/TUnitWireMockLogger.cs @@ -51,9 +51,9 @@ public sealed class TUnitWireMockLogger : IWireMockLogger } /// - public void Error(string formatString, Exception exception) + public void Error(string message, Exception exception) { - _tUnitLogger.LogError(Format("Error", formatString, exception.Message), exception); + _tUnitLogger.LogError(Format("Error", $"{message} {{0}}", exception)); if (exception is AggregateException ae) { diff --git a/src/WireMock.Net.xUnit/TestOutputHelperWireMockLogger.cs b/src/WireMock.Net.xUnit/TestOutputHelperWireMockLogger.cs index df83bac3..0f0cbed2 100644 --- a/src/WireMock.Net.xUnit/TestOutputHelperWireMockLogger.cs +++ b/src/WireMock.Net.xUnit/TestOutputHelperWireMockLogger.cs @@ -50,15 +50,15 @@ public sealed class TestOutputHelperWireMockLogger : IWireMockLogger } /// - public void Error(string formatString, Exception exception) + public void Error(string message, Exception exception) { - _testOutputHelper.WriteLine(Format("Error", formatString, exception.Message)); + _testOutputHelper.WriteLine(Format("Error", $"{message} {{0}}", exception)); if (exception is AggregateException ae) { ae.Handle(ex => { - _testOutputHelper.WriteLine(Format("Error", "Exception {0}", ex.Message)); + _testOutputHelper.WriteLine(Format("Error", "Exception {0}", ex)); return true; }); }