starred/WireMock.Net
1
0
Fork 0
mirror of https://github.com/wiremock/WireMock.Net.git synced 2026-04-27 11:17:31 +02:00
Code Issues 32 Packages Projects Releases 10 Wiki Activity

Fix ExactMatcher and JsonMatcher not working for ISO dates as string (#1443)

Browse Source
This commit is contained in:
Stef Heyenrath
2026-04-17 13:32:26 +02:00
committed by GitHub
parent 02b7e3744e
commit 1e591d5f8a
7 changed files with 101 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

89
test/WireMock.Net.Tests/Serialization/MappingSerializerTests.cs
View File

@@ -3,6 +3,8 @@
using JsonConverter.Newtonsoft.Json;
using WireMock.Admin.Mappings;
using WireMock.Serialization;
using Newtonsoft.Json.Linq;
#if NET8_0_OR_GREATER
using JsonConverter.System.Text.Json;
#endif
@@ -319,5 +321,92 @@ public class MappingSerializerTests
act.Should().Throw<InvalidOperationException>()
.WithMessage("Cannot deserialize the provided value to an array or object.");
}
[Fact]
public void MappingSerializer_DeserializeJsonToArray_WithNewtonsoftJson_DateTimeStringInQueryParamExactMatcherPattern_ShouldPreservePatternAsString()
{
// Arrange
var jsonConverter = new NewtonsoftJsonConverter();
var serializer = new MappingSerializer(jsonConverter);
var mappingJson =
"""
{
"Guid": "12345678-1234-1234-1234-aaaaaaaaaaaa",
"Request": {
"Path": "/api/report",
"Methods": ["GET"],
"Params": [
{
"Name": "asOfDate",
"Matchers": [
{
"Name": "ExactMatcher",
"Pattern": "2021-11-10T13:39:13.705"
}
]
}
]
},
"Response": {
"StatusCode": 200
}
}
""";
// Act
var result = serializer.DeserializeJsonToArray<MappingModel>(mappingJson);
// Assert
result.Should().HaveCount(1);
var matcher = result[0].Request!.Params![0].Matchers![0];
matcher.Name.Should().Be("ExactMatcher");
matcher.Pattern.Should().BeOfType<string>()
.Which.Should().Be("2021-11-10T13:39:13.705",
"datetime-format strings in ExactMatcher Pattern fields must survive deserialization as strings, " +
"not be auto-converted to DateTime by Newtonsoft.Json's DateParseHandling.DateTime");
}
[Fact]
public void MappingSerializer_DeserializeJsonToArray_WithNewtonsoftJson_DateTimeStringInJsonMatcherBodyPattern_ShouldPreservePatternAsString()
{
// Arrange
var jsonConverter = new NewtonsoftJsonConverter();
var serializer = new MappingSerializer(jsonConverter);
// Pattern is an INLINE JSON object (not a string) - this is how WireMock mapping files store
// JsonMatcher patterns when recorded. Newtonsoft with DateParseHandling.DateTime will convert
// the datetime value inside the JObject to JTokenType.Date during deserialization.
var mappingJson =
"""
{
"Guid": "12345678-1234-1234-1234-bbbbbbbbbbbb",
"Request": {
"Path": "/api/report",
"Methods": ["POST"],
"Body": {
"Matcher": {
"Name": "JsonMatcher",
"Pattern": {"Date": "2021-09-30T00:00:00Z", "Names": ["Cash"]}
}
}
},
"Response": {
"StatusCode": 200
}
}
""";
// Act
var result = serializer.DeserializeJsonToArray<MappingModel>(mappingJson);
// Assert - datetime values inside the JObject pattern must remain JTokenType.String.
result.Should().HaveCount(1);
var matcher = result[0].Request!.Body!.Matcher!;
matcher.Name.Should().Be("JsonMatcher");
var patternJObject = matcher.Pattern.Should().BeOfType<JObject>().Subject;
patternJObject["Date"]!.Type.Should().Be(JTokenType.String,
"datetime-format strings inside an inline JsonMatcher body pattern must retain JTokenType.String " +
"after deserialization; if DateParseHandling.DateTime auto-converts them to JTokenType.Date, " +
"JToken.DeepEquals will fail against incoming request bodies parsed with DateParseHandling.None");
}
#endif
}