[PR #411] [MERGED] Improved relative path checking based on file existence #902

New Issue

Closed

opened 2025-12-29 15:34:06 +01:00 by adam · 0 comments

adam commented 2025-12-29 15:34:06 +01:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/wiremock/WireMock.Net/pull/411
Author: @NoahLerner
Created: 1/30/2020
Status: ✅ Merged
Merged: 2/2/2020
Merged by: @StefH

Base: master ← Head: Improved_RelativePath_BodyAsFile

---

📝 Commits (10+)

• c1f757b Improved relative path checking based on file existence
• 962824f Apply File.Exists logic to ReadResponseBodyAsString as well
• 9bc737f Make path handling more robust since path is user defined
• e8a8314 Unit tests for relative path feature
• 66448a9 Replace all back and forward slashes with system dependent DirectorySeparatorChar
• 3681e64 Attempt fix broken directory separator chars for Unix platforms
• 88f48ac Revert wrapping GetMappingFolder with CleanPath
• 11f36fc Move CleanPath logic to its own class
• 3061226 Remove whitespace
• 01b9c5d Remove more whitespace

📊 Changes

6 files changed (+155 additions, -13 deletions)

View changed files

📝 src/WireMock.Net/Handlers/LocalFileSystemHandler.cs (+6 -5)
➕ src/WireMock.Net/Util/PathUtils.cs (+36 -0)
📝 test/WireMock.Net.Tests/ResponseBuilders/ResponseWithBodyFromFileTests.cs (+63 -8)
➕ test/WireMock.Net.Tests/Util/PathUtilsTests.cs (+44 -0)
📝 test/WireMock.Net.Tests/WireMock.Net.Tests.csproj (+3 -0)
➕ test/WireMock.Net.Tests/__admin/mappings/subdirectory/MyXmlResponse.xml (+3 -0)

📄 Description

If the file exists at the relative path, then use it. If not, then use the path as is.

This is stronger than the previous check if the path is just the filename, since if it's just a file name then we'll check if the file exists at the relative path & then use if yes. Otherwise, use the path as is.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/wiremock/WireMock.Net/pull/411 **Author:** [@NoahLerner](https://github.com/NoahLerner) **Created:** 1/30/2020 **Status:** ✅ Merged **Merged:** 2/2/2020 **Merged by:** [@StefH](https://github.com/StefH) **Base:** `master` ← **Head:** `Improved_RelativePath_BodyAsFile` --- ### 📝 Commits (10+) - [`c1f757b`](https://github.com/wiremock/WireMock.Net/commit/c1f757b487003698367c1b296aa77a76882c9279) Improved relative path checking based on file existence - [`962824f`](https://github.com/wiremock/WireMock.Net/commit/962824f61edb18d0cdde813a7db0b160e81dc058) Apply File.Exists logic to ReadResponseBodyAsString as well - [`9bc737f`](https://github.com/wiremock/WireMock.Net/commit/9bc737f31c62154d4d6641b55d5540f4fe60543d) Make path handling more robust since path is user defined - [`e8a8314`](https://github.com/wiremock/WireMock.Net/commit/e8a83147953afdaba73c1bb5b3d8057595e4d10d) Unit tests for relative path feature - [`66448a9`](https://github.com/wiremock/WireMock.Net/commit/66448a9ea3202e32c033e884ac53445c6c66175d) Replace all back and forward slashes with system dependent DirectorySeparatorChar - [`3681e64`](https://github.com/wiremock/WireMock.Net/commit/3681e64680a2d3d433f734a560e4c2833969c610) Attempt fix broken directory separator chars for Unix platforms - [`88f48ac`](https://github.com/wiremock/WireMock.Net/commit/88f48acbb91bfba6b040332e59832940ff34f7cc) Revert wrapping GetMappingFolder with CleanPath - [`11f36fc`](https://github.com/wiremock/WireMock.Net/commit/11f36fc4bc115e3a9a2a261eb4853960565d203a) Move CleanPath logic to its own class - [`3061226`](https://github.com/wiremock/WireMock.Net/commit/306122609515aa53f84bf11229fb0523be7502ae) Remove whitespace - [`01b9c5d`](https://github.com/wiremock/WireMock.Net/commit/01b9c5ddfe1b6da47f7f992ebf87d58d7282f9dd) Remove more whitespace ### 📊 Changes **6 files changed** (+155 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `src/WireMock.Net/Handlers/LocalFileSystemHandler.cs` (+6 -5) ➕ `src/WireMock.Net/Util/PathUtils.cs` (+36 -0) 📝 `test/WireMock.Net.Tests/ResponseBuilders/ResponseWithBodyFromFileTests.cs` (+63 -8) ➕ `test/WireMock.Net.Tests/Util/PathUtilsTests.cs` (+44 -0) 📝 `test/WireMock.Net.Tests/WireMock.Net.Tests.csproj` (+3 -0) ➕ `test/WireMock.Net.Tests/__admin/mappings/subdirectory/MyXmlResponse.xml` (+3 -0) </details> ### 📄 Description If the file exists at the relative path, then use it. If not, then use the path as is. This is stronger than the previous check if the path is just the filename, since if it's just a file name then we'll check if the file exists at the relative path & then use if yes. Otherwise, use the path as is. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

adam added the pull-request label 2025-12-29 15:34:06 +01:00

adam closed this issue 2025-12-29 15:34:06 +01:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

mime-part-matcher

version-2.x

MappingSerializer

1341-mapping-json

stef-aspire-tests-updates

bug/973-TinyMapper

bug/1149-AppendGuidToSavedMappingFile

feature/1150-DockerImageVersion

61

stef-1108

stef-1097

stef-1083-MessageOptions_Type_Conflict

stef-1062-logger

stef-IgnoreOpenApiErrors

stef-928-TypeLoadException-FluentAssertions-net472

nunit

stef-849

stef-847-regex-questionmark

http_verb

WireMockServerContext

webapp

ai

CommandLineArgumentsParser

1.23.0

1.22.0

1.21.0

1.20.0

1.19.0

1.18.0

1.17.0

1.16.0

1.15.0

1.14.0

1.13.0

1.12.0

1.11.2

1.11.0

1.10.1

1.10.0

1.9.1

1.9.0

1.8.18

1.8.17

1.8.16

1.8.15

1.8.14

1.8.13

1.8.12

1.8.11

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.3

1.8.2

1.8.1

1.8.0

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.12

1.6.11

1.6.10

1.6.9

1.6.8

1.6.7

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.62

1.5.61

1.5.60

1.5.59

1.5.58

1.5.57

1.5.56

1.5.55

1.5.54

1.5.53

1.5.52

1.5.51

1.5.50

1.5.49

1.5.48

1.5.47

1.5.46

1.5.45

1.5.44

1.5.43

1.5.42

1.5.41

1.5.40

1.5.39

1.5.38

1.5.37

1.5.36

1.5.35

1.5.34

1.5.33

1.5.32

1.5.31

1.5.30

1.5.29

1.5.28

1.5.27

1.5.26

1.5.25

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.43

1.4.42

1.4.41

1.4.40

1.4.39

1.4.38

1.4.37

1.4.36

1.4.35

1.4.34

1.4.33

1.4.32

1.4.31

1.4.30

1.4.29

1.4.28

1.4.27

1.4.26

1.4.25

1.4.24

1.4.23

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.10

1.3.9

1.3.8

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11.0

1.2.10

1.2.9.0

1.2.8.0

1.2.7.0

1.2.6.0

1.2.5.0

1.2.4.0

1.2.3.0

1.2.2.0

1.2.1.0

1.2.0.0

1.1.10

1.1.9.0

1.1.8.0

1.1.7.0

1.1.6.0

1.1.5.0

1.1.3.0

1.1.2.0

1.1.1.0

1.1.0.0

1.0.43.0

1.0.42.0

1.0.41.0

1.0.40.0

1.0.39.0

1.0.38.0

1.0.37.0

1.0.36.0

1.0.35.0

1.0.34.0

1.0.33.0

1.0.32.0

1.0.31.0

1.0.29.0

1.0.28.0

1.0.25.0

1.0.24.0

1.0.23.0

1.0.22.0

1.0.21.0

1.0.20.0

1.0.19.0

1.0.18.0

1.0.17.0

1.0.16.0

1.0.15.0

1.0.14.0

1.0.13.0

1.0.12.0

1.0.11.0

1.0.10.0

1.0.9.0

1.0.8.0

1.0.7.0

1.0.6.1

1.0.6

1.0.5

1.0.4.21

1.0.4.20

1.0.4.19

1.0.4.18

1.0.4.17

1.0.4.16

1.0.4.15

1.0.4.14

1.0.4.13

1.0.4.12

1.0.4.11

1.0.4.10

1.0.4.9

1.0.4.8

1.0.4.7

1.0.4.6

1.0.4.5

1.0.4.4

1.0.4.3

1.0.4.2

1.0.4.1

1.0.4.0

1.0.3.20

1.0.3.19

1.0.3.18

1.0.3.17

1.0.3.16

1.0.3.15

1.0.3.14

1.0.3.13

1.0.3.12

1.0.3.11

1.0.3.10

1.0.3.9

1.0.3.8

1.0.3.7

1.0.3.6

1.0.3.5

1.0.3.4

1.0.3.3

1.0.3.2

1.0.3.1

1.0.3.0

1.0.2.13

1.0.2.12

1.0.2.11

1.0.2.10

1.0.2.9

1.0.2.8

1.0.2.7

1.0.2.6

1.0.2.5

1.0.2.4

1.0.2.1

1.0.2.0

1.0.1.5

1.0.1.3

1.0.1.2

1.0.1.1

1.0.0.0

Labels

Clear labels

bug

bug

doc

doc

duplicate

feature

feature

invalid

pull-request

Mirrored from GitHub Pull Request

question

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

adam

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/WireMock.Net-wiremock#902