[PR #316] [MERGED] Handles case where parameter value contains == #852

Closed
opened 2025-12-29 15:33:40 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/wiremock/WireMock.Net/pull/316
Author: @lobsteropteryx
Created: 8/13/2019
Status: Merged
Merged: 8/14/2019
Merged by: @StefH

Base: masterHead: fix-double-equals-when-parsing-querystring


📝 Commits (1)

  • cafeaf4 Handles case where parameter value contains ==

📊 Changes

2 files changed (+15 additions, -6 deletions)

View changed files

📝 src/WireMock.Net/Util/QueryStringParser.cs (+1 -6)
📝 test/WireMock.Net.Tests/Util/QueryStringParserTests.cs (+14 -0)

📄 Description

This is a fix for #287; querystring parameters that contain == in their value were not being properly parsed, i.e., ?key=value==something.

The fix here limits splitting each querystring parameter to the first = in the string.

I don't see any contributing guidelines, so I'm happy to make changes if need be. Thank you for a great tool!


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/wiremock/WireMock.Net/pull/316 **Author:** [@lobsteropteryx](https://github.com/lobsteropteryx) **Created:** 8/13/2019 **Status:** ✅ Merged **Merged:** 8/14/2019 **Merged by:** [@StefH](https://github.com/StefH) **Base:** `master` ← **Head:** `fix-double-equals-when-parsing-querystring` --- ### 📝 Commits (1) - [`cafeaf4`](https://github.com/wiremock/WireMock.Net/commit/cafeaf42ae5e511be825e07b90012a6170b28f80) Handles case where parameter value contains == ### 📊 Changes **2 files changed** (+15 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/WireMock.Net/Util/QueryStringParser.cs` (+1 -6) 📝 `test/WireMock.Net.Tests/Util/QueryStringParserTests.cs` (+14 -0) </details> ### 📄 Description This is a fix for #287; querystring parameters that contain `==` in their value were not being properly parsed, i.e., `?key=value==something`. The fix here limits splitting each querystring parameter to the first `=` in the string. I don't see any contributing guidelines, so I'm happy to make changes if need be. Thank you for a great tool! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 15:33:40 +01:00
adam closed this issue 2025-12-29 15:33:40 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/WireMock.Net-wiremock#852