[PR #65] [MERGED] bug: Fix admin api client definition returning the wrong types #753

Closed
opened 2025-12-29 15:33:03 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/wiremock/WireMock.Net/pull/65
Author: @alastairtree
Created: 11/19/2017
Status: Merged
Merged: 11/19/2017
Merged by: @StefH

Base: masterHead: bug/admin-api-client-returns-empty-request-models


📝 Commits (2)

  • 9f4d4cc bug: Fix admin api client definition returning the wrong types
  • c8b4fa5 Fix Build status and rename tests

📊 Changes

4 files changed (+70 additions, -5 deletions)

View changed files

📝 README.md (+1 -1)
📝 src/WireMock.Net/Client/IFluentMockServerAdmin.cs (+4 -3)
📝 src/WireMock.Net/Server/FluentMockServer.Admin.cs (+1 -1)
test/WireMock.Net.Tests/FluentMockServerAdminRestClientTests.cs (+64 -0)

📄 Description

Hello. Been testing the use of the admin api client with RestEase and noticed that the definition has the wrong types listed as being return on the get requests API meaning the restease client has null values and some data is missing. In addition the find requests API does not return LogEntryModel like the GetRequests API instead it returns LogEntry, which I have fixed so they are all the same.

  • IFluentMockServerAdmin get, find and get all requests should return a log entry model
  • Add tests for get and find using the rest ease api client

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/wiremock/WireMock.Net/pull/65 **Author:** [@alastairtree](https://github.com/alastairtree) **Created:** 11/19/2017 **Status:** ✅ Merged **Merged:** 11/19/2017 **Merged by:** [@StefH](https://github.com/StefH) **Base:** `master` ← **Head:** `bug/admin-api-client-returns-empty-request-models` --- ### 📝 Commits (2) - [`9f4d4cc`](https://github.com/wiremock/WireMock.Net/commit/9f4d4ccb4ba14edeb660050aa57dc56408ee3efd) bug: Fix admin api client definition returning the wrong types - [`c8b4fa5`](https://github.com/wiremock/WireMock.Net/commit/c8b4fa5a3001ce1a9c504329243c610c86167d69) Fix Build status and rename tests ### 📊 Changes **4 files changed** (+70 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+1 -1) 📝 `src/WireMock.Net/Client/IFluentMockServerAdmin.cs` (+4 -3) 📝 `src/WireMock.Net/Server/FluentMockServer.Admin.cs` (+1 -1) ➕ `test/WireMock.Net.Tests/FluentMockServerAdminRestClientTests.cs` (+64 -0) </details> ### 📄 Description Hello. Been testing the use of the admin api client with RestEase and noticed that the definition has the wrong types listed as being return on the get requests API meaning the restease client has null values and some data is missing. In addition the find requests API does not return LogEntryModel like the GetRequests API instead it returns LogEntry, which I have fixed so they are all the same. - IFluentMockServerAdmin get, find and get all requests should return a log entry model - Add tests for get and find using the rest ease api client --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 15:33:03 +01:00
adam closed this issue 2025-12-29 15:33:03 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/WireMock.Net-wiremock#753