mirror of
https://github.com/wiremock/WireMock.Net.git
synced 2026-01-11 22:30:41 +01:00
[PR #65] [MERGED] bug: Fix admin api client definition returning the wrong types #753
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/wiremock/WireMock.Net/pull/65
Author: @alastairtree
Created: 11/19/2017
Status: ✅ Merged
Merged: 11/19/2017
Merged by: @StefH
Base:
master← Head:bug/admin-api-client-returns-empty-request-models📝 Commits (2)
9f4d4ccbug: Fix admin api client definition returning the wrong typesc8b4fa5Fix Build status and rename tests📊 Changes
4 files changed (+70 additions, -5 deletions)
View changed files
📝
README.md(+1 -1)📝
src/WireMock.Net/Client/IFluentMockServerAdmin.cs(+4 -3)📝
src/WireMock.Net/Server/FluentMockServer.Admin.cs(+1 -1)➕
test/WireMock.Net.Tests/FluentMockServerAdminRestClientTests.cs(+64 -0)📄 Description
Hello. Been testing the use of the admin api client with RestEase and noticed that the definition has the wrong types listed as being return on the get requests API meaning the restease client has null values and some data is missing. In addition the find requests API does not return LogEntryModel like the GetRequests API instead it returns LogEntry, which I have fixed so they are all the same.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.