starred/WireMock.Net-wiremock
1
0
Fork 0
mirror of https://github.com/wiremock/WireMock.Net.git synced 2026-09-20 00:31:41 +02:00
Code Issues 32 Packages Projects Releases 10 Wiki Activity

Specifying .WithBody(byte[]) fails to match for JSON bodies #708

New Issue
Closed
opened 2025-12-29 15:31:30 +01:00 by adam · 1 comment
adam commented 2025-12-29 15:31:30 +01:00
Owner
Copy Link
Copy Source

Originally created by @smfields on GitHub (Jul 27, 2025).

Describe the bug

When using the overload of .WithBody() that accepts a byte[] it will fail to match on requests that have a matching body if the bytes happen to correspond to valid JSON.

The behavior is inconsistent as it will correctly match on arbitrary strings that have been encoded and provided as bytes, but it will fail to match if the string corresponds to valid JSON, regardless of the content type specified on the request.

Expected behavior:

WireMock should match requests that have a body that matches the provided bytes, regardless of what those bytes represent.

Test to reproduce

See repro: https://github.com/smfields/WiremockIssueRepro/tree/master

Other related info

Seems like the issue probably stems from this section of BodyDataMatchScoreCalculator.cs.

When the matcher is an ExactObjectMatcher it will compare the value against the bytes only if the detected body type is bytes, string, or form. When the detected body type is JSON we drop down to the next section that compares the provided value against the BodyAsJson, but since the provided value is bytes this doesn't line up.

Seems like we need to either open up the comparison on line 41 to also include times when the provided value is of type byte[], or we need to parse the bytes into JSON before doing the comparison against BodyAsJson.

Originally created by @smfields on GitHub (Jul 27, 2025). ### Describe the bug When using the overload of `.WithBody()` that accepts a `byte[]` it will fail to match on requests that have a matching body if the bytes happen to correspond to valid JSON. The behavior is inconsistent as it will correctly match on arbitrary strings that have been encoded and provided as bytes, but it will fail to match if the string corresponds to valid JSON, regardless of the content type specified on the request. ### Expected behavior: WireMock should match requests that have a body that matches the provided bytes, regardless of what those bytes represent. ### Test to reproduce See repro: https://github.com/smfields/WiremockIssueRepro/tree/master ### Other related info Seems like the issue probably stems from [this section](https://github.com/wiremock/WireMock.Net/blob/e400e92452da3d1e46c3d97d24aca56dd5ad89b0/src/WireMock.Net.Shared/Matchers/Helpers/BodyDataMatchScoreCalculator.cs#L37) of `BodyDataMatchScoreCalculator.cs`. When the matcher is an `ExactObjectMatcher` it will compare the value against the bytes only if the detected body type is bytes, string, or form. When the detected body type is JSON we drop down to the next section that compares the provided value against the `BodyAsJson`, but since the provided value is bytes this doesn't line up. Seems like we need to either open up the comparison on line 41 to also include times when the provided value is of type `byte[]`, or we need to parse the bytes into JSON before doing the comparison against `BodyAsJson`.
adam added the bug label 2025-12-29 15:31:30 +01:00
adam closed this issue 2025-12-29 15:31:30 +01:00
adam commented 2025-12-29 15:31:30 +01:00
Author
Owner
Copy Link
Copy Source

@smfields commented on GitHub (Jul 27, 2025):

Might be as easy as what I've started in https://github.com/wiremock/WireMock.Net/pull/1339, but more testing would be needed to confirm.

@smfields commented on GitHub (Jul 27, 2025): Might be as easy as what I've started in https://github.com/wiremock/WireMock.Net/pull/1339, but more testing would be needed to confirm.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
bug
doc
doc
duplicate
feature
feature
invalid
pull-request
Mirrored from GitHub Pull Request
 question
wontfix
No labels bug
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/WireMock.Net-wiremock#708