mirror of
https://github.com/wiremock/WireMock.Net.git
synced 2026-01-11 14:20:29 +01:00
Issue: Introduced dependency on log4net #68
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @alexangas on GitHub (Feb 27, 2018).
Originally assigned to: @StefH on GitHub.
Hello,
It looks like in v1.0.3 a dependency was introduced for log4net. I'm just wondering if it's possible to remove this please, or only include it for the Standalone server?
This doesn't significantly affect my project right now - at worst it is a mild annoyance as we use a different logging framework.
However for a project I worked on a year ago, this dependency would have made it impossible to use WireMock.Net. This is because for some reason, log4net is a candidate for abuse where developers create their own versions and embed it within their projects without changing the namespace. I've seen this twice in my career so far on significant projects such as NServiceBus (an old 2.x version but still in use), and an older version of Sitecore. It makes it impossible to include a reference to the official log4net binary.
Regardless, logging isn't required for the solution to operate, so it would be helpful if it was not included as a required dependency. 😃
Can logging please be exposed as some sort of interface instead so developers can plug in their own logging code? It is simple to write.
Thanks for your consideration!
@StefH commented on GitHub (Feb 27, 2018):
I'll refactor the code to use logging interface which will probably look a lot like log4net or nlog.
@StefH commented on GitHub (Feb 27, 2018):
I've created a PR, and I want to add you as a reviewer, and I sent invite request for this repository.