mirror of
https://github.com/wiremock/WireMock.Net.git
synced 2026-01-11 14:20:29 +01:00
Bug: WireMock.Net is not matching application/json http requests using JSONPathMatcher #67
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @aledaccas on GitHub (Feb 19, 2018).
Originally assigned to: @StefH on GitHub.
The JSONPathMatcher does not match a json body request. (Using the IRequestBuilder .WithBody())
This is because the RequestMessageBodyMatcher only uses the .Body property and not the .BodyAsJson property.
to get working, either Body and BodyAsJson must be filled with the body string from request.
@StefH commented on GitHub (Feb 20, 2018):
This was broken during the last changes. I will take a look.
@StefH commented on GitHub (Feb 21, 2018):
Hello @aledaccas
I did fix it, however, can you please take a look at my code https://github.com/WireMock-Net/WireMock.Net/compare/json?expand=1 before I commit and create a new NuGet ?
@joostvanhassel commented on GitHub (Feb 22, 2018):
@StefH Is it possible to open a PR, so conversation on the changes is easy?
@StefH commented on GitHub (Feb 22, 2018):
@joostvanhassel I did add you as reviewer to a the PR.
https://github.com/WireMock-Net/WireMock.Net/pull/92
@aledaccas commented on GitHub (Feb 22, 2018):
Hi Stef I’ll take a look today.
Regards,
@aledaccas commented on GitHub (Feb 22, 2018):
Stef,
I’d a look and for me It’s ok.
You’ve created more interfaces inheriting from IMatcher passing object as parameter for IsMatch method, adjusted the Matchers and changed the RequestMessage*Matcher classes to adapt to this new matchers. Sweet! ☺
Regards.
Aledaccas
From: Alexandre Daccas Mendonça
Sent: quinta-feira, 22 de fevereiro de 2018 09:14
To: 'WireMock-Net/WireMock.Net' reply@reply.github.com; WireMock-Net/WireMock.Net WireMock.Net@noreply.github.com
Cc: Mention mention@noreply.github.com
Subject: RE: [WireMock-Net/WireMock.Net] Bug: WireMock.Net is not matching application/json http requests using JSONPathMatcher (#91)
Hi Stef I’ll take a look today.
Regards,