starred/WireMock.Net-wiremock
1
0
Fork 0
mirror of https://github.com/wiremock/WireMock.Net.git synced 2026-09-02 00:47:31 +02:00
Code Issues 32 Packages Projects Releases 10 Wiki Activity

MappingsToCSharpCode should use RegexMatcher when specified #619

New Issue
Closed
opened 2025-12-29 15:29:01 +01:00 by adam · 3 comments
adam commented 2025-12-29 15:29:01 +01:00
Owner
Copy Link
Copy Source

Originally created by @carlin-q-scott on GitHub (Aug 5, 2024).

Originally assigned to: @StefH on GitHub.

Is your feature request related to a problem? Please describe.
I used the MappingsToCSharpCode on the WiremockServer class to get C# mappings for my json mocks and it did not respect the matchers. It assumed everything was an exact match.

My json defined mock:

{
  "Request": {
    "Methods": [
      "POST"
    ],
    "Path": "/auth",
    "Params": [
      {
        "Name": "clientId",
        "Matchers": [
          {
            "Name": "RegexMatcher",
            "Pattern": "^scenario_(.+)$"
          }
        ]
      }
    ]
  }
}

The resulting CSharpCode:

builder
    .Given(Request.Create()
        .UsingMethod("POST")
        .WithPath("/auth")
        .WithParam("clientId", $"^scenario_(.+)$")
    )

Describe the solution you'd like
If the Matcher.Name is RegexMatcher, then create a RegexMatcher instead of directly passing the pattern to the RequestBuilder method.

builder
    .Given(Request.Create()
        .UsingMethod("POST")
        .WithPath("/auth")
        .WithParam("clientId", new RegexMatcher($"^scenario_(.+)$"))
    )

Describe alternatives you've considered
Manually fixing the generated code.

Is your feature request supported by WireMock (java version)? Please provide details.
I don't think this relevant.

Additional context
Add any other context or screenshots about the feature request here.

Originally created by @carlin-q-scott on GitHub (Aug 5, 2024). Originally assigned to: @StefH on GitHub. **Is your feature request related to a problem? Please describe.** I used the MappingsToCSharpCode on the WiremockServer class to get C# mappings for my json mocks and it did not respect the matchers. It assumed everything was an exact match. My json defined mock: ```json { "Request": { "Methods": [ "POST" ], "Path": "/auth", "Params": [ { "Name": "clientId", "Matchers": [ { "Name": "RegexMatcher", "Pattern": "^scenario_(.+)$" } ] } ] } } ``` The resulting CSharpCode: ```c# builder .Given(Request.Create() .UsingMethod("POST") .WithPath("/auth") .WithParam("clientId", $"^scenario_(.+)$") ) ``` **Describe the solution you'd like** If the Matcher.Name is RegexMatcher, then create a RegexMatcher instead of directly passing the pattern to the RequestBuilder method. ```c# builder .Given(Request.Create() .UsingMethod("POST") .WithPath("/auth") .WithParam("clientId", new RegexMatcher($"^scenario_(.+)$")) ) ``` **Describe alternatives you've considered** Manually fixing the generated code. **Is your feature request supported by [WireMock (java version)](https://www.wiremock.org)? Please provide details.** I don't think this relevant. **Additional context** Add any other context or screenshots about the feature request here.
adam added the bug label 2025-12-29 15:29:01 +01:00
adam closed this issue 2025-12-29 15:29:03 +01:00
adam commented 2025-12-29 15:29:03 +01:00
Author
Owner
Copy Link
Copy Source

@StefH commented on GitHub (Aug 5, 2024):

@carlin-q-scott
This is indeed invalid.
(ExactMatcher and LinqMatcher are also not correctly transformed)

However fixing this needs a complete rewrite from the generating logic...
(Currently the logic is defined in 1 class, but the knowledge about the parameters should be moved to the matcher itself...)

@StefH commented on GitHub (Aug 5, 2024): @carlin-q-scott This is indeed invalid. (ExactMatcher and LinqMatcher are also not correctly transformed) However fixing this needs a complete rewrite from the generating logic... (Currently the logic is defined in 1 class, but the knowledge about the parameters should be moved to the matcher itself...)
adam commented 2025-12-29 15:29:03 +01:00
Author
Owner
Copy Link
Copy Source

@StefH commented on GitHub (Aug 6, 2024):

https://github.com/WireMock-Net/WireMock.Net/pull/1152

@StefH commented on GitHub (Aug 6, 2024): https://github.com/WireMock-Net/WireMock.Net/pull/1152
adam commented 2025-12-29 15:29:04 +01:00
Author
Owner
Copy Link
Copy Source

@StefH commented on GitHub (Aug 6, 2024):

@carlin-q-scott
If you want, you can use preview 1.5.62-ci-19075 to test.

@StefH commented on GitHub (Aug 6, 2024): @carlin-q-scott If you want, you can use preview 1.5.62-ci-19075 to test.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
bug
doc
doc
duplicate
feature
feature
invalid
pull-request
Mirrored from GitHub Pull Request
 question
wontfix
No labels bug
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/WireMock.Net-wiremock#619