JsonPartialMatcher - match guid and string #529

New Issue

adam · 2025-12-29T15:26:00+01:00

adam commented

2025-12-29 15:26:00 +01:00

Originally created by @timurnes on GitHub (Jul 19, 2023).

As a WireMock user I'd like to setup JsonPartialMatcher using anonymous object with some Guid fields.
As of now I have to cast Guid fields to string because this condition in AbstractJsonPartialMatcher rejects match - value type is JTokenType.Guid and input type is JTokenType.String.

Generally, guid in json is a string so I think this feature can simplify user code a bit and won't be a breaking change

Possible solution is to add a check before the condition I've specified above

if (input != null &&
    ((value.Type == JTokenType.Guid && input.Type == JTokenType.String) ||
    (value.Type == JTokenType.String && input.Type == JTokenType.Guid)))
{
    return IsMatch(value.ToString(), input.ToString());
}

Unit test in JsonPartialMatcherTests:

[Fact]
public void JsonPartialMatcher_IsMatch_GuidAsString()
{
	// Assign
	var name = Guid.NewGuid();
	var matcher = new JsonPartialMatcher(new { Id = 1, Name = name });

	// Act
	var jObject = new JObject
	{
		{ "Id", new JValue(1) },
		{ "Name", new JValue(name.ToString()) }
	};
	double match = matcher.IsMatch(jObject);

	// Assert
	Assert.Equal(1.0, match);
}

Originally created by @timurnes on GitHub (Jul 19, 2023). As a WireMock user I'd like to setup JsonPartialMatcher using anonymous object with some Guid fields. As of now I have to cast Guid fields to string because [this condition](https://github.com/WireMock-Net/WireMock.Net/blob/9c51548d2b664b8c6a7417495491e2f5b2de53c2/src/WireMock.Net/Matchers/AbstractJsonPartialMatcher.cs#L77C9-L80C10) in AbstractJsonPartialMatcher rejects match - value type is JTokenType.Guid and input type is JTokenType.String. Generally, guid in json is a string so I think this feature can simplify user code a bit and won't be a breaking change Possible solution is to add a check before the condition I've specified above ``` if (input != null && ((value.Type == JTokenType.Guid && input.Type == JTokenType.String) || (value.Type == JTokenType.String && input.Type == JTokenType.Guid))) { return IsMatch(value.ToString(), input.ToString()); } ``` Unit test in JsonPartialMatcherTests: ``` [Fact] public void JsonPartialMatcher_IsMatch_GuidAsString() { // Assign var name = Guid.NewGuid(); var matcher = new JsonPartialMatcher(new { Id = 1, Name = name }); // Act var jObject = new JObject { { "Id", new JValue(1) }, { "Name", new JValue(name.ToString()) } }; double match = matcher.IsMatch(jObject); // Assert Assert.Equal(1.0, match); } ```

adam added the feature label 2025-12-29 15:26:00 +01:00

adam closed this issue

2025-12-29 15:26:00 +01:00

adam commented

2025-12-29 15:26:00 +01:00

@StefH commented on GitHub (Jul 19, 2023):

@timurnes

Looks ok to me.
Can you make a PR with code change + unit tests?

However I think that this same logic needs to be applied to line 66 if a Regex is used:

if (Regex && value.Type == JTokenType.String && input != null)

@StefH commented on GitHub (Jul 19, 2023): @timurnes Looks ok to me. Can you make a PR with code change + unit tests? However I think that this same logic needs to be applied to line 66 if a Regex is used: ``` c# if (Regex && value.Type == JTokenType.String && input != null) ```

adam commented

2025-12-29 15:26:01 +01:00

@timurnes commented on GitHub (Jul 19, 2023):

@StefH
Created PR #972

I haven't added any changes to Regex logic because I can't imagine how we can create valid regex with Guid type. So Guid field will be skipped and matched on the next condition that is added with this PR

@timurnes commented on GitHub (Jul 19, 2023): @StefH Created PR #972 I haven't added any changes to Regex logic because I can't imagine how we can create valid regex with Guid type. So Guid field will be skipped and matched on the next condition that is added with this PR

adam referenced this issue

2025-12-29 15:34:28 +01:00

[PR #529] [MERGED] Add assertions for ClientIP, Url and ProxyUrl #954

Sign in to join this conversation.

Branches Tags

master

mime-part-matcher

version-2.x

MappingSerializer

1341-mapping-json

stef-aspire-tests-updates

bug/973-TinyMapper

bug/1149-AppendGuidToSavedMappingFile

feature/1150-DockerImageVersion

61

stef-1108

stef-1097

stef-1083-MessageOptions_Type_Conflict

stef-1062-logger

stef-IgnoreOpenApiErrors

stef-928-TypeLoadException-FluentAssertions-net472

nunit

stef-849

stef-847-regex-questionmark

http_verb

WireMockServerContext

webapp

ai

CommandLineArgumentsParser

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/WireMock.Net-wiremock#529