starred/WireMock.Net-wiremock
1
0
Fork 0
mirror of https://github.com/wiremock/WireMock.Net.git synced 2026-01-11 22:30:41 +01:00
Code Issues 32 Packages Projects Releases 10 Wiki Activity

PortUtils class made internal #505

New Issue
Closed
opened 2025-12-29 15:25:34 +01:00 by adam · 5 comments
adam commented 2025-12-29 15:25:34 +01:00
Owner
Copy Link

Originally created by @antoniovalentini on GitHub (Apr 11, 2023).

Hello, I noticed that with v1.5.22 the PortUtils class has been marked as internal, but I don't see any reference in the CHANGELOG.

  1. Should it be treated as a breaking change?
  2. Is there any equivalent alternative we can use?

Thanks for your amazing work!

Antonio

Originally created by @antoniovalentini on GitHub (Apr 11, 2023). Hello, I noticed that with `v1.5.22` the `PortUtils` class has been [marked as internal](https://github.com/WireMock-Net/WireMock.Net/commit/651486f718f6c2e1a53d67f692f18192ec2bf487#diff-1eca73db0b0f849524e77b51fa0564ad052eba14c50e40013dbeafb493026917R12), but I don't see any reference in the [CHANGELOG](./CHANGELOG.md). 1. Should it be treated as a breaking change? 2. Is there any equivalent alternative we can use? Thanks for your amazing work! Antonio
adam added the question label 2025-12-29 15:25:34 +01:00
adam closed this issue 2025-12-29 15:25:35 +01:00
adam commented 2025-12-29 15:25:35 +01:00
Author
Owner
Copy Link

@StefH commented on GitHub (Apr 11, 2023):

@antoniovalentini
There was no specific reason for this, else then keeping as much as possible internal.

Do you need it?

@StefH commented on GitHub (Apr 11, 2023): @antoniovalentini There was no specific reason for this, else then keeping as much as possible internal. Do you need it?
adam commented 2025-12-29 15:25:36 +01:00
Author
Owner
Copy Link

@antoniovalentini commented on GitHub (Apr 11, 2023):

Do you need it?

No worries. The implementation is rather short and can be implemented directly. I just wanted to make sure I wasn't missing an alternative way.

Thanks again!

@antoniovalentini commented on GitHub (Apr 11, 2023): > Do you need it? No worries. The implementation is rather short and can be implemented directly. I just wanted to make sure I wasn't missing an alternative way. Thanks again!
adam commented 2025-12-29 15:25:36 +01:00
Author
Owner
Copy Link

@StefH commented on GitHub (Apr 11, 2023):

I can make it public again.

There is also another PR related to that

I'll take a look

@StefH commented on GitHub (Apr 11, 2023): I can make it public again. There is also another PR related to that I'll take a look
adam commented 2025-12-29 15:25:36 +01:00
Author
Owner
Copy Link

@StefH commented on GitHub (Apr 12, 2023):

In the next version this will be public again.

@StefH commented on GitHub (Apr 12, 2023): In the next version this will be public again.
adam commented 2025-12-29 15:25:36 +01:00
Author
Owner
Copy Link

@antoniovalentini commented on GitHub (Apr 12, 2023):

Wow! Thanks a lot 🙇

@antoniovalentini commented on GitHub (Apr 12, 2023): Wow! Thanks a lot 🙇
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
bug
doc
doc
duplicate
feature
feature
invalid
pull-request
Mirrored from GitHub Pull Request
 question
wontfix
No Label question
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/WireMock.Net-wiremock#505
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?