starred/WireMock.Net-wiremock
1
0
Fork 0
mirror of https://github.com/wiremock/WireMock.Net.git synced 2026-01-11 14:20:29 +01:00
Code Issues 32 Packages Projects Releases 10 Wiki Activity

Multiple headers with same name #48

New Issue
Closed
opened 2025-12-29 14:21:41 +01:00 by adam · 4 comments
adam commented 2025-12-29 14:21:41 +01:00
Owner
Copy Link

Originally created by @Dreamescaper on GitHub (Oct 27, 2017).

Originally assigned to: @StefH on GitHub.

Do I understand correct that currently it's not possible to set multiple headers with same name to ResponseMessage?
In particular, I'm interested in providing multiple Set-Cookie headers.
Is it possible to add such functionality? I could submit PR with changing Headers property from 'IDictionary<string, string>' to something like 'IDictionary<string, string[]>', but not sure how great is that, considering that it is public member.

Originally created by @Dreamescaper on GitHub (Oct 27, 2017). Originally assigned to: @StefH on GitHub. Do I understand correct that currently it's not possible to set multiple headers with same name to ResponseMessage? In particular, I'm interested in providing multiple Set-Cookie headers. Is it possible to add such functionality? I could submit PR with changing Headers property from 'IDictionary<string, string>' to something like 'IDictionary<string, string[]>', but not sure how great is that, considering that it is public member.
adam added the feature label 2025-12-29 14:21:41 +01:00
adam closed this issue 2025-12-29 14:21:41 +01:00
adam commented 2025-12-29 14:21:42 +01:00
Author
Owner
Copy Link

@StefH commented on GitHub (Oct 27, 2017):

First change will be:

IResponseBuilder WithHeader([NotNull] string name, params string[] values);

Also your idea is possible:

IResponseBuilder WithHeaders([NotNull] IDictionary<string,string[]> headers);

However, also the json parsing should be updated. I will take a look.

@StefH commented on GitHub (Oct 27, 2017): First change will be: ```c# IResponseBuilder WithHeader([NotNull] string name, params string[] values); ``` Also your idea is possible: ```c# IResponseBuilder WithHeaders([NotNull] IDictionary<string,string[]> headers); ``` However, also the json parsing should be updated. I will take a look.
adam commented 2025-12-29 14:21:42 +01:00
Author
Owner
Copy Link

@Dreamescaper commented on GitHub (Oct 27, 2017):

Added PR with simple implementation for that.

@Dreamescaper commented on GitHub (Oct 27, 2017): Added PR with simple implementation for that.
adam commented 2025-12-29 14:21:42 +01:00
Author
Owner
Copy Link

@StefH commented on GitHub (Oct 27, 2017):

Thanks.

I added the JSON part to your code. Please review.

And if it's ok, I can create a NuGet.

@StefH commented on GitHub (Oct 27, 2017): Thanks. I added the JSON part to your code. Please review. And if it's ok, I can create a NuGet.
adam commented 2025-12-29 14:21:43 +01:00
Author
Owner
Copy Link

@Dreamescaper commented on GitHub (Oct 28, 2017):

Great, thanks!

@Dreamescaper commented on GitHub (Oct 28, 2017): Great, thanks!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
bug
doc
doc
duplicate
feature
feature
invalid
pull-request
Mirrored from GitHub Pull Request
 question
wontfix
No Label feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/WireMock.Net-wiremock#48
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?