starred/WireMock.Net-wiremock
1
0
Fork 0
mirror of https://github.com/wiremock/WireMock.Net.git synced 2026-07-31 17:28:49 +02:00
Code Issues 32 Packages Projects Releases 10 Wiki Activity

Change "blacklist" and "whitelist" terms #285

New Issue
Closed
opened 2025-12-29 15:19:42 +01:00 by adam · 3 comments
adam commented 2025-12-29 15:19:42 +01:00
Owner
Copy Link
Copy Source

Originally created by @akamud on GitHub (Jul 18, 2020).

Originally assigned to: @StefH on GitHub.

Is your feature request related to a problem? Please describe.
These terms have proven not to be inclusive to all people in IT. A lot of big projects are already moving away from them. There are better terms that describe the intention of these lists more clearly too.

Describe the solution you'd like
A lot of repos are changing the "blacklist" term to "denylist" or "blocklist", and "whitelist" to "allowlist" or "passlist". Deny/Allow seems to be more common, though.

I know this would be a breaking change, so maybe a minor release marking these objects as Obsolete while providing the new Allow/Denylists could make this less traumatic for a possible future major release?

Originally created by @akamud on GitHub (Jul 18, 2020). Originally assigned to: @StefH on GitHub. **Is your feature request related to a problem? Please describe.** These terms have proven not to be inclusive to all people in IT. A lot of big projects are already moving away from them. There are better terms that describe the intention of these lists more clearly too. **Describe the solution you'd like** A lot of repos are changing the "blacklist" term to "denylist" or "blocklist", and "whitelist" to "allowlist" or "passlist". Deny/Allow seems to be more common, though. I know this would be a breaking change, so maybe a minor release marking these objects as `Obsolete` while providing the new Allow/Denylists could make this less traumatic for a possible future major release?
adam added the feature label 2025-12-29 15:19:42 +01:00
adam closed this issue 2025-12-29 15:19:42 +01:00
adam commented 2025-12-29 15:19:43 +01:00
Author
Owner
Copy Link
Copy Source

@StefH commented on GitHub (Jul 19, 2020):

In WireMock.Net, I have only used the following:
https://github.com/WireMock-Net/WireMock.Net/blob/master/src/WireMock.Net/Settings/IProxyAndRecordSettings.cs#L41

/// <summary>
/// Defines a list from headers which will excluded from the saved mappings.
/// </summary>
string[] BlackListedHeaders { get; set; }

/// <summary>
/// Defines a list of cookies which will excluded from the saved mappings.
/// </summary>
string[] BlackListedCookies { get; set; }

So I guess renaming it to:
ExcludedHeaders and ExcludedCookies would be fine.

@StefH commented on GitHub (Jul 19, 2020): In WireMock.Net, I have only used the following: https://github.com/WireMock-Net/WireMock.Net/blob/master/src/WireMock.Net/Settings/IProxyAndRecordSettings.cs#L41 ``` c# /// <summary> /// Defines a list from headers which will excluded from the saved mappings. /// </summary> string[] BlackListedHeaders { get; set; } /// <summary> /// Defines a list of cookies which will excluded from the saved mappings. /// </summary> string[] BlackListedCookies { get; set; } ``` So I guess renaming it to: `ExcludedHeaders` and `ExcludedCookies` would be fine.
adam commented 2025-12-29 15:19:43 +01:00
Author
Owner
Copy Link
Copy Source

@akamud commented on GitHub (Jul 19, 2020):

Seems fine to me, the new names are more explicit too. Other than that, I just found some references for Whitelist and Blacklist in infura.yaml, not sure what are those.

@akamud commented on GitHub (Jul 19, 2020): Seems fine to me, the new names are more explicit too. Other than that, I just found some references for Whitelist and Blacklist in `infura.yaml`, not sure what are those.
adam commented 2025-12-29 15:19:43 +01:00
Author
Owner
Copy Link
Copy Source

@StefH commented on GitHub (Jul 19, 2020):

Infura.yaml is just an third party example openapi yaml specification file.

@StefH commented on GitHub (Jul 19, 2020): Infura.yaml is just an third party example openapi yaml specification file.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
bug
doc
doc
duplicate
feature
feature
invalid
pull-request
Mirrored from GitHub Pull Request
 question
wontfix
No labels feature
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/WireMock.Net-wiremock#285