Feature: Please provide support for Bad responses. #212

@StefH commented on GitHub (Oct 22, 2019):

@grzegorz-wolszczak Can you please test this preview and report back your findings?

@StefH commented on GitHub (Oct 22, 2019): @grzegorz-wolszczak Can you please test this preview and report back your findings?

adam commented

@grzegorz-wolszczak commented on GitHub (Oct 22, 2019):

Hi Stef
Sorry for not responding sooner.
I really couldn't find time for testing.
I will try to do as soon as possible.

@grzegorz-wolszczak commented on GitHub (Oct 22, 2019): Hi Stef Sorry for not responding sooner. I really couldn't find time for testing. I will try to do as soon as possible.

adam commented

@grzegorz-wolszczak commented on GitHub (Oct 23, 2019):

How should I test new library ? What new Api was introduced to handle cases like:
MALFORMED_RESPONSE_CHUNK
RANDOM_DATA_THEN_CLOSE
CONNECTION_RESET_BY_PEER

I was trying to find some methods on IResponseBuilder interface but I did not see anything that would map to the responses I've described in my feature request. I tried to grep your git commit history by the issue number (#343) but also could not find any. In which commit (or commits) did you introduce changes for this issue? I will look into it and figure out the rest.

@grzegorz-wolszczak commented on GitHub (Oct 23, 2019): How should I test new library ? What new Api was introduced to handle cases like: MALFORMED_RESPONSE_CHUNK RANDOM_DATA_THEN_CLOSE CONNECTION_RESET_BY_PEER I was trying to find some methods on IResponseBuilder interface but I did not see anything that would map to the responses I've described in my feature request. I tried to grep your git commit history by the issue number (#343) but also could not find any. In which commit (or commits) did you introduce changes for this issue? I will look into it and figure out the rest.

adam commented

@StefH commented on GitHub (Oct 23, 2019):

1]
This NuGet package on the MyGet feed should implement this fix:
https://www.myget.org/feed/wiremock-net/package/nuget/WireMock.Net/1.0.32-ci-12002

2]
Or you can clone this project and switch to branch https://github.com/WireMock-Net/WireMock.Net/tree/WithFault

3a]
New API is like:
https://github.com/WireMock-Net/WireMock.Net/blob/WithFault/test/WireMock.Net.Tests/ResponseBuilders/ResponseWithWithFaultTests.cs

3b]
Or via JSON admin interface :

{
    "Guid": "a51b78ac-1300-4125-aa97-d48953deef77",
    "Priority": 0,
    "Request": {
        "Path": {
            "Matchers": [
                {
                    "Name": "WildcardMatcher",
                    "Pattern": "/fault",
                    "IgnoreCase": false
                }
            ]
        },
        "Body": {}
    },
    "Response": {
        "StatusCode": 200,
        "BodyAsJson": {
            "x": "x"
        },
        "Fault": { "Type": "RANDOM_DATA_THEN_CLOSE", "Percentage": 0.999999 },
        "UseTransformer": false,
        "Headers": {
            "Content-Type": "application/json"
        }
    }
}

@StefH commented on GitHub (Oct 23, 2019): 1] This NuGet package on the MyGet feed should implement this fix: https://www.myget.org/feed/wiremock-net/package/nuget/WireMock.Net/1.0.32-ci-12002 2] Or you can clone this project and switch to branch https://github.com/WireMock-Net/WireMock.Net/tree/WithFault 3a] New API is like: https://github.com/WireMock-Net/WireMock.Net/blob/WithFault/test/WireMock.Net.Tests/ResponseBuilders/ResponseWithWithFaultTests.cs 3b] Or via JSON admin interface : ``` js { "Guid": "a51b78ac-1300-4125-aa97-d48953deef77", "Priority": 0, "Request": { "Path": { "Matchers": [ { "Name": "WildcardMatcher", "Pattern": "/fault", "IgnoreCase": false } ] }, "Body": {} }, "Response": { "StatusCode": 200, "BodyAsJson": { "x": "x" }, "Fault": { "Type": "RANDOM_DATA_THEN_CLOSE", "Percentage": 0.999999 }, "UseTransformer": false, "Headers": { "Content-Type": "application/json" } } } ```

adam commented

@grzegorz-wolszczak commented on GitHub (Oct 23, 2019):

Ok, now i See what the problem was, I have chosen wrong nuget version.

So I've tested
EMPTY_RESPONSE, and RANDOM_DATA_THEN_CLOSE and it works good (tested with 'curl')

but for FaultType.MALFORMED_RESPONSE_CHUNK

when request GET

I got:
Status code: 500Internal Server Error

and body

{
    "Status": "{\"ClassName\":\"System.NullReferenceException\",\"Message\":\"Object reference not set to an instance of an object.\",\"Data\":null,\"InnerException\":null,\"HelpURL\":null,\"StackTraceString\":\"   at WireMock.Owin.Mappers.OwinResponseMapper.<MapAsync>d__6.MoveNext()\\r\\n--- End of stack trace from previous location where exception was thrown ---\\r\\n   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()\\r\\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\\r\\n   at WireMock.Owin.WireMockMiddleware.<InvokeInternal>d__7.MoveNext()\\r\\n--- End of stack trace from previous location where exception was thrown ---\\r\\n   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()\\r\\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\\r\\n   at WireMock.Owin.GlobalExceptionMiddleware.<InvokeInternal>d__7.MoveNext()\",\"RemoteStackTraceString\":null,\"RemoteStackIndex\":0,\"ExceptionMethod\":\"8\\nMoveNext\\nWireMock.Net, Version=1.0.32.0, Culture=neutral, PublicKeyToken=c8d65537854e1f03\\nWireMock.Owin.Mappers.OwinResponseMapper+<MapAsync>d__6\\nVoid MoveNext()\",\"HResult\":-2147467261,\"Source\":\"WireMock.Net\",\"WatsonBuckets\":null}"
}

I guess this is intended ?

Also what about 'most interesting' fault type , which is CONNECTION_RESET_BY_PEER ? There was no enum value for it.

Apart from that, everything is great :)

@grzegorz-wolszczak commented on GitHub (Oct 23, 2019): Ok, now i See what the problem was, I have chosen wrong nuget version. So I've tested EMPTY_RESPONSE, and RANDOM_DATA_THEN_CLOSE and it works good (tested with 'curl') but for FaultType.MALFORMED_RESPONSE_CHUNK when request GET I got: Status code: 500Internal Server Error and body ``` { "Status": "{\"ClassName\":\"System.NullReferenceException\",\"Message\":\"Object reference not set to an instance of an object.\",\"Data\":null,\"InnerException\":null,\"HelpURL\":null,\"StackTraceString\":\" at WireMock.Owin.Mappers.OwinResponseMapper.<MapAsync>d__6.MoveNext()\\r\\n--- End of stack trace from previous location where exception was thrown ---\\r\\n at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()\\r\\n at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\\r\\n at WireMock.Owin.WireMockMiddleware.<InvokeInternal>d__7.MoveNext()\\r\\n--- End of stack trace from previous location where exception was thrown ---\\r\\n at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()\\r\\n at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\\r\\n at WireMock.Owin.GlobalExceptionMiddleware.<InvokeInternal>d__7.MoveNext()\",\"RemoteStackTraceString\":null,\"RemoteStackIndex\":0,\"ExceptionMethod\":\"8\\nMoveNext\\nWireMock.Net, Version=1.0.32.0, Culture=neutral, PublicKeyToken=c8d65537854e1f03\\nWireMock.Owin.Mappers.OwinResponseMapper+<MapAsync>d__6\\nVoid MoveNext()\",\"HResult\":-2147467261,\"Source\":\"WireMock.Net\",\"WatsonBuckets\":null}" } ``` I guess this is intended ? Also what about 'most interesting' fault type , which is CONNECTION_RESET_BY_PEER ? There was no enum value for it. Apart from that, everything is great :)

adam commented

@StefH commented on GitHub (Oct 23, 2019):

About malformed response , this should not throw a 500.
Can you provide your code or mapping json?

@StefH commented on GitHub (Oct 23, 2019): About malformed response , this should not throw a 500. Can you provide your code or mapping json?

adam commented

@StefH commented on GitHub (Oct 24, 2019):

I found the issue. Please try MyGet : WireMock.Net.1.0.32-ci-12060

@StefH commented on GitHub (Oct 24, 2019): I found the issue. Please try MyGet : WireMock.Net.1.0.32-ci-12060

adam commented

@grzegorz-wolszczak commented on GitHub (Oct 24, 2019):

The code I used was (simplified version I found on your's project wiki):

using System;
using Newtonsoft.Json;

using WireMock.RequestBuilders;
using WireMock.ResponseBuilders;
using WireMock.Server;

namespace TestingWireMock
{
    class Program
    {
        static void Main(string[] args)
        {
            int port;
            if (args.Length == 0 || !int.TryParse(args[0], out port))
                port = 18080;

            var server = FluentMockServer.Start(port);
            Console.WriteLine("FluentMockServer running at {0}", string.Join(",", server.Ports));
            
            server
                .Given(Request.Create().WithPath(u => u.Contains("x")).UsingGet())
                .RespondWith(Response.Create()
                    .WithStatusCode(200)
                    .WithHeader("Content-Type", "application/json")
                    .WithBody(@"{ ""result"": ""/x with FUNC 200""}"));

            server
                .Given(Request.Create().WithPath("/*").UsingGet())
                .RespondWith(Response.Create().WithFault(FaultType.MALFORMED_RESPONSE_CHUNK));
                
            
            Console.WriteLine("Press any key to stop the server");
            Console.ReadKey();

            Console.WriteLine("Displaying all requests");
            var allRequests = server.LogEntries;
            Console.WriteLine(JsonConvert.SerializeObject(allRequests, Formatting.Indented));

            Console.WriteLine("Press any key to quit");
            Console.ReadKey();
        }
    }
}

I've used nuget version: WireMock.Net.1.0.32-ci-12002.nupkg

@grzegorz-wolszczak commented on GitHub (Oct 24, 2019): The code I used was (simplified version I found on your's project wiki): ``` c# using System; using Newtonsoft.Json; using WireMock.RequestBuilders; using WireMock.ResponseBuilders; using WireMock.Server; namespace TestingWireMock { class Program { static void Main(string[] args) { int port; if (args.Length == 0 || !int.TryParse(args[0], out port)) port = 18080; var server = FluentMockServer.Start(port); Console.WriteLine("FluentMockServer running at {0}", string.Join(",", server.Ports)); server .Given(Request.Create().WithPath(u => u.Contains("x")).UsingGet()) .RespondWith(Response.Create() .WithStatusCode(200) .WithHeader("Content-Type", "application/json") .WithBody(@"{ ""result"": ""/x with FUNC 200""}")); server .Given(Request.Create().WithPath("/*").UsingGet()) .RespondWith(Response.Create().WithFault(FaultType.MALFORMED_RESPONSE_CHUNK)); Console.WriteLine("Press any key to stop the server"); Console.ReadKey(); Console.WriteLine("Displaying all requests"); var allRequests = server.LogEntries; Console.WriteLine(JsonConvert.SerializeObject(allRequests, Formatting.Indented)); Console.WriteLine("Press any key to quit"); Console.ReadKey(); } } } ``` I've used nuget version: WireMock.Net.1.0.32-ci-12002.nupkg

adam commented

@StefH commented on GitHub (Oct 24, 2019):

Thanks.
Can you retry WireMock.Net.1.0.32-ci-12060?

@StefH commented on GitHub (Oct 24, 2019): Thanks. Can you retry WireMock.Net.1.0.32-ci-12060?

adam commented

@grzegorz-wolszczak commented on GitHub (Oct 24, 2019):

WireMock.Net.1.0.32-ci-12060 works.
Although I could not spot the difference between MALFORMED_RESPONSE_CHUNK and RANDOM_DATA_THEN_CLOSE.
Both respond with 200 OK and some random body.

From what I can understand in http://wiremock.org/docs/simulating-faults/ in 'Bad responses' section.
RANDOM_DATA_THEN_CLOSE does not send 200 OK header (it does not send any header at all)

@grzegorz-wolszczak commented on GitHub (Oct 24, 2019): WireMock.Net.1.0.32-ci-12060 works. Although I could not spot the difference between MALFORMED_RESPONSE_CHUNK and RANDOM_DATA_THEN_CLOSE. Both respond with 200 OK and some random body. From what I can understand in http://wiremock.org/docs/simulating-faults/ in 'Bad responses' section. RANDOM_DATA_THEN_CLOSE does not send 200 OK header (it does not send any header at all)

adam commented

@StefH commented on GitHub (Oct 24, 2019):

1] There is a difference.
In case you have a body defined, the MALFORMED_RESPONSE_CHUNK returns half of that body and the rest is random.

2] RANDOM_DATA_THEN_CLOSE should not write any header. However, maybe the default header is 200.
The other two errors will take your original defined header.

@StefH commented on GitHub (Oct 24, 2019): 1] There is a difference. In case you have a body defined, the MALFORMED_RESPONSE_CHUNK returns half of that body and the rest is random. 2] RANDOM_DATA_THEN_CLOSE should not write any header. However, maybe the default header is 200. The other two errors will take your original defined header.

adam commented