starred/WireMock.Net-wiremock
1
0
Fork 0
mirror of https://github.com/wiremock/WireMock.Net.git synced 2026-09-04 17:07:14 +02:00
Code Issues 32 Packages Projects Releases 10 Wiki Activity

[PR #1317] [MERGED] Set description when converting MappingModel to IRespondWithAProvider #1335

New Issue
Closed
opened 2025-12-29 16:19:45 +01:00 by adam · 0 comments
adam commented 2025-12-29 16:19:45 +01:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/wiremock/WireMock.Net/pull/1317
Author: @BodrickLight
Created: 6/12/2025
Status: ✅ Merged
Merged: 6/14/2025
Merged by: @StefH

Base: master ← Head: dl/description

📝 Commits (1)

  • 60545c4 Set description when converting MappingModel to IRespondWithAProvider

📊 Changes

2 files changed (+11 additions, -2 deletions)

View changed files

📝 src/WireMock.Net.Minimal/Server/WireMockServer.ConvertMapping.cs (+5 -0)
📝 test/WireMock.Net.Tests/AdminApi/WireMockAdminApiTests.PostMappings.cs (+6 -2)

📄 Description

Adding a mapping with a description to WireMockServer.WithMapping did not include the description to the resulting IRespondWithAProvider, which means that calling WireMockServer.SavePact does not populate the description in the contract file.

This PR includes the description when mapping from MappingModel to IRespondWithAProvider.

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/wiremock/WireMock.Net/pull/1317 **Author:** [@BodrickLight](https://github.com/BodrickLight) **Created:** 6/12/2025 **Status:** ✅ Merged **Merged:** 6/14/2025 **Merged by:** [@StefH](https://github.com/StefH) **Base:** `master` ← **Head:** `dl/description` --- ### 📝 Commits (1) - [`60545c4`](https://github.com/wiremock/WireMock.Net/commit/60545c4d62a0dd96c732ffe9fad586d3498cb8fd) Set description when converting MappingModel to IRespondWithAProvider ### 📊 Changes **2 files changed** (+11 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/WireMock.Net.Minimal/Server/WireMockServer.ConvertMapping.cs` (+5 -0) 📝 `test/WireMock.Net.Tests/AdminApi/WireMockAdminApiTests.PostMappings.cs` (+6 -2) </details> ### 📄 Description Adding a mapping with a description to `WireMockServer.WithMapping` did not include the description to the resulting `IRespondWithAProvider`, which means that calling `WireMockServer.SavePact` does not populate the description in the contract file. This PR includes the description when mapping from `MappingModel` to `IRespondWithAProvider`. ## Submitter checklist - [ ] Recommended: Join [WireMock Slack](https://slack.wiremock.org/) to get any help in `#help-contributing` or a project-specific channel like `#wiremock-java` - [x] The PR request is well described and justified, including the body and the references - [x] The PR title represents the desired changelog entry - [x] The repository's code style is followed (see the contributing guide) - [x] Test coverage that demonstrates that the change works as expected - [x] For new features, there's necessary documentation in this pull request or in a subsequent PR to [wiremock.org](https://github.com/wiremock/wiremock.org) <!-- Put an `x` into the [ ] to show you have filled the information. The template comes from https://github.com/wiremock/.github/blob/main/.github/pull_request_template.md You can override it by creating .github/pull_request_template.md in your own repository --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 16:19:45 +01:00
adam closed this issue 2025-12-29 16:19:46 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
bug
doc
doc
duplicate
feature
feature
invalid
pull-request
Mirrored from GitHub Pull Request
 question
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/WireMock.Net-wiremock#1335