Write logging in case a Matcher throws an exception (#986)

* ThrowException

* ...

* .

* ...

* b

* fix test

* ...

* .

* sonar

* ft

* .

* fix tst
This commit is contained in:
Stef Heyenrath
2023-08-21 20:07:46 +02:00
committed by GitHub
parent 09a302baf2
commit 93c87845c2
88 changed files with 1266 additions and 1244 deletions

View File

@@ -88,11 +88,11 @@ public class RequestMessageCookieMatcher : IRequestMatcher
/// <inheritdoc />
public double GetMatchingScore(IRequestMessage requestMessage, IRequestMatchResult requestMatchResult)
{
double score = IsMatch(requestMessage);
return requestMatchResult.AddScore(GetType(), score);
var (score, exception) = GetMatchResult(requestMessage).Expand();
return requestMatchResult.AddScore(GetType(), score, exception);
}
private double IsMatch(IRequestMessage requestMessage)
private MatchResult GetMatchResult(IRequestMessage requestMessage)
{
if (requestMessage.Cookies == null)
{
@@ -109,7 +109,7 @@ public class RequestMessageCookieMatcher : IRequestMatcher
if (Matchers == null)
{
return MatchScores.Mismatch;
return default;
}
if (!cookies.ContainsKey(Name))
@@ -117,7 +117,6 @@ public class RequestMessageCookieMatcher : IRequestMatcher
return MatchBehaviourHelper.Convert(_matchBehaviour, MatchScores.Mismatch);
}
string value = cookies[Name];
return Matchers.Max(m => m.IsMatch(value));
return Matchers.Max(m => m.IsMatch(cookies[Name]));
}
}