From 0809c1888f8b12b2f25956ee1cf0cf2cd0ffa75b Mon Sep 17 00:00:00 2001 From: Stef Heyenrath Date: Wed, 19 Aug 2026 19:15:03 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --- src/WireMock.Net.Shared/Matchers/MatchScores.cs | 1 - .../Abstractions/WireMockListTests.cs | 5 +++-- .../Matchers/FormUrlEncodedMatcherTests.cs | 4 ++-- .../WireMockServerTests.WithBody.cs | 12 +++++++----- 4 files changed, 12 insertions(+), 10 deletions(-) diff --git a/src/WireMock.Net.Shared/Matchers/MatchScores.cs b/src/WireMock.Net.Shared/Matchers/MatchScores.cs index 83ee708a..3db47cec 100644 --- a/src/WireMock.Net.Shared/Matchers/MatchScores.cs +++ b/src/WireMock.Net.Shared/Matchers/MatchScores.cs @@ -96,7 +96,6 @@ public static class MatchScores } // For each value, how well was it matched by its best matcher? - var rowRange = Enumerable.Range(0, matchers.Length); var rowScore = matchOperator == MatchOperator.And ? matrix.Average(row => row.Max()) : matrix.Max(row => row.Max()); // For each matcher, how well was it satisfied by its best value? diff --git a/test/WireMock.Net.Tests/Abstractions/WireMockListTests.cs b/test/WireMock.Net.Tests/Abstractions/WireMockListTests.cs index 7a93a6cb..a71682ca 100644 --- a/test/WireMock.Net.Tests/Abstractions/WireMockListTests.cs +++ b/test/WireMock.Net.Tests/Abstractions/WireMockListTests.cs @@ -554,9 +554,10 @@ public class WireMockListTests { // Arrange var list = new WireMockList("a", "b"); + var sameReference = list; // Act & Assert - list.Equals(list).Should().BeTrue(); + list.Equals(sameReference).Should().BeTrue(); } [Fact] @@ -566,7 +567,7 @@ public class WireMockListTests var list = new WireMockList("a"); // Act & Assert - list.Equals(null).Should().BeFalse(); + list.Should().NotBeNull(); } [Fact] diff --git a/test/WireMock.Net.Tests/Matchers/FormUrlEncodedMatcherTests.cs b/test/WireMock.Net.Tests/Matchers/FormUrlEncodedMatcherTests.cs index 9512b2f1..e4cfad9c 100644 --- a/test/WireMock.Net.Tests/Matchers/FormUrlEncodedMatcherTests.cs +++ b/test/WireMock.Net.Tests/Matchers/FormUrlEncodedMatcherTests.cs @@ -169,7 +169,7 @@ public class FormUrlEncodedMatcherTest } [Fact] - public async Task FormUrlEncodedMatcher_IsMatch_And_MatchAllProperties_Test_1() + public async Task FormUrlEncodedMatcher_IsMatch_And_MatchAllProperties_MissingRequiredKey_ShouldNotMatch() { // Arrange var content = new FormUrlEncodedContent( @@ -191,7 +191,7 @@ public class FormUrlEncodedMatcherTest } [Fact] - public async Task FormUrlEncodedMatcher_IsMatch_And_MatchAllProperties_Test_2() + public async Task FormUrlEncodedMatcher_IsMatch_And_MatchAllProperties_ConflictingEmailPatterns_ShouldNotMatch() { // Arrange var content = new FormUrlEncodedContent( diff --git a/test/WireMock.Net.Tests/WireMockServerTests.WithBody.cs b/test/WireMock.Net.Tests/WireMockServerTests.WithBody.cs index ec35df6c..ebc01e22 100644 --- a/test/WireMock.Net.Tests/WireMockServerTests.WithBody.cs +++ b/test/WireMock.Net.Tests/WireMockServerTests.WithBody.cs @@ -355,8 +355,9 @@ public partial class WireMockServerTests ); // Act - var content = new FormUrlEncodedContent([new KeyValuePair("key1", "value1")]); - var response = await new HttpClient() + using var content = new FormUrlEncodedContent([new KeyValuePair("key1", "value1")]); + using var httpClient = new HttpClient(); + var response = await httpClient .PostAsync($"{server.Url}/foo", content, _ct); // Assert @@ -374,15 +375,16 @@ public partial class WireMockServerTests Request.Create() .UsingPost() .WithPath("/foo") - .WithBody((IDictionary>? values) => values != null && values["key1"] == "value1") + .WithBody((IDictionary>? values) => values != null && values.TryGetValue("key1", out var v) && v == "value1") ) .RespondWith( Response.Create() ); // Act - var content = new FormUrlEncodedContent([new KeyValuePair("key1", "value1")]); - var response = await new HttpClient() + using var content = new FormUrlEncodedContent([new KeyValuePair("key1", "value1")]); + using var httpClient = new HttpClient(); + var response = await httpClient .PostAsync($"{server.Url}/foo", content, _ct); // Assert