mirror of
https://github.com/eitchtee/WYGIWYH.git
synced 2026-09-09 19:31:47 +02:00
Herculino Trotta
e2f26b3629
The rules endpoints were one instance of a pattern repeated across every
SharedObject-backed app. Route the rest through the same helper.
DCA entries were the worst case and are strictly wider than the reported
rules bug: DCAEntry has an unscoped default manager, so filtering by
strategy__id alone reached entries on strategies the caller could not see
at all. No public or shared strategy was needed -- only a guessable
integer. strategy_entry_add/edit/delete now resolve through the parent
strategy with via="strategy".
Every SharedObject delete view carried an inverted condition:
if obj.owner != request.user and request.user in obj.shared_with.all():
obj.shared_with.remove(request.user)
else:
obj.delete()
An object its owner had made public matched neither branch's intent and
fell through to delete(), so any authenticated user could destroy it.
Confirmed reachable for accounts, account groups, categories, tags,
entities and DCA strategies. The owner now deletes, a shared user revokes
only their own access, and anyone else gets a 403.
The API viewsets had no object-level check at all. DjangoModelPermissions
gated them shut for ordinary users, who hold no model permissions, so this
was not reachable in a default install -- but the check belongs there
regardless, and a user granted change_account in the admin could write any
visible account. SharedObjectPermission adds it for the SharedObject
viewsets, leaving reads to SharedObjectManager.
account_toggle_untracked only flips the calling user's own row in the
untracked_by m2m, so it takes READ rather than EDIT.
Refs GHSA-83g9-vjqf-2j5q
83 lines
2.6 KiB
Python
83 lines
2.6 KiB
Python
from drf_spectacular.utils import extend_schema, extend_schema_view
|
|
from rest_framework import viewsets
|
|
from rest_framework.decorators import action
|
|
from rest_framework.permissions import IsAuthenticated
|
|
from rest_framework.response import Response
|
|
|
|
from apps.accounts.models import AccountGroup, Account
|
|
from apps.accounts.services import get_account_balance
|
|
from apps.api.permissions import SHARED_OBJECT_PERMISSIONS
|
|
from apps.api.serializers import (
|
|
AccountGroupSerializer,
|
|
AccountSerializer,
|
|
AccountBalanceSerializer,
|
|
)
|
|
|
|
|
|
class AccountGroupViewSet(viewsets.ModelViewSet):
|
|
"""ViewSet for managing account groups."""
|
|
|
|
permission_classes = SHARED_OBJECT_PERMISSIONS
|
|
queryset = AccountGroup.objects.all()
|
|
serializer_class = AccountGroupSerializer
|
|
filterset_fields = {
|
|
"name": ["exact", "icontains"],
|
|
"owner": ["exact"],
|
|
}
|
|
search_fields = ["name"]
|
|
ordering_fields = "__all__"
|
|
ordering = ["id"]
|
|
|
|
def get_queryset(self):
|
|
return AccountGroup.objects.all()
|
|
|
|
|
|
@extend_schema_view(
|
|
balance=extend_schema(
|
|
summary="Get account balance",
|
|
description="Returns the current and projected balance for the account, along with currency data.",
|
|
responses={200: AccountBalanceSerializer},
|
|
),
|
|
)
|
|
class AccountViewSet(viewsets.ModelViewSet):
|
|
"""ViewSet for managing accounts."""
|
|
|
|
permission_classes = SHARED_OBJECT_PERMISSIONS
|
|
queryset = Account.objects.all()
|
|
serializer_class = AccountSerializer
|
|
filterset_fields = {
|
|
"name": ["exact", "icontains"],
|
|
"group": ["exact", "isnull"],
|
|
"currency": ["exact"],
|
|
"exchange_currency": ["exact", "isnull"],
|
|
"is_asset": ["exact"],
|
|
"is_archived": ["exact"],
|
|
"owner": ["exact"],
|
|
}
|
|
search_fields = ["name"]
|
|
ordering_fields = "__all__"
|
|
ordering = ["id"]
|
|
|
|
def get_queryset(self):
|
|
return Account.objects.all().select_related(
|
|
"group", "currency", "exchange_currency"
|
|
)
|
|
|
|
@action(detail=True, methods=["get"], permission_classes=[IsAuthenticated])
|
|
def balance(self, request, pk=None):
|
|
"""Get current and projected balance for an account."""
|
|
account = self.get_object()
|
|
|
|
current_balance = get_account_balance(account, paid_only=True)
|
|
projected_balance = get_account_balance(account, paid_only=False)
|
|
|
|
serializer = AccountBalanceSerializer(
|
|
{
|
|
"current_balance": current_balance,
|
|
"projected_balance": projected_balance,
|
|
"currency": account.currency,
|
|
}
|
|
)
|
|
|
|
return Response(serializer.data)
|