mirror of
https://github.com/eitchtee/WYGIWYH.git
synced 2026-11-13 12:23:44 +01:00
Asish Kumar
6cf8cbf786
Import uploads were always written to /usr/src/app/temp, presets were read from /usr/src/app/import_presets and the caches lived in /var/tmp, so WYGIWYH only worked from the Docker image's layout. Running it as a systemd service with a strict sandbox, or on an immutable distro like NixOS, needs these folders to follow the app or be configurable. - Presets are read from IMPORT_PRESETS_ROOT, the import_presets folder next to the app. - Uploads wait in IMPORT_TEMP_ROOT, the temp folder next to the app by default, and movable with the IMPORT_TEMP_ROOT env var. The web views, the API and the import service all use it. - The file-based caches live under CACHE_ROOT, /var/tmp by default, and movable with the CACHE_ROOT env var. In the Docker image the app sits in /usr/src/app, so every default resolves to the same folder as before. The import service checked that a file was inside the temp folder with a plain string prefix, which also accepted sibling folders such as /usr/src/app/temp-other. It now compares paths. CI no longer needs to create /usr/src/app before running the tests. Fixes #472
311 lines
8.4 KiB
Python
311 lines
8.4 KiB
Python
import shutil
|
|
|
|
from django.conf import settings
|
|
from django.contrib import messages
|
|
from django.contrib.auth.decorators import login_required
|
|
from django.core.exceptions import PermissionDenied
|
|
from django.core.files.storage import FileSystemStorage
|
|
from django.http import HttpResponse
|
|
from django.shortcuts import render, get_object_or_404
|
|
from django.utils.translation import gettext_lazy as _
|
|
from django.views.decorators.http import require_http_methods
|
|
|
|
from apps.common.decorators.htmx import only_htmx
|
|
from apps.common.forms import SharedObjectForm
|
|
from apps.common.functions.permissions import (
|
|
EDIT,
|
|
READ,
|
|
get_shared_object_or_error,
|
|
)
|
|
from apps.common.models import SharedObject
|
|
from apps.import_app.forms import ImportRunFileUploadForm, ImportProfileForm
|
|
from apps.import_app.models import ImportRun, ImportProfile
|
|
from apps.import_app.services import PresetService
|
|
from apps.import_app.tasks import process_import
|
|
from apps.common.decorators.demo import disabled_on_demo
|
|
|
|
|
|
@login_required
|
|
@disabled_on_demo
|
|
@require_http_methods(["GET"])
|
|
def import_presets_list(request):
|
|
presets = PresetService.get_all_presets()
|
|
return render(
|
|
request,
|
|
"import_app/fragments/profiles/list_presets.html",
|
|
{"presets": presets},
|
|
)
|
|
|
|
|
|
@login_required
|
|
@disabled_on_demo
|
|
@require_http_methods(["GET", "POST"])
|
|
def import_profile_index(request):
|
|
return render(
|
|
request,
|
|
"import_app/pages/profiles_index.html",
|
|
)
|
|
|
|
|
|
@only_htmx
|
|
@login_required
|
|
@disabled_on_demo
|
|
@require_http_methods(["GET", "POST"])
|
|
def import_profile_list(request):
|
|
profiles = ImportProfile.objects.all()
|
|
|
|
return render(
|
|
request,
|
|
"import_app/fragments/profiles/list.html",
|
|
{"profiles": profiles},
|
|
)
|
|
|
|
|
|
@only_htmx
|
|
@login_required
|
|
@disabled_on_demo
|
|
@require_http_methods(["GET", "POST"])
|
|
def import_profile_add(request):
|
|
message = request.POST.get("message", None)
|
|
|
|
if request.method == "POST" and request.POST.get("submit"):
|
|
form = ImportProfileForm(request.POST)
|
|
|
|
if form.is_valid():
|
|
form.save()
|
|
messages.success(request, _("Import Profile added successfully"))
|
|
|
|
return HttpResponse(
|
|
status=204,
|
|
headers={
|
|
"HX-Trigger": "updated, hide_offcanvas",
|
|
},
|
|
)
|
|
else:
|
|
form = ImportProfileForm(
|
|
initial={
|
|
"name": request.POST.get("name"),
|
|
"version": int(request.POST.get("version", 1)),
|
|
"yaml_config": request.POST.get("yaml_config"),
|
|
}
|
|
)
|
|
|
|
return render(
|
|
request,
|
|
"import_app/fragments/profiles/add.html",
|
|
{"form": form, "message": message},
|
|
)
|
|
|
|
|
|
@only_htmx
|
|
@login_required
|
|
@disabled_on_demo
|
|
@require_http_methods(["GET", "POST"])
|
|
def import_profile_edit(request, profile_id):
|
|
profile = get_shared_object_or_error(
|
|
ImportProfile, request, id=profile_id, level=EDIT
|
|
)
|
|
|
|
if request.method == "POST":
|
|
form = ImportProfileForm(request.POST, instance=profile)
|
|
|
|
if form.is_valid():
|
|
form.save()
|
|
messages.success(request, _("Import Profile update successfully"))
|
|
|
|
return HttpResponse(
|
|
status=204,
|
|
headers={
|
|
"HX-Trigger": "updated, hide_offcanvas",
|
|
},
|
|
)
|
|
else:
|
|
form = ImportProfileForm(instance=profile)
|
|
|
|
return render(
|
|
request,
|
|
"import_app/fragments/profiles/edit.html",
|
|
{"form": form, "profile": profile},
|
|
)
|
|
|
|
|
|
@only_htmx
|
|
@login_required
|
|
@disabled_on_demo
|
|
@require_http_methods(["DELETE"])
|
|
def import_profile_delete(request, profile_id):
|
|
profile = get_shared_object_or_error(
|
|
ImportProfile, request, id=profile_id, level=READ
|
|
)
|
|
|
|
if profile.is_editable_by(request.user):
|
|
profile.delete()
|
|
messages.success(request, _("Import Profile deleted successfully"))
|
|
elif profile.shared_with.filter(pk=request.user.pk).exists():
|
|
# Someone else's profile shared with us: we can drop our own access to
|
|
# it, but never delete it.
|
|
profile.shared_with.remove(request.user)
|
|
messages.success(request, _("Item no longer shared with you"))
|
|
else:
|
|
raise PermissionDenied
|
|
|
|
return HttpResponse(
|
|
status=204,
|
|
headers={
|
|
"HX-Trigger": "updated",
|
|
},
|
|
)
|
|
|
|
|
|
@only_htmx
|
|
@login_required
|
|
@disabled_on_demo
|
|
@require_http_methods(["GET", "POST"])
|
|
def import_runs_list(request, profile_id):
|
|
profile = get_shared_object_or_error(
|
|
ImportProfile, request, id=profile_id, level=READ
|
|
)
|
|
|
|
# ImportRun.objects only returns the requesting user's runs, so a shared
|
|
# profile does not expose the runs other users made with it.
|
|
runs = ImportRun.objects.filter(profile=profile).order_by("-id")
|
|
|
|
return render(
|
|
request,
|
|
"import_app/fragments/runs/list.html",
|
|
{"profile": profile, "runs": runs},
|
|
)
|
|
|
|
|
|
@only_htmx
|
|
@login_required
|
|
@disabled_on_demo
|
|
@require_http_methods(["GET", "POST"])
|
|
def import_run_log(request, profile_id, run_id):
|
|
run = get_object_or_404(ImportRun, profile__id=profile_id, id=run_id)
|
|
|
|
return render(
|
|
request,
|
|
"import_app/fragments/runs/log.html",
|
|
{"run": run},
|
|
)
|
|
|
|
|
|
@only_htmx
|
|
@login_required
|
|
@disabled_on_demo
|
|
@require_http_methods(["GET", "POST"])
|
|
def import_run_add(request, profile_id):
|
|
profile = get_shared_object_or_error(
|
|
ImportProfile, request, id=profile_id, level=READ
|
|
)
|
|
|
|
if request.method == "POST":
|
|
form = ImportRunFileUploadForm(request.POST, request.FILES)
|
|
|
|
if form.is_valid():
|
|
uploaded_file = request.FILES["file"]
|
|
fs = FileSystemStorage(location=settings.IMPORT_TEMP_ROOT)
|
|
filename = fs.save(uploaded_file.name, uploaded_file)
|
|
file_path = fs.path(filename)
|
|
|
|
import_run = ImportRun.objects.create(
|
|
profile=profile, file_name=filename, owner=request.user
|
|
)
|
|
|
|
# Defer the procrastinate task
|
|
process_import.defer(
|
|
import_run_id=import_run.id,
|
|
file_path=file_path,
|
|
user_id=request.user.id,
|
|
)
|
|
|
|
messages.success(request, _("Import Run queued successfully"))
|
|
|
|
return HttpResponse(
|
|
status=204,
|
|
headers={
|
|
"HX-Trigger": "updated, hide_offcanvas",
|
|
},
|
|
)
|
|
else:
|
|
form = ImportRunFileUploadForm()
|
|
|
|
return render(
|
|
request,
|
|
"import_app/fragments/runs/add.html",
|
|
{"form": form, "profile": profile},
|
|
)
|
|
|
|
|
|
@only_htmx
|
|
@login_required
|
|
@disabled_on_demo
|
|
@require_http_methods(["DELETE"])
|
|
def import_run_delete(request, profile_id, run_id):
|
|
run = get_object_or_404(ImportRun, profile__id=profile_id, id=run_id)
|
|
|
|
run.delete()
|
|
|
|
messages.success(request, _("Run deleted successfully"))
|
|
|
|
return HttpResponse(
|
|
status=204,
|
|
headers={
|
|
"HX-Trigger": "updated",
|
|
},
|
|
)
|
|
|
|
|
|
@only_htmx
|
|
@login_required
|
|
@disabled_on_demo
|
|
@require_http_methods(["GET"])
|
|
def import_profile_take_ownership(request, profile_id):
|
|
profile = get_shared_object_or_error(
|
|
ImportProfile, request, id=profile_id, level=EDIT
|
|
)
|
|
|
|
if not profile.owner:
|
|
profile.owner = request.user
|
|
profile.visibility = SharedObject.Visibility.private
|
|
profile.save()
|
|
|
|
messages.success(request, _("Ownership taken successfully"))
|
|
|
|
return HttpResponse(
|
|
status=204,
|
|
headers={
|
|
"HX-Trigger": "updated, hide_offcanvas",
|
|
},
|
|
)
|
|
|
|
|
|
@only_htmx
|
|
@login_required
|
|
@disabled_on_demo
|
|
@require_http_methods(["GET", "POST"])
|
|
def import_profile_share(request, pk):
|
|
obj = get_shared_object_or_error(ImportProfile, request, id=pk, level=EDIT)
|
|
|
|
if request.method == "POST":
|
|
form = SharedObjectForm(request.POST, instance=obj, user=request.user)
|
|
if form.is_valid():
|
|
form.save()
|
|
messages.success(request, _("Configuration saved successfully"))
|
|
|
|
return HttpResponse(
|
|
status=204,
|
|
headers={
|
|
"HX-Trigger": "updated, hide_offcanvas",
|
|
},
|
|
)
|
|
else:
|
|
form = SharedObjectForm(instance=obj, user=request.user)
|
|
|
|
return render(
|
|
request,
|
|
"import_app/fragments/profiles/share.html",
|
|
{"form": form, "object": obj},
|
|
)
|