starred/WYGIWYH
1
0
Fork 0
mirror of https://github.com/eitchtee/WYGIWYH.git synced 2026-01-11 11:50:27 +01:00
Code Issues 14 Packages Projects Releases 10 Wiki Activity

Hardcoded paths #91

New Issue
Open
opened 2025-12-28 23:26:00 +01:00 by adam · 3 comments
adam commented 2025-12-28 23:26:00 +01:00
Owner
Copy Link

Originally created by @icovada on GitHub (Dec 28, 2025).

There are many hardcoded paths that force specific folders to be used.
This can cause issues if used as a systemd service with strict permissions or in immutable distros like nixos

Originally created by @icovada on GitHub (Dec 28, 2025). There are many hardcoded paths that force specific folders to be used. This can cause issues if used as a systemd service with strict permissions or in immutable distros like nixos
adam commented 2025-12-28 23:26:01 +01:00
Author
Owner
Copy Link

@eitchtee commented on GitHub (Dec 28, 2025):

Hey @icovada

Do you have any examples of this? Are you talking about things like /tmp/migrations_complete and /etc/supervisor/conf.d/supervisord.conf or something else?

@eitchtee commented on GitHub (Dec 28, 2025): Hey @icovada Do you have any examples of this? Are you talking about things like `/tmp/migrations_complete` and `/etc/supervisor/conf.d/supervisord.conf` or something else?
adam commented 2025-12-28 23:26:02 +01:00
Author
Owner
Copy Link

@icovada commented on GitHub (Dec 28, 2025):

I'm talking about things like

63ce57a315/app/WYGIWYH/settings.py (L327)

63ce57a315/app/WYGIWYH/settings.py (L24)

63ce57a315/app/apps/import_app/services/presets.py (L8)

Everything works fine in Docker, but in other cases one might not want to use those paths and instead contain everything inside a single application folder

@icovada commented on GitHub (Dec 28, 2025): I'm talking about things like https://github.com/eitchtee/WYGIWYH/blob/63ce57a315eba694e7dc0b43e9cfec7c4db182bc/app/WYGIWYH/settings.py#L327 https://github.com/eitchtee/WYGIWYH/blob/63ce57a315eba694e7dc0b43e9cfec7c4db182bc/app/WYGIWYH/settings.py#L24 https://github.com/eitchtee/WYGIWYH/blob/63ce57a315eba694e7dc0b43e9cfec7c4db182bc/app/apps/import_app/services/presets.py#L8 Everything works fine in Docker, but in other cases one might not want to use those paths and instead contain everything inside a single application folder
adam commented 2025-12-28 23:26:02 +01:00
Author
Owner
Copy Link

@eitchtee commented on GitHub (Dec 28, 2025):

I see. Makes sense.

  • /usr/src/app/import_presets could be a relative path, since it's just accessing the import_presets folder inside the application folder
  • BASE_DIR and ROOT_DIR is technically only traversing the file path from settings.py to the ./app/ folder, so I don't think it will cause issues
  • The cache LOCATION could be defined with an env var? It doesn't particularly matter where it is located, as long as it is accessible

Let me know if you need any help on this.

@eitchtee commented on GitHub (Dec 28, 2025): I see. Makes sense. - `/usr/src/app/import_presets` could be a relative path, since it's just accessing the import_presets folder inside the application folder - BASE_DIR and ROOT_DIR is technically only traversing the file path from settings.py to the ./app/ folder, so I don't think it will cause issues - The cache LOCATION could be defined with an env var? It doesn't particularly matter where it is located, as long as it is accessible Let me know if you need any help on this.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
bug
documentation
enhancement
help wanted
pull-request
Mirrored from GitHub Pull Request
 question
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/WYGIWYH#91
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?