[PR #365] [MERGED] fix(app): pwa title colour #384

New Issue

adam · 2025-12-29T00:20:06+01:00

adam commented

2025-12-29 00:20:06 +01:00

📋 Pull Request Information

Original PR: https://github.com/eitchtee/WYGIWYH/pull/365
Author: @samuelthng
Created: 9/9/2025
Status: ✅ Merged
Merged: 9/9/2025
Merged by: @eitchtee

Base: main ← Head: patch-1

📝 Commits (1)

a6c1daf fix(app): PWA Title Colour

📊 Changes

1 file changed (+0 additions, -2 deletions)

View changed files

📝 app/templates/includes/head/favicons.html (+0 -2)

📄 Description

Current situation: The current PWA is showing the title bar as white

Screenshot of how it is now

Expectation: It is expected to be the accent colour of the application.

Django PWA already correctly sets the title based on settings.py, but the colour is being overridden by these values in head.

Screenshot of expected colour

Django PWA settings already set here:
https://github.com/eitchtee/WYGIWYH/blob/main/app/WYGIWYH/settings.py#L496

Django PWA example in their README and templates:
https://github.com/silviolleite/django-pwa/blob/master/README.md?plain=1#L51
https://github.com/silviolleite/django-pwa/blob/master/src/pwa/templates/pwa.html#L10

Just a tiny contribution - feel free to reject if it does not align with the design :)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/eitchtee/WYGIWYH/pull/365 **Author:** [@samuelthng](https://github.com/samuelthng) **Created:** 9/9/2025 **Status:** ✅ Merged **Merged:** 9/9/2025 **Merged by:** [@eitchtee](https://github.com/eitchtee) **Base:** `main` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`a6c1daf`](https://github.com/eitchtee/WYGIWYH/commit/a6c1daf9021f3560b553d6b0aa5bbf3629d996de) fix(app): PWA Title Colour ### 📊 Changes **1 file changed** (+0 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `app/templates/includes/head/favicons.html` (+0 -2) </details> ### 📄 Description Current situation: The current PWA is showing the title bar as white <details><summary>Screenshot of how it is now</summary> <img width="1122" height="946" alt="image" src="https://github.com/user-attachments/assets/6416ff8e-6c80-47c0-be64-48ea13d60bd4" /> </details> --- Expectation: It is expected to be the accent colour of the application. Django PWA already correctly sets the title based on settings.py, but the colour is being overridden by these values in head. <details><summary>Screenshot of expected colour</summary> <img width="1122" height="946" alt="image" src="https://github.com/user-attachments/assets/5a597594-c690-448a-be94-2d2aff8d98e3" /> </details> --- Django PWA settings already set here: https://github.com/eitchtee/WYGIWYH/blob/main/app/WYGIWYH/settings.py#L496 Django PWA example in their README and templates: https://github.com/silviolleite/django-pwa/blob/master/README.md?plain=1#L51 https://github.com/silviolleite/django-pwa/blob/master/src/pwa/templates/pwa.html#L10 --- Just a tiny contribution - feel free to reject if it does not align with the design :) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 00:20:06 +01:00

adam closed this issue

2025-12-29 00:20:07 +01:00

adam referenced this issue

2025-12-29 00:20:12 +01:00

[PR #384] [MERGED] Translations update from Weblate #402

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/WYGIWYH#384