starred/SwiftUI
1
0
Fork 0
mirror of https://github.com/ivanvorobei/SwiftUI.git synced 2026-01-11 20:00:26 +01:00
Code Issues 8 Packages Projects Releases Wiki Activity

[PR #7] [MERGED] Just a couple of Combine Publishers to go. #21

New Issue
Closed
opened 2025-12-29 04:20:14 +01:00 by adam · 0 comments
adam commented 2025-12-29 04:20:14 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ivanvorobei/SwiftUI/pull/7
Author: @johnno1962
Created: 7/9/2019
Status: ✅ Merged
Merged: 7/9/2019
Merged by: @ivanvorobei

Base: master ← Head: xcode-11-beta3

📝 Commits (1)

  • 957bedd Just a couple of Combine Publishers to go.

📊 Changes

12 files changed (+33 additions, -24 deletions)

View changed files

📝 Other Projects/Composing Complex Interfaces/Complete/Landmarks/Landmarks/CategoryRow.swift (+1 -1)
📝 Other Projects/Currency-SwiftUI/Currency-SwiftUI/AddCurrencyView.swift (+1 -1)
📝 Other Projects/Currency-SwiftUI/Currency-SwiftUI/ConverterView.swift (+9 -3)
📝 Other Projects/Currency-SwiftUI/Currency-SwiftUI/SceneDelegate.swift (+6 -6)
📝 Other Projects/Example To-Do App/SwiftUITodo/SceneDelegate.swift (+6 -6)
📝 Other Projects/Example To-Do App/SwiftUITodo/TaskItemView.swift (+1 -1)
📝 Other Projects/Example To-Do App/SwiftUITodo/TaskListView.swift (+3 -1)
📝 Other Projects/Interfacing With UIKit/Complete/Landmarks/Landmarks/CategoryRow.swift (+1 -1)
📝 Other Projects/Interfacing With UIKit/Complete/Landmarks/Landmarks/Profiles/ProfileSummary.swift (+1 -1)
📝 Other Projects/Working With UIControls/Complete/Landmarks/Landmarks/CategoryRow.swift (+1 -1)
📝 Other Projects/Working With UIControls/Complete/Landmarks/Landmarks/LandmarkList.swift (+2 -1)
📝 Other Projects/Working With UIControls/Complete/Landmarks/Landmarks/Profiles/ProfileSummary.swift (+1 -1)

📄 Description

Hi,

Worked through the remaining problems apart from the combine examples GitHubSearchWithSwiftUI and SwiftUI-Combine-Example.

Thanks

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ivanvorobei/SwiftUI/pull/7 **Author:** [@johnno1962](https://github.com/johnno1962) **Created:** 7/9/2019 **Status:** ✅ Merged **Merged:** 7/9/2019 **Merged by:** [@ivanvorobei](https://github.com/ivanvorobei) **Base:** `master` ← **Head:** `xcode-11-beta3` --- ### 📝 Commits (1) - [`957bedd`](https://github.com/ivanvorobei/SwiftUI/commit/957bedd3d4d4318930d7aeb28a5bd6570d2ba540) Just a couple of Combine Publishers to go. ### 📊 Changes **12 files changed** (+33 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `Other Projects/Composing Complex Interfaces/Complete/Landmarks/Landmarks/CategoryRow.swift` (+1 -1) 📝 `Other Projects/Currency-SwiftUI/Currency-SwiftUI/AddCurrencyView.swift` (+1 -1) 📝 `Other Projects/Currency-SwiftUI/Currency-SwiftUI/ConverterView.swift` (+9 -3) 📝 `Other Projects/Currency-SwiftUI/Currency-SwiftUI/SceneDelegate.swift` (+6 -6) 📝 `Other Projects/Example To-Do App/SwiftUITodo/SceneDelegate.swift` (+6 -6) 📝 `Other Projects/Example To-Do App/SwiftUITodo/TaskItemView.swift` (+1 -1) 📝 `Other Projects/Example To-Do App/SwiftUITodo/TaskListView.swift` (+3 -1) 📝 `Other Projects/Interfacing With UIKit/Complete/Landmarks/Landmarks/CategoryRow.swift` (+1 -1) 📝 `Other Projects/Interfacing With UIKit/Complete/Landmarks/Landmarks/Profiles/ProfileSummary.swift` (+1 -1) 📝 `Other Projects/Working With UIControls/Complete/Landmarks/Landmarks/CategoryRow.swift` (+1 -1) 📝 `Other Projects/Working With UIControls/Complete/Landmarks/Landmarks/LandmarkList.swift` (+2 -1) 📝 `Other Projects/Working With UIControls/Complete/Landmarks/Landmarks/Profiles/ProfileSummary.swift` (+1 -1) </details> ### 📄 Description Hi, Worked through the remaining problems apart from the combine examples GitHubSearchWithSwiftUI and SwiftUI-Combine-Example. Thanks --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 04:20:14 +01:00
adam closed this issue 2025-12-29 04:20:14 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
bug
bug
enhancement
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/SwiftUI#21
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?