starred/SwiftUI
1
0
Fork 0
mirror of https://github.com/ivanvorobei/SwiftUI.git synced 2026-01-13 04:40:27 +01:00
Code Issues 8 Packages Projects Releases Wiki Activity

[PR #6] [MERGED] A few more run time fixes #19

New Issue
Closed
opened 2025-12-29 04:20:14 +01:00 by adam · 0 comments
adam commented 2025-12-29 04:20:14 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ivanvorobei/SwiftUI/pull/6
Author: @johnno1962
Created: 7/9/2019
Status: ✅ Merged
Merged: 7/9/2019
Merged by: @ivanvorobei

Base: master ← Head: xcode-11-beta3

📝 Commits (2)

📊 Changes

16 files changed (+50 additions, -41 deletions)

View changed files

📝 Other Projects/Animating Views And Transitions/Complete/Landmarks/Landmarks/LandmarkList.swift (+2 -1)
📝 Other Projects/Composing Complex Interfaces/Complete/Landmarks/Landmarks/CategoryRow.swift (+2 -2)
📝 Other Projects/Composing Complex Interfaces/Complete/Landmarks/Landmarks/Home.swift (+4 -5)
📝 Other Projects/Composing Complex Interfaces/Complete/Landmarks/Landmarks/LandmarkList.swift (+2 -1)
📝 Other Projects/Composing Complex Interfaces/Complete/Landmarks/Landmarks/SceneDelegate.swift (+6 -4)
📝 Other Projects/Drawing Paths And Shapes/Complete/Landmarks/Landmarks/LandmarkList.swift (+2 -1)
📝 Other Projects/Handling User Input/Complete/Landmarks/Landmarks/LandmarkList.swift (+2 -1)
📝 Other Projects/Interfacing With UIKit/Complete/Landmarks/Landmarks/CategoryRow.swift (+2 -2)
📝 Other Projects/Interfacing With UIKit/Complete/Landmarks/Landmarks/Home.swift (+4 -5)
📝 Other Projects/Interfacing With UIKit/Complete/Landmarks/Landmarks/LandmarkList.swift (+2 -1)
📝 Other Projects/Interfacing With UIKit/Complete/Landmarks/Landmarks/SceneDelegate.swift (+6 -4)
📝 Other Projects/SwiftUI + Redux/SwiftUIDemo/views/users/UsersListView.swift (+2 -1)
📝 Other Projects/UINote/SwiftUINote/Views/NoteList.swift (+2 -1)
📝 Other Projects/Working With UIControls/Complete/Landmarks/Landmarks/CategoryRow.swift (+2 -2)
📝 Other Projects/Working With UIControls/Complete/Landmarks/Landmarks/Home.swift (+4 -6)
📝 Other Projects/Working With UIControls/Complete/Landmarks/Landmarks/SceneDelegate.swift (+6 -4)

📄 Description

Hi,

After a bit more testing this PR works around these problems introduced with beta3.

Cheers.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ivanvorobei/SwiftUI/pull/6 **Author:** [@johnno1962](https://github.com/johnno1962) **Created:** 7/9/2019 **Status:** ✅ Merged **Merged:** 7/9/2019 **Merged by:** [@ivanvorobei](https://github.com/ivanvorobei) **Base:** `master` ← **Head:** `xcode-11-beta3` --- ### 📝 Commits (2) - [`4612328`](https://github.com/ivanvorobei/SwiftUI/commit/46123280e7e521fe2a2f7b875dbe7dfdd04c4c2c) A few more run time fixes - [`dc575ca`](https://github.com/ivanvorobei/SwiftUI/commit/dc575ca41b314e4f1306689452dcab329e762af0) Still more fixes. ### 📊 Changes **16 files changed** (+50 additions, -41 deletions) <details> <summary>View changed files</summary> 📝 `Other Projects/Animating Views And Transitions/Complete/Landmarks/Landmarks/LandmarkList.swift` (+2 -1) 📝 `Other Projects/Composing Complex Interfaces/Complete/Landmarks/Landmarks/CategoryRow.swift` (+2 -2) 📝 `Other Projects/Composing Complex Interfaces/Complete/Landmarks/Landmarks/Home.swift` (+4 -5) 📝 `Other Projects/Composing Complex Interfaces/Complete/Landmarks/Landmarks/LandmarkList.swift` (+2 -1) 📝 `Other Projects/Composing Complex Interfaces/Complete/Landmarks/Landmarks/SceneDelegate.swift` (+6 -4) 📝 `Other Projects/Drawing Paths And Shapes/Complete/Landmarks/Landmarks/LandmarkList.swift` (+2 -1) 📝 `Other Projects/Handling User Input/Complete/Landmarks/Landmarks/LandmarkList.swift` (+2 -1) 📝 `Other Projects/Interfacing With UIKit/Complete/Landmarks/Landmarks/CategoryRow.swift` (+2 -2) 📝 `Other Projects/Interfacing With UIKit/Complete/Landmarks/Landmarks/Home.swift` (+4 -5) 📝 `Other Projects/Interfacing With UIKit/Complete/Landmarks/Landmarks/LandmarkList.swift` (+2 -1) 📝 `Other Projects/Interfacing With UIKit/Complete/Landmarks/Landmarks/SceneDelegate.swift` (+6 -4) 📝 `Other Projects/SwiftUI + Redux/SwiftUIDemo/views/users/UsersListView.swift` (+2 -1) 📝 `Other Projects/UINote/SwiftUINote/Views/NoteList.swift` (+2 -1) 📝 `Other Projects/Working With UIControls/Complete/Landmarks/Landmarks/CategoryRow.swift` (+2 -2) 📝 `Other Projects/Working With UIControls/Complete/Landmarks/Landmarks/Home.swift` (+4 -6) 📝 `Other Projects/Working With UIControls/Complete/Landmarks/Landmarks/SceneDelegate.swift` (+6 -4) </details> ### 📄 Description Hi, After a bit more testing this PR works around [these](https://stackoverflow.com/questions/56871714/xcode-11-beta-3-crashing-when-using-navigationlink-environmentobject-and-list) problems introduced with beta3. Cheers. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 04:20:14 +01:00
adam closed this issue 2025-12-29 04:20:14 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
bug
bug
enhancement
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/SwiftUI#19
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?