starred/SwiftUI
1
0
Fork 0
mirror of https://github.com/ivanvorobei/SwiftUI.git synced 2026-01-11 20:00:26 +01:00
Code Issues 8 Packages Projects Releases Wiki Activity

Redundant property wrappers in GitHub user search #1

New Issue
Open
opened 2025-12-29 04:20:06 +01:00 by adam · 0 comments
adam commented 2025-12-29 04:20:06 +01:00
Owner
Copy Link

Originally created by @glassomoss on GitHub (Jul 17, 2019).

I've looked into GitHub user search project and found out that views contain unnecessary property wrappers (@State). According to WWDC sessions those shouldn't appear in such context. I removed them and search continued working correctly. I assume it'd be helpful removing them from repo to prevent newbies in Combine study on project with mistakes. Also I found out that project contains parts that are not used at all. I guess I can provide PR if needed)

Thank you for this amazing repo btw! I also speak Russian if that helps.

Originally created by @glassomoss on GitHub (Jul 17, 2019). I've looked into GitHub user search project and found out that views contain unnecessary property wrappers (@State). According to WWDC sessions those shouldn't appear in such context. I removed them and search continued working correctly. I assume it'd be helpful removing them from repo to prevent newbies in Combine study on project with mistakes. Also I found out that project contains parts that are not used at all. I guess I can provide PR if needed) Thank you for this amazing repo btw! I also speak Russian if that helps.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
bug
bug
enhancement
pull-request
Mirrored from GitHub Pull Request
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/SwiftUI#1
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?