[PR #54] [MERGED] Add general enhancements and fixes #65

New Issue

adam · 2025-12-29T05:19:24+01:00

adam commented

2025-12-29 05:19:24 +01:00

📋 Pull Request Information

Original PR: https://github.com/dscyrescotti/Memola/pull/54
Author: @dscyrescotti
Created: 6/27/2024
Status: ✅ Merged
Merged: 6/27/2024
Merged by: @dscyrescotti

Base: main ← Head: feature/general-enhancement

📝 Commits (5)

d5c1cd6 feat: remove step limit in stroke drawing
b9dbcc4 refactor: recreate texture only if device orientation is changed
78e14c6 feat: update photo preview
307d818 feat: exclude graphic texture if there is no elements in visible frame of canvas
fe616d5 feat: select first marker by default

📊 Changes

17 files changed (+146 additions, -105 deletions)

View changed files

📝 Memola/Canvas/Abstracts/RenderPass.swift (+1 -1)
📝 Memola/Canvas/Contexts/GraphicContext.swift (+0 -3)
📝 Memola/Canvas/Core/Canvas.swift (+1 -1)
📝 Memola/Canvas/Core/Renderer.swift (+15 -7)
📝 Memola/Canvas/Elements/Geometries/Stroke/Strokes/PenStroke.swift (+1 -2)
📝 Memola/Canvas/RenderPasses/CacheRenderPass.swift (+13 -10)
📝 Memola/Canvas/RenderPasses/EraserRenderPass.swift (+10 -8)
📝 Memola/Canvas/RenderPasses/GraphicRenderPass.swift (+23 -11)
📝 Memola/Canvas/RenderPasses/PhotoBackgroundRenderPass.swift (+9 -7)
📝 Memola/Canvas/RenderPasses/PhotoRenderPass.swift (+8 -6)
📝 Memola/Canvas/RenderPasses/StrokeRenderPass.swift (+16 -13)
📝 Memola/Canvas/RenderPasses/ViewPortRenderPass.swift (+29 -16)
📝 Memola/Canvas/Tool/Core/Tool.swift (+4 -4)
📝 Memola/Canvas/View/Bridge/ViewController/CanvasViewController.swift (+11 -13)
📝 Memola/Features/Memo/PhotoPreview/PhotoItem.swift (+1 -0)
📝 Memola/Features/Memo/PhotoPreview/PhotoPreview.swift (+3 -3)
📝 Memola/Features/Memos/MemosView.swift (+1 -0)

📄 Description

Description

This PR adds some general enhancements and fixes to improve the quality of the app.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dscyrescotti/Memola/pull/54 **Author:** [@dscyrescotti](https://github.com/dscyrescotti) **Created:** 6/27/2024 **Status:** ✅ Merged **Merged:** 6/27/2024 **Merged by:** [@dscyrescotti](https://github.com/dscyrescotti) **Base:** `main` ← **Head:** `feature/general-enhancement` --- ### 📝 Commits (5) - [`d5c1cd6`](https://github.com/dscyrescotti/Memola/commit/d5c1cd6653893cf1056ec5f76399f7ee4f37de75) feat: remove step limit in stroke drawing - [`b9dbcc4`](https://github.com/dscyrescotti/Memola/commit/b9dbcc45062efff4c823ce6857551723f99bf697) refactor: recreate texture only if device orientation is changed - [`78e14c6`](https://github.com/dscyrescotti/Memola/commit/78e14c65aaefa5229d4540cd2d006b837e691d59) feat: update photo preview - [`307d818`](https://github.com/dscyrescotti/Memola/commit/307d818993123841ad4adebd0633ed4440365b89) feat: exclude graphic texture if there is no elements in visible frame of canvas - [`fe616d5`](https://github.com/dscyrescotti/Memola/commit/fe616d5d842060fcef6f41ebafe901ca95975de1) feat: select first marker by default ### 📊 Changes **17 files changed** (+146 additions, -105 deletions) <details> <summary>View changed files</summary> 📝 `Memola/Canvas/Abstracts/RenderPass.swift` (+1 -1) 📝 `Memola/Canvas/Contexts/GraphicContext.swift` (+0 -3) 📝 `Memola/Canvas/Core/Canvas.swift` (+1 -1) 📝 `Memola/Canvas/Core/Renderer.swift` (+15 -7) 📝 `Memola/Canvas/Elements/Geometries/Stroke/Strokes/PenStroke.swift` (+1 -2) 📝 `Memola/Canvas/RenderPasses/CacheRenderPass.swift` (+13 -10) 📝 `Memola/Canvas/RenderPasses/EraserRenderPass.swift` (+10 -8) 📝 `Memola/Canvas/RenderPasses/GraphicRenderPass.swift` (+23 -11) 📝 `Memola/Canvas/RenderPasses/PhotoBackgroundRenderPass.swift` (+9 -7) 📝 `Memola/Canvas/RenderPasses/PhotoRenderPass.swift` (+8 -6) 📝 `Memola/Canvas/RenderPasses/StrokeRenderPass.swift` (+16 -13) 📝 `Memola/Canvas/RenderPasses/ViewPortRenderPass.swift` (+29 -16) 📝 `Memola/Canvas/Tool/Core/Tool.swift` (+4 -4) 📝 `Memola/Canvas/View/Bridge/ViewController/CanvasViewController.swift` (+11 -13) 📝 `Memola/Features/Memo/PhotoPreview/PhotoItem.swift` (+1 -0) 📝 `Memola/Features/Memo/PhotoPreview/PhotoPreview.swift` (+3 -3) 📝 `Memola/Features/Memos/MemosView.swift` (+1 -0) </details> ### 📄 Description ### Description This PR adds some general enhancements and fixes to improve the quality of the app. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 05:19:24 +01:00

adam closed this issue

2025-12-29 05:19:24 +01:00

adam referenced this issue

2025-12-29 05:19:28 +01:00

[PR #65] [MERGED] Implement Settings #71

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/Memola#65