[PR #47] [MERGED] Fix content disappearing in subsequent render #61

New Issue

adam · 2025-12-29T05:19:22+01:00

adam commented

2025-12-29 05:19:22 +01:00

📋 Pull Request Information

Original PR: https://github.com/dscyrescotti/Memola/pull/47
Author: @dscyrescotti
Created: 6/19/2024
Status: ✅ Merged
Merged: 6/19/2024
Merged by: @dscyrescotti

Base: main ← Head: feature/photo-render-pass

📝 Commits (1)

d3b9328 bug: fix content disappearing in subsequent render

📊 Changes

3 files changed (+15 additions, -14 deletions)

View changed files

📝 Memola/Canvas/Elements/Photo/Photo.swift (+11 -10)
📝 Memola/Canvas/RenderPasses/EraserRenderPass.swift (+2 -2)
📝 Memola/Canvas/RenderPasses/StrokeRenderPass.swift (+2 -2)

📄 Description

Description

This PR fixes the issue of discarding some content on canvas by opt for cpuCacheModeWriteCombined in buffer creation and recreate buffer for photo vertex buffer.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dscyrescotti/Memola/pull/47 **Author:** [@dscyrescotti](https://github.com/dscyrescotti) **Created:** 6/19/2024 **Status:** ✅ Merged **Merged:** 6/19/2024 **Merged by:** [@dscyrescotti](https://github.com/dscyrescotti) **Base:** `main` ← **Head:** `feature/photo-render-pass` --- ### 📝 Commits (1) - [`d3b9328`](https://github.com/dscyrescotti/Memola/commit/d3b9328d8cf8b1080caf1269f9a2966e3bd227a7) bug: fix content disappearing in subsequent render ### 📊 Changes **3 files changed** (+15 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `Memola/Canvas/Elements/Photo/Photo.swift` (+11 -10) 📝 `Memola/Canvas/RenderPasses/EraserRenderPass.swift` (+2 -2) 📝 `Memola/Canvas/RenderPasses/StrokeRenderPass.swift` (+2 -2) </details> ### 📄 Description ### Description This PR fixes the issue of discarding some content on canvas by opt for `cpuCacheModeWriteCombined` in buffer creation and recreate buffer for photo vertex buffer. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 05:19:22 +01:00

adam closed this issue

2025-12-29 05:19:22 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/Memola#61