[PR #35] [MERGED] Fix stroke glitches when rendering #53

New Issue

Closed

opened 2025-12-29 05:19:18 +01:00 by adam · 0 comments

adam commented 2025-12-29 05:19:18 +01:00

Owner

Copy Link

Copy Source

📋 Pull Request Information

Original PR: https://github.com/dscyrescotti/Memola/pull/35
Author: @dscyrescotti
Created: 5/22/2024
Status: ✅ Merged
Merged: 5/22/2024
Merged by: @dscyrescotti

Base: main ← Head: feature/stroke-generator

---

📝 Commits (2)

• e1d911f feat: smooth out stroke using moving average algorithm
• c2b39ba bug: fix stroke glitching

📊 Changes

7 files changed (+101 additions, -40 deletions)

View changed files

📝 Memola.xcodeproj/project.pbxproj (+12 -0)
📝 Memola/App/MemolaApp.swift (+5 -0)
📝 Memola/Canvas/Contexts/GraphicContext.swift (+2 -3)
➕ Memola/Canvas/Geometries/Stroke/Algorithms/MovingAverage.swift (+40 -0)
📝 Memola/Canvas/Geometries/Stroke/Generators/SolidPointStrokeGenerator.swift (+8 -14)
📝 Memola/Canvas/Geometries/Stroke/Stroke.swift (+23 -20)
📝 Memola/Features/Memo/Toolbar/Toolbar.swift (+11 -3)

📄 Description

Description

This PR fixes stroke glitches when drawing strokes fast at minimum zoom level.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dscyrescotti/Memola/pull/35 **Author:** [@dscyrescotti](https://github.com/dscyrescotti) **Created:** 5/22/2024 **Status:** ✅ Merged **Merged:** 5/22/2024 **Merged by:** [@dscyrescotti](https://github.com/dscyrescotti) **Base:** `main` ← **Head:** `feature/stroke-generator` --- ### 📝 Commits (2) - [`e1d911f`](https://github.com/dscyrescotti/Memola/commit/e1d911f2e1643223cc67c154a5ee9023b634d536) feat: smooth out stroke using moving average algorithm - [`c2b39ba`](https://github.com/dscyrescotti/Memola/commit/c2b39ba358d2ee2a420ea21e649c7b14587f832f) bug: fix stroke glitching ### 📊 Changes **7 files changed** (+101 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `Memola.xcodeproj/project.pbxproj` (+12 -0) 📝 `Memola/App/MemolaApp.swift` (+5 -0) 📝 `Memola/Canvas/Contexts/GraphicContext.swift` (+2 -3) ➕ `Memola/Canvas/Geometries/Stroke/Algorithms/MovingAverage.swift` (+40 -0) 📝 `Memola/Canvas/Geometries/Stroke/Generators/SolidPointStrokeGenerator.swift` (+8 -14) 📝 `Memola/Canvas/Geometries/Stroke/Stroke.swift` (+23 -20) 📝 `Memola/Features/Memo/Toolbar/Toolbar.swift` (+11 -3) </details> ### 📄 Description ### Description This PR fixes stroke glitches when drawing strokes fast at minimum zoom level. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

adam added the pull-request label 2025-12-29 05:19:18 +01:00

adam closed this issue 2025-12-29 05:19:18 +01:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

develop

v1.0.2

v1.0.1

v1.0.0

Labels

Clear labels

bug

documentation

help wanted

pull-request

Mirrored from GitHub Pull Request

No labels pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

adam (Adam Melkus)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/Memola#53