[PR #17] [MERGED] Resolve conflict between responder touches and scrollview pinch gesture #43

New Issue

adam · 2025-12-29T05:19:15+01:00

adam commented

2025-12-29 05:19:15 +01:00

📋 Pull Request Information

Original PR: https://github.com/dscyrescotti/Memola/pull/17
Author: @dscyrescotti
Created: 5/6/2024
Status: ✅ Merged
Merged: 5/6/2024
Merged by: @dscyrescotti

Base: main ← Head: bug/stroke-enhancement

📝 Commits (2)

854c7cd bug: sync pen drawing and stroke generating
0202678 feat: resolve pinch gesture conflict with responder touches

📊 Changes

8 files changed (+120 additions, -51 deletions)

View changed files

📝 Memola.xcodeproj/project.pbxproj (+18 -2)
📝 Memola/Canvas/Contexts/GraphicContext.swift (+8 -0)
📝 Memola/Canvas/Core/Canvas.swift (+13 -2)
📝 Memola/Canvas/Geometries/Stroke/Generators/SolidPointStrokeGenerator.swift (+22 -5)
📝 Memola/Canvas/Geometries/Stroke/Stroke.swift (+2 -2)
📝 Memola/Canvas/History/History.swift (+11 -0)
📝 Memola/Canvas/View/Bridge/ViewController/CanvasViewController.swift (+1 -36)
📝 Memola/Canvas/View/Bridge/Views/DrawingView.swift (+45 -4)

📄 Description

Description

This PR enhances drawing view ensuring no conflict between scrollview pinch gesture and responder touches.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dscyrescotti/Memola/pull/17 **Author:** [@dscyrescotti](https://github.com/dscyrescotti) **Created:** 5/6/2024 **Status:** ✅ Merged **Merged:** 5/6/2024 **Merged by:** [@dscyrescotti](https://github.com/dscyrescotti) **Base:** `main` ← **Head:** `bug/stroke-enhancement` --- ### 📝 Commits (2) - [`854c7cd`](https://github.com/dscyrescotti/Memola/commit/854c7cd732258aaacd1e3effb7e118acb7f3af36) bug: sync pen drawing and stroke generating - [`0202678`](https://github.com/dscyrescotti/Memola/commit/0202678d8d7e06220c0a9a6f76022282f5847051) feat: resolve pinch gesture conflict with responder touches ### 📊 Changes **8 files changed** (+120 additions, -51 deletions) <details> <summary>View changed files</summary> 📝 `Memola.xcodeproj/project.pbxproj` (+18 -2) 📝 `Memola/Canvas/Contexts/GraphicContext.swift` (+8 -0) 📝 `Memola/Canvas/Core/Canvas.swift` (+13 -2) 📝 `Memola/Canvas/Geometries/Stroke/Generators/SolidPointStrokeGenerator.swift` (+22 -5) 📝 `Memola/Canvas/Geometries/Stroke/Stroke.swift` (+2 -2) 📝 `Memola/Canvas/History/History.swift` (+11 -0) 📝 `Memola/Canvas/View/Bridge/ViewController/CanvasViewController.swift` (+1 -36) 📝 `Memola/Canvas/View/Bridge/Views/DrawingView.swift` (+45 -4) </details> ### 📄 Description ### Description This PR enhances drawing view ensuring no conflict between scrollview pinch gesture and responder touches. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 05:19:15 +01:00

adam closed this issue

2025-12-29 05:19:15 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/Memola#43