[PR #590] Cleaned Dockerfile CMD entrypoints to make it easier to extend or buil… #783

New Issue

adam · 2025-12-29T01:25:12+01:00

adam commented

2025-12-29 01:25:12 +01:00

📋 Pull Request Information

Original PR: https://github.com/sickcodes/Docker-OSX/pull/590
Author: @pathtofile
Created: 12/12/2022
Status: 🔄 Open

Base: master ← Head: clean-cmd-entrypoints

📝 Commits (2)

d380dd1 Cleaned Dockerfile CMD entrypoint to make it easier to extend or build on top of built image
3004d74 Made all entrypoint scripts the same name inside the container image

📊 Changes

10 files changed (+243 additions, -223 deletions)

View changed files

📝 Dockerfile (+2 -32)
📝 Dockerfile.auto (+2 -63)
📝 Dockerfile.monterey (+2 -32)
📝 Dockerfile.naked (+2 -36)
📝 Dockerfile.naked-auto (+2 -60)
➕ entrypoint.auto.sh (+65 -0)
➕ entrypoint.monterey.sh (+34 -0)
➕ entrypoint.naked-auto.sh (+62 -0)
➕ entrypoint.naked.sh (+38 -0)
➕ entrypoint.sh (+34 -0)

📄 Description

Cleaned Dockerfile CMD entrypoints to make it easier to extend or build on top of built image.

In some situations you might want to run extra setup inside the container prior to qemu, or build on top of the built docker image using e.g. FROM sickcodes/docker-osx:naked.

Without this PR, when you change the CMD you'd need to also re-implement all of the checks and setup done by the original CMD.

With this PR, you can first call your own script first, then call bash -c entrypoint.sh after your code, and optionally have some post-QEMU code after the VM has shut down.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/sickcodes/Docker-OSX/pull/590 **Author:** [@pathtofile](https://github.com/pathtofile) **Created:** 12/12/2022 **Status:** 🔄 Open **Base:** `master` ← **Head:** `clean-cmd-entrypoints` --- ### 📝 Commits (2) - [`d380dd1`](https://github.com/sickcodes/Docker-OSX/commit/d380dd13451aa1431af9bef6a41c8b58db07ae6d) Cleaned Dockerfile CMD entrypoint to make it easier to extend or build on top of built image - [`3004d74`](https://github.com/sickcodes/Docker-OSX/commit/3004d743b0e18e5fa62865484458feac588f1dc2) Made all entrypoint scripts the same name inside the container image ### 📊 Changes **10 files changed** (+243 additions, -223 deletions) <details> <summary>View changed files</summary> 📝 `Dockerfile` (+2 -32) 📝 `Dockerfile.auto` (+2 -63) 📝 `Dockerfile.monterey` (+2 -32) 📝 `Dockerfile.naked` (+2 -36) 📝 `Dockerfile.naked-auto` (+2 -60) ➕ `entrypoint.auto.sh` (+65 -0) ➕ `entrypoint.monterey.sh` (+34 -0) ➕ `entrypoint.naked-auto.sh` (+62 -0) ➕ `entrypoint.naked.sh` (+38 -0) ➕ `entrypoint.sh` (+34 -0) </details> ### 📄 Description Cleaned Dockerfile CMD entrypoints to make it easier to extend or build on top of built image. In some situations you might want to run extra setup inside the container prior to qemu, or build on top of the built docker image using e.g. `FROM sickcodes/docker-osx:naked`. Without this PR, when you change the CMD you'd need to also re-implement all of the checks and setup done by the original CMD. With this PR, you can first call your own script first, then call `bash -c entrypoint.sh` after your code, and optionally have some post-QEMU code after the VM has shut down. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 01:25:12 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/Docker-OSX#783