[PR #288] [MERGED] Change call function to Popen #745

New Issue

adam · 2025-12-29T01:24:58+01:00

adam commented

2025-12-29 01:24:58 +01:00

📋 Pull Request Information

Original PR: https://github.com/sickcodes/Docker-OSX/pull/288
Author: @redr0nin
Created: 6/7/2021
Status: ✅ Merged
Merged: 7/2/2021
Merged by: @sickcodes

Base: master ← Head: patch-1

📝 Commits (2)

62baabc Change call function to Popen
0d70bed Update fetch-macOS.py

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 fetch-macOS.py (+2 -2)

📄 Description

The call function can deadlock if the child process prints larger output. Use Popen with the communicate() method with you need pipes. If you switch to Popen, you'll get cleaner debugging.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/sickcodes/Docker-OSX/pull/288 **Author:** [@redr0nin](https://github.com/redr0nin) **Created:** 6/7/2021 **Status:** ✅ Merged **Merged:** 7/2/2021 **Merged by:** [@sickcodes](https://github.com/sickcodes) **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (2) - [`62baabc`](https://github.com/sickcodes/Docker-OSX/commit/62baabc31e86faca0cb554816a83ad38996272f7) Change call function to Popen - [`0d70bed`](https://github.com/sickcodes/Docker-OSX/commit/0d70bed2edb492587973f62f86bda934f1db3831) Update fetch-macOS.py ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `fetch-macOS.py` (+2 -2) </details> ### 📄 Description The call function can deadlock if the child process prints larger output. Use Popen with the communicate() method with you need pipes. If you switch to Popen, you'll get cleaner debugging. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 01:24:58 +01:00

adam closed this issue

2025-12-29 01:24:58 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/Docker-OSX#745