[PR #169] [MERGED] Fix BOOTDISK expected logic #725

New Issue

adam · 2025-12-29T01:24:51+01:00

adam commented

2025-12-29 01:24:51 +01:00

📋 Pull Request Information

Original PR: https://github.com/sickcodes/Docker-OSX/pull/169
Author: @sickcodes
Created: 3/6/2021
Status: ✅ Merged
Merged: 3/6/2021
Merged by: @sickcodes

Base: master ← Head: nopicker-bug

📝 Commits (2)

7382df8 Fix BOOTDISK expected logic
c2916fd Dockerfile syntax error.

📊 Changes

3 files changed (+13 additions, -12 deletions)

View changed files

📝 Dockerfile (+5 -6)
📝 Dockerfile.auto (+3 -2)
📝 Dockerfile.naked (+5 -4)

📄 Description

NOPICKER logic bug.

BOOTDISK is unset in all images.

New logic:

if NOPICKER is true (true in both auto and naked but not latest)
- Remove install media, and SET BOOTDISK=/home/arch/OSX-KVM/OpenCore-Catalina/OpenCore-nopicker.qcow2
- UNLESS BOOTDISK is set by the user in -e BOOTDISK=mybootdisk.img
else BOOTDISK=/home/arch/OSX-KVM/OpenCore-Catalina/OpenCore.qcow2

 [[ "${NOPICKER}" == true ]] && { \
    sed -i '/^.*InstallMedia.*/d' Launch.sh \
    && export BOOTDISK="${BOOTDISK:=/home/arch/OSX-KVM/OpenCore-Catalina/OpenCore-nopicker.qcow2}" \
; } \
|| export BOOTDISK="${BOOTDISK:=/home/arch/OSX-KVM/OpenCore-Catalina/OpenCore.qcow2}"

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/sickcodes/Docker-OSX/pull/169 **Author:** [@sickcodes](https://github.com/sickcodes) **Created:** 3/6/2021 **Status:** ✅ Merged **Merged:** 3/6/2021 **Merged by:** [@sickcodes](https://github.com/sickcodes) **Base:** `master` ← **Head:** `nopicker-bug` --- ### 📝 Commits (2) - [`7382df8`](https://github.com/sickcodes/Docker-OSX/commit/7382df8fa1fbc922827981a4cfd03c03b7888fb3) Fix BOOTDISK expected logic - [`c2916fd`](https://github.com/sickcodes/Docker-OSX/commit/c2916fd48748ff15dbb8cb79cc9b5655e4d509eb) Dockerfile syntax error. ### 📊 Changes **3 files changed** (+13 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `Dockerfile` (+5 -6) 📝 `Dockerfile.auto` (+3 -2) 📝 `Dockerfile.naked` (+5 -4) </details> ### 📄 Description NOPICKER logic bug. - BOOTDISK is unset in all images. New logic: - if NOPICKER is true (true in both auto and naked but not latest) - - Remove install media, and SET `BOOTDISK=/home/arch/OSX-KVM/OpenCore-Catalina/OpenCore-nopicker.qcow2` - - UNLESS BOOTDISK is set by the user in `-e BOOTDISK=mybootdisk.img` - else `BOOTDISK=/home/arch/OSX-KVM/OpenCore-Catalina/OpenCore.qcow2` ```bash [[ "${NOPICKER}" == true ]] && { \ sed -i '/^.*InstallMedia.*/d' Launch.sh \ && export BOOTDISK="${BOOTDISK:=/home/arch/OSX-KVM/OpenCore-Catalina/OpenCore-nopicker.qcow2}" \ ; } \ || export BOOTDISK="${BOOTDISK:=/home/arch/OSX-KVM/OpenCore-Catalina/OpenCore.qcow2}" ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 01:24:51 +01:00

adam closed this issue

2025-12-29 01:24:51 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/Docker-OSX#725