[PR #163] [MERGED] Add WIDTH and HEIGHT environment variables #720

Closed
opened 2025-12-29 01:24:49 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/sickcodes/Docker-OSX/pull/163
Author: @sickcodes
Created: 3/3/2021
Status: Merged
Merged: 3/4/2021
Merged by: @sickcodes

Base: masterHead: resolution-changes-runtime


📝 Commits (10+)

  • 5469cb8 Add WIDTH and HEIGHT environment variables
  • 408248a Missing WIDTH and HEIGHT from naked and auto Dockerfiles
  • 3f4c0c6 Add --custom-plist-url, --custom-plist or --master-plist to both serial generators.
  • 377c4e7 Add -e MASTER_PLIST_URL to change the input config.plist at runtime.
  • 84fc717 Syntax error: elif obviously needs a ; then
  • 45a5f2c wget -O case sensitive, silence source /env errors.
  • e03f073 Fix .//config-custom.plist
  • 4b278bc Shift exits
  • 2077c3a v4.1 WIDTH/HEIGHT && move resolution README note
  • b2f6ac5 Typo

📊 Changes

8 files changed (+375 additions, -55 deletions)

View changed files

📝 CHANGELOG.md (+2 -0)
📝 Dockerfile (+34 -14)
📝 Dockerfile.auto (+19 -12)
📝 Dockerfile.naked (+19 -12)
📝 README.md (+136 -1)
📝 custom/config-nopicker-custom.plist (+1 -1)
📝 custom/generate-specific-bootdisk.sh (+82 -12)
📝 custom/generate-unique-machine-values.sh (+82 -3)

📄 Description

Example:

stat mac_hdd_ng.img # make sure you have an image if you're using :naked
touch ./mynewbootdisk.qcow

docker run -it \
    --device /dev/kvm \
    -e "DISPLAY=${DISPLAY:-:0.0}" \
    -v /tmp/.X11-unix:/tmp/.X11-unix \
    -p 50922:10022 \
    -e NOPICKER=true \
    -e GENERATE_SPECIFIC=true \
    -e DEVICE_MODEL="iMacPro1,1" \
    -e SERIAL="C02TW0WAHX87" \
    -e BOARD_SERIAL="C027251024NJG36UE" \
    -e UUID="5CCB366D-9118-4C61-A00A-E5BAF3BED451" \
    -e MAC_ADDRESS="A8:5C:2C:9A:46:2F" \
    -e WIDTH=1000 \
    -e HEIGHT=1000 \
    -e BOOTDISK=/bootdisk \
    -v "${PWD}/mynewbootdisk.qcow:/bootdisk" \
    -v "${PWD}/mac_hdd_ng.img:/image" \
    sickcodes/docker-osx:naked

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/sickcodes/Docker-OSX/pull/163 **Author:** [@sickcodes](https://github.com/sickcodes) **Created:** 3/3/2021 **Status:** ✅ Merged **Merged:** 3/4/2021 **Merged by:** [@sickcodes](https://github.com/sickcodes) **Base:** `master` ← **Head:** `resolution-changes-runtime` --- ### 📝 Commits (10+) - [`5469cb8`](https://github.com/sickcodes/Docker-OSX/commit/5469cb8a582cc6354b45b2a4ddd9820ebeffa1c5) Add WIDTH and HEIGHT environment variables - [`408248a`](https://github.com/sickcodes/Docker-OSX/commit/408248ae4f95f4c2760afa94bfb06d799c7317f8) Missing WIDTH and HEIGHT from naked and auto Dockerfiles - [`3f4c0c6`](https://github.com/sickcodes/Docker-OSX/commit/3f4c0c6bd4d993e90fd66138521247a2014e70f2) Add --custom-plist-url, --custom-plist <filename> or --master-plist to both serial generators. - [`377c4e7`](https://github.com/sickcodes/Docker-OSX/commit/377c4e7cc5cdd785e965e13e15086c2326797b51) Add -e MASTER_PLIST_URL to change the input config.plist at runtime. - [`84fc717`](https://github.com/sickcodes/Docker-OSX/commit/84fc71722c1742c0f51fb4b89317717ae4a987df) Syntax error: `elif` obviously needs a `; then` - [`45a5f2c`](https://github.com/sickcodes/Docker-OSX/commit/45a5f2c074de948eaef8d48bde2a3df9ce238289) wget -O case sensitive, silence source /env errors. - [`e03f073`](https://github.com/sickcodes/Docker-OSX/commit/e03f0737c3ce4428047808c367409396cfa9e7ff) Fix `.//config-custom.plist` - [`4b278bc`](https://github.com/sickcodes/Docker-OSX/commit/4b278bc42c10c29fc8592d018bf2e59678cf8174) Shift exits - [`2077c3a`](https://github.com/sickcodes/Docker-OSX/commit/2077c3a45354ed6beb753afaed49d789d94a25b6) v4.1 WIDTH/HEIGHT && move resolution README note - [`b2f6ac5`](https://github.com/sickcodes/Docker-OSX/commit/b2f6ac509c78387d250a59c666eae03e2dc65ef7) Typo ### 📊 Changes **8 files changed** (+375 additions, -55 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+2 -0) 📝 `Dockerfile` (+34 -14) 📝 `Dockerfile.auto` (+19 -12) 📝 `Dockerfile.naked` (+19 -12) 📝 `README.md` (+136 -1) 📝 `custom/config-nopicker-custom.plist` (+1 -1) 📝 `custom/generate-specific-bootdisk.sh` (+82 -12) 📝 `custom/generate-unique-machine-values.sh` (+82 -3) </details> ### 📄 Description Example: ```bash stat mac_hdd_ng.img # make sure you have an image if you're using :naked touch ./mynewbootdisk.qcow docker run -it \ --device /dev/kvm \ -e "DISPLAY=${DISPLAY:-:0.0}" \ -v /tmp/.X11-unix:/tmp/.X11-unix \ -p 50922:10022 \ -e NOPICKER=true \ -e GENERATE_SPECIFIC=true \ -e DEVICE_MODEL="iMacPro1,1" \ -e SERIAL="C02TW0WAHX87" \ -e BOARD_SERIAL="C027251024NJG36UE" \ -e UUID="5CCB366D-9118-4C61-A00A-E5BAF3BED451" \ -e MAC_ADDRESS="A8:5C:2C:9A:46:2F" \ -e WIDTH=1000 \ -e HEIGHT=1000 \ -e BOOTDISK=/bootdisk \ -v "${PWD}/mynewbootdisk.qcow:/bootdisk" \ -v "${PWD}/mac_hdd_ng.img:/image" \ sickcodes/docker-osx:naked ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 01:24:49 +01:00
adam closed this issue 2025-12-29 01:24:50 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/Docker-OSX#720