starred/Docker-OSX
1
0
Fork 0
mirror of https://github.com/sickcodes/Docker-OSX.git synced 2026-01-13 13:53:28 +01:00
Code Issues 411 Packages Projects Releases Wiki Activity

[PR #121] [MERGED] Improve Dockerfile #699

New Issue
Closed
opened 2025-12-29 01:24:42 +01:00 by adam · 0 comments
adam commented 2025-12-29 01:24:42 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/sickcodes/Docker-OSX/pull/121
Author: @PeterDaveHello
Created: 1/4/2021
Status: ✅ Merged
Merged: 1/5/2021
Merged by: @sickcodes

Base: master ← Head: ImproveDockerfile

📝 Commits (3)

  • c336071 Use bash in Dockerfile, here-strings(<<<) are undefined in POSIX sh
  • e01ada4 Remove not used packages in Dockerfile
  • 5b4dc0a Adjust spaces and empty lines in Dockerfile

📊 Changes

1 file changed (+21 additions, -22 deletions)

View changed files

📝 Dockerfile (+21 -22)

📄 Description

  1. Set the shell to bash is more proper for current instructions in the Dockerfile.
  2. Removal of the unused packages save the size a lot.
$ docker images
REPOSITORY                    TAG                 IMAGE ID            CREATED             SIZE
docker-osx                    newone              747ac72ebc3f        4 days ago          2.52GB
docker-osx                    oldone              81c8272d3156        4 days ago          3.28GB
  1. Adjust the spaces/indents and empty lines in Dockefile

See the commit message for more details! (feel free to ping me if it's not enough)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/sickcodes/Docker-OSX/pull/121 **Author:** [@PeterDaveHello](https://github.com/PeterDaveHello) **Created:** 1/4/2021 **Status:** ✅ Merged **Merged:** 1/5/2021 **Merged by:** [@sickcodes](https://github.com/sickcodes) **Base:** `master` ← **Head:** `ImproveDockerfile` --- ### 📝 Commits (3) - [`c336071`](https://github.com/sickcodes/Docker-OSX/commit/c3360712c9d0e886dc7792cd149b4c360d6e1f64) Use bash in Dockerfile, here-strings(<<<) are undefined in POSIX sh - [`e01ada4`](https://github.com/sickcodes/Docker-OSX/commit/e01ada40cd7bda0de58aa77f6aec7851f97e7333) Remove not used packages in Dockerfile - [`5b4dc0a`](https://github.com/sickcodes/Docker-OSX/commit/5b4dc0a8927dacb5090c9f8a5875680f90761b68) Adjust spaces and empty lines in Dockerfile ### 📊 Changes **1 file changed** (+21 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `Dockerfile` (+21 -22) </details> ### 📄 Description 1. Set the shell to bash is more proper for current instructions in the Dockerfile. 2. Removal of the unused packages save the size a lot. ``` $ docker images REPOSITORY TAG IMAGE ID CREATED SIZE docker-osx newone 747ac72ebc3f 4 days ago 2.52GB docker-osx oldone 81c8272d3156 4 days ago 3.28GB ``` 3. Adjust the spaces/indents and empty lines in Dockefile See the commit message for more details! (feel free to ping me if it's not enough) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 01:24:42 +01:00
adam closed this issue 2025-12-29 01:24:42 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
enhancement
following upstream developments
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/Docker-OSX#699
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?