starred/Docker-OSX-sickcodes
1
0
Fork 0
mirror of https://github.com/sickcodes/Docker-OSX.git synced 2026-08-29 15:07:16 +02:00
Code Issues 411 Packages Projects Releases Wiki Activity

[PR #826] [MERGED] DMCA compliance, installer download at runtime #803

New Issue
Closed
opened 2025-12-29 06:22:57 +01:00 by adam · 0 comments
adam commented 2025-12-29 06:22:57 +01:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/sickcodes/Docker-OSX/pull/826
Author: @sickcodes
Created: 9/26/2024
Status: ✅ Merged
Merged: 10/14/2024
Merged by: @sickcodes

Base: master ← Head: runtime-download

📝 Commits (3)

  • 55fe01b DMCA compliance, installer download at runtime
  • a1df7c5 Wrong spot
  • 19915de -e SHORTNAME=sonoma is now a runtime arg, which is DMCA compliant, all images are under :latest.

📊 Changes

8 files changed (+105 additions, -280 deletions)

View changed files

📝 Dockerfile (+14 -8)
📝 Dockerfile.auto (+14 -1)
➖ Dockerfile.monterey (+0 -255)
📝 Dockerfile.naked (+14 -1)
📝 Dockerfile.naked-auto (+14 -1)
📝 README.md (+21 -12)
📝 vnc-version/Dockerfile (+14 -1)
📝 vnc-version/Dockerfile.nakedvnc (+14 -1)

📄 Description

Complies with DMCA notice by downloading required installer files at runtime, instead of being stored in repository: https://www.bleepingcomputer.com/news/security/docker-osx-image-used-for-security-research-hit-by-apple-dmca-takedown/

# DMCA compliant download process
# If BaseSystem.img does not exist, download ${SHORTNAME}

# shortname default is now sonoma, which means :latest is sonoma
ENV SHORTNAME=sonoma

ENV BASESYSTEM_IMAGE=BaseSystem.img

CMD ! [[ -e "${BASESYSTEM_IMAGE:-BaseSystem.img}" ]] \
        && printf '%s\n' "No BaseSystem.img available, downloading ${SHORTNAME}" \
        && make \
        && qemu-img convert BaseSystem.dmg -O qcow2 -p -c ${BASESYSTEM_IMAGE:-BaseSystem.img} \
        && rm ./BaseSystem.dmg \
    ; 
...

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/sickcodes/Docker-OSX/pull/826 **Author:** [@sickcodes](https://github.com/sickcodes) **Created:** 9/26/2024 **Status:** ✅ Merged **Merged:** 10/14/2024 **Merged by:** [@sickcodes](https://github.com/sickcodes) **Base:** `master` ← **Head:** `runtime-download` --- ### 📝 Commits (3) - [`55fe01b`](https://github.com/sickcodes/Docker-OSX/commit/55fe01bb97c112de47653ca0e8afc07c8b05d577) DMCA compliance, installer download at runtime - [`a1df7c5`](https://github.com/sickcodes/Docker-OSX/commit/a1df7c5a65603f622bdfe89805a960f0731cbbee) Wrong spot - [`19915de`](https://github.com/sickcodes/Docker-OSX/commit/19915de799a5e4708f308522be0a28ded7c4ae68) `-e SHORTNAME=sonoma` is now a runtime arg, which is DMCA compliant, all images are under `:latest`. ### 📊 Changes **8 files changed** (+105 additions, -280 deletions) <details> <summary>View changed files</summary> 📝 `Dockerfile` (+14 -8) 📝 `Dockerfile.auto` (+14 -1) ➖ `Dockerfile.monterey` (+0 -255) 📝 `Dockerfile.naked` (+14 -1) 📝 `Dockerfile.naked-auto` (+14 -1) 📝 `README.md` (+21 -12) 📝 `vnc-version/Dockerfile` (+14 -1) 📝 `vnc-version/Dockerfile.nakedvnc` (+14 -1) </details> ### 📄 Description Complies with DMCA notice by downloading required installer files at runtime, instead of being stored in repository: https://www.bleepingcomputer.com/news/security/docker-osx-image-used-for-security-research-hit-by-apple-dmca-takedown/ ```dockerfile # DMCA compliant download process # If BaseSystem.img does not exist, download ${SHORTNAME} # shortname default is now sonoma, which means :latest is sonoma ENV SHORTNAME=sonoma ENV BASESYSTEM_IMAGE=BaseSystem.img CMD ! [[ -e "${BASESYSTEM_IMAGE:-BaseSystem.img}" ]] \ && printf '%s\n' "No BaseSystem.img available, downloading ${SHORTNAME}" \ && make \ && qemu-img convert BaseSystem.dmg -O qcow2 -p -c ${BASESYSTEM_IMAGE:-BaseSystem.img} \ && rm ./BaseSystem.dmg \ ; ... ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 06:22:57 +01:00
adam closed this issue 2025-12-29 06:22:57 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
enhancement
following upstream developments
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/Docker-OSX-sickcodes#803