2332e96 Revert XHCI/device line to the old usb-kbd/tablet string. And make new images use runtime option -e XHCI_STRING="-device qemu-xhci,id=xhci -device usb-kbd,bus=xhci.0 -device usb-tablet,bus=xhci.0"
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/sickcodes/Docker-OSX/pull/819
**Author:** [@sickcodes](https://github.com/sickcodes)
**Created:** 9/3/2024
**Status:** 🔄 Open
**Base:** `master` ← **Head:** `mouse-fix`
---
### 📝 Commits (2)
- [`d2c4811`](https://github.com/sickcodes/Docker-OSX/commit/d2c4811b6af063a5fe1df19ece4d239debf903d8) XHCI one line before fixing
- [`2332e96`](https://github.com/sickcodes/Docker-OSX/commit/2332e96f892aba4935ef20e2dd1e763a86c056d7) Revert XHCI/device line to the old usb-kbd/tablet string. And make new images use runtime option `-e XHCI_STRING="-device qemu-xhci,id=xhci -device usb-kbd,bus=xhci.0 -device usb-tablet,bus=xhci.0"`
### 📊 Changes
**1 file changed** (+2 additions, -3 deletions)
<details>
<summary>View changed files</summary>
📝 `Dockerfile` (+2 -3)
</details>
### 📄 Description
As per @gilelias comment https://github.com/sickcodes/Docker-OSX/issues/766#issuecomment-2156706595
I introduced a bug with mouse on old versions by switching
`-usb -device usb-kbd -device usb-tablet`
to
`-device qemu-xhci,id=xhci -device usb-kbd,bus=xhci.0 -device usb-tablet,bus=xhci.0`
This PR reverts the Dockerfile to use in the launch script:
```bash
&& tee -a Launch.sh <<< '${XHCI_STRING:--usb -device usb-kbd -device usb-tablet} \' \
```
And adds runtime option for newer machines:
```bash
-e XHCI_STRING="-device qemu-xhci,id=xhci -device usb-kbd,bus=xhci.0 -device usb-tablet,bus=xhci.0"
```
Untested.
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/sickcodes/Docker-OSX/pull/819
Author: @sickcodes
Created: 9/3/2024
Status: 🔄 Open
Base:
master← Head:mouse-fix📝 Commits (2)
d2c4811XHCI one line before fixing2332e96Revert XHCI/device line to the old usb-kbd/tablet string. And make new images use runtime option-e XHCI_STRING="-device qemu-xhci,id=xhci -device usb-kbd,bus=xhci.0 -device usb-tablet,bus=xhci.0"📊 Changes
1 file changed (+2 additions, -3 deletions)
View changed files
📝
Dockerfile(+2 -3)📄 Description
As per @gilelias comment https://github.com/sickcodes/Docker-OSX/issues/766#issuecomment-2156706595
I introduced a bug with mouse on old versions by switching
-usb -device usb-kbd -device usb-tabletto
-device qemu-xhci,id=xhci -device usb-kbd,bus=xhci.0 -device usb-tablet,bus=xhci.0This PR reverts the Dockerfile to use in the launch script:
And adds runtime option for newer machines:
Untested.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.