starred/Docker-OSX-sickcodes
1
0
Fork 0
mirror of https://github.com/sickcodes/Docker-OSX.git synced 2026-01-11 14:20:28 +01:00
Code Issues 411 Packages Projects Releases Wiki Activity

[PR #819] Mouse fix - fixes No mouse control when trying to run preinstalled catalina #766 #802

New Issue
Open
opened 2025-12-29 06:22:56 +01:00 by adam · 0 comments
adam commented 2025-12-29 06:22:56 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/sickcodes/Docker-OSX/pull/819
Author: @sickcodes
Created: 9/3/2024
Status: 🔄 Open

Base: master ← Head: mouse-fix

📝 Commits (2)

  • d2c4811 XHCI one line before fixing
  • 2332e96 Revert XHCI/device line to the old usb-kbd/tablet string. And make new images use runtime option -e XHCI_STRING="-device qemu-xhci,id=xhci -device usb-kbd,bus=xhci.0 -device usb-tablet,bus=xhci.0"

📊 Changes

1 file changed (+2 additions, -3 deletions)

View changed files

📝 Dockerfile (+2 -3)

📄 Description

As per @gilelias comment https://github.com/sickcodes/Docker-OSX/issues/766#issuecomment-2156706595

I introduced a bug with mouse on old versions by switching

-usb -device usb-kbd -device usb-tablet
to
-device qemu-xhci,id=xhci -device usb-kbd,bus=xhci.0 -device usb-tablet,bus=xhci.0

This PR reverts the Dockerfile to use in the launch script:

    && tee -a Launch.sh <<< '${XHCI_STRING:--usb -device usb-kbd -device usb-tablet} \' \

And adds runtime option for newer machines:

-e XHCI_STRING="-device qemu-xhci,id=xhci -device usb-kbd,bus=xhci.0 -device usb-tablet,bus=xhci.0"

Untested.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/sickcodes/Docker-OSX/pull/819 **Author:** [@sickcodes](https://github.com/sickcodes) **Created:** 9/3/2024 **Status:** 🔄 Open **Base:** `master` ← **Head:** `mouse-fix` --- ### 📝 Commits (2) - [`d2c4811`](https://github.com/sickcodes/Docker-OSX/commit/d2c4811b6af063a5fe1df19ece4d239debf903d8) XHCI one line before fixing - [`2332e96`](https://github.com/sickcodes/Docker-OSX/commit/2332e96f892aba4935ef20e2dd1e763a86c056d7) Revert XHCI/device line to the old usb-kbd/tablet string. And make new images use runtime option `-e XHCI_STRING="-device qemu-xhci,id=xhci -device usb-kbd,bus=xhci.0 -device usb-tablet,bus=xhci.0"` ### 📊 Changes **1 file changed** (+2 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `Dockerfile` (+2 -3) </details> ### 📄 Description As per @gilelias comment https://github.com/sickcodes/Docker-OSX/issues/766#issuecomment-2156706595 I introduced a bug with mouse on old versions by switching `-usb -device usb-kbd -device usb-tablet` to `-device qemu-xhci,id=xhci -device usb-kbd,bus=xhci.0 -device usb-tablet,bus=xhci.0` This PR reverts the Dockerfile to use in the launch script: ```bash && tee -a Launch.sh <<< '${XHCI_STRING:--usb -device usb-kbd -device usb-tablet} \' \ ``` And adds runtime option for newer machines: ```bash -e XHCI_STRING="-device qemu-xhci,id=xhci -device usb-kbd,bus=xhci.0 -device usb-tablet,bus=xhci.0" ``` Untested. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 06:22:56 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
enhancement
following upstream developments
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/Docker-OSX-sickcodes#802
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?