[PR #134] [MERGED] Fix helm installation failure and cleanup values organization #702

New Issue

adam · 2025-12-29T06:22:31+01:00

adam commented

2025-12-29 06:22:31 +01:00

📋 Pull Request Information

Original PR: https://github.com/sickcodes/Docker-OSX/pull/134
Author: @cephasara
Created: 1/24/2021
Status: ✅ Merged
Merged: 1/24/2021
Merged by: @sickcodes

Base: master ← Head: master

📝 Commits (1)

2567054 remove cmd to install kernel in pod runtime as it has been migrated to Dockerfile

📊 Changes

2 files changed (+55 additions, -54 deletions)

View changed files

📝 helm/templates/configmap.yaml (+20 -21)
📝 helm/values.yaml (+35 -33)

📄 Description

This PR addresses the leftover attribute and command to install a kernel in the pod at runtime. This has been migrated to the Dockerfile itself, so it doesn't take any longer for the pod to start. I accidentally left this in the chart template when I was testing. 😅

Currently, this prevents helm from installing the chart, so this fix is the main reason for this PR.

Additionally, this PR migrates all macOS specific commands out into their own value map so it is a bit cleaner organizationally speaking.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/sickcodes/Docker-OSX/pull/134 **Author:** [@cephasara](https://github.com/cephasara) **Created:** 1/24/2021 **Status:** ✅ Merged **Merged:** 1/24/2021 **Merged by:** [@sickcodes](https://github.com/sickcodes) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`2567054`](https://github.com/sickcodes/Docker-OSX/commit/25670548051dfb87cf9de83744ace67a312fa763) remove cmd to install kernel in pod runtime as it has been migrated to Dockerfile ### 📊 Changes **2 files changed** (+55 additions, -54 deletions) <details> <summary>View changed files</summary> 📝 `helm/templates/configmap.yaml` (+20 -21) 📝 `helm/values.yaml` (+35 -33) </details> ### 📄 Description This PR addresses the leftover attribute and command to install a kernel in the pod at runtime. This has been migrated to the Dockerfile itself, so it doesn't take any longer for the pod to start. I accidentally left this in the chart template when I was testing. 😅 Currently, this prevents helm from installing the chart, so this fix is the main reason for this PR. Additionally, this PR migrates all macOS specific commands out into their own value map so it is a bit cleaner organizationally speaking. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 06:22:31 +01:00

adam closed this issue

2025-12-29 06:22:31 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/Docker-OSX-sickcodes#702